summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix 2.11 changelog ancestor, missed at 2.10 branching (#74123)stable-2.11-branchpointRick Elrod2021-04-051-1/+1
| | | Signed-off-by: Rick Elrod <rick@elrod.me>
* Implement workaround for stdout deadlock in multiprocessing shutdown (#74099)Matt Martz2021-04-052-0/+16
|
* Add ansible-test six constraint for Python 2.6.Matt Clay2021-04-012-0/+3
|
* Fixed link to win_package module (#74090)Hunter Lannon2021-04-011-1/+1
|
* Fix debug factsetter (#74067)Brian Coca2021-03-315-3/+29
| | | | * prevent debug from setting namespaced facts as tlv * also added tests
* Porting guide update for ansible-4.0 alpha3 (#74075)Toshio Kuratomi2021-03-311-11/+28
|
* Fix ansible-test coverage exporting.Matt Clay2021-03-304-3/+17
| | | | | ci_complete ci_coverage
* Fix comment in iptables unit test (#74061)Amin Vakil2021-03-301-1/+1
|
* Update the porting guide for a new ansible version (#74073)Toshio Kuratomi2021-03-301-1/+73
|
* import openbsd patches (#74056)chemsaf32021-03-304-7/+56
| | | | | * add openbsd service info * Create openbsd-service.yml * Update var name
* Clarify tags on tasks are applied with OR and not AND (#74038)Baptiste Mille-Mathias2021-03-301-2/+2
| | | | Co-authored-by: flowerysong <junk+github@flowerysong.com>
* Update Ansible release version to v2.11.0b4.post0. (#74064)Rick Elrod2021-03-301-1/+1
|
* New release v2.11.0b4 (#74063)v2.11.0b4Rick Elrod2021-03-304-1/+68
|
* nonzero exit code on `ansible galaxy collection verify` failures (#74051)Matt Davis2021-03-294-13/+48
|
* pause - do not continue with '\r' when timeout is set (#74030)Alexander Sowitzki2021-03-293-13/+32
| | | | | Original function of pause was, to only allow user input (finished with enter) when no timeout was set. This restores the behaviour.
* add --offline option to galaxy collection verify (#74040)Matt Davis2021-03-296-92/+180
| | | | | * --offline allows in-place verify for installed collections with manifests * manifest hash, collection name, version, and path are now always displayed * test updates
* Revert "Add duplicated set filter and documentation (#72729)" (#74053)Felix Fontein2021-03-284-26/+0
| | | | | This reverts commit 99a6627c60d8734d90f6982107eebb9de24ba54d. * ci_complete
* Temporarily disable strategy units (#74048)Matt Martz2021-03-271-0/+4
|
* Add duplicated set filter and documentation (#72729)Baptiste Mille-Mathias2021-03-274-0/+26
| | | Co-authored-by: Kerry <kerry@flatline-studios.com>
* updated link to ansible.builtin.user password (#73789)Lydie2021-03-261-1/+1
|
* Correctly set path and fullpath for template vars (#73924)Brian Coca2021-03-265-6/+18
| | | | | | * Correctly set path and fullpath for template vars don't expect path to always be full path also added exception/tb on action fail
* Fix setup subset (#74022)Brian Coca2021-03-264-10/+31
| | | | | | * fix error msg on bad subset * added test * handle more raised but not handled fact exceptions
* documents the use of ansible.legacy (#73942)Alicia Cozine2021-03-251-3/+20
|
* Update version on FreeBSD (#73664)Leandro Scardua2021-03-251-1/+1
| | | | | | | | | | ##### SUMMARY <!--- Your description here --> On the main freebsd change, and no the version: py37-ansible ##### ISSUE TYPE - Docs Pull Request +label: docsite_pr
* update docs to uninstall ansible-base on upgrade (#74024)Sandra McCann2021-03-251-3/+34
|
* Update playbooks_variables.rst. To say you can define variables within a ↵sgpinkus2021-03-251-4/+4
| | | | | playbook is somewhat misleading. Variables are defined within plays and are only visible within the play they are defined in *not* the entire playbook. There is no way to define vars to have strictly playbook scope. (#73986) +label: docsite_pr
* Added prerequisites to install for CentOS (#73993)Marketka2021-03-251-0/+12
| | | | | | | | * Added prerequisites to install for CentOS as well so CentOS users don't have to look for alternatives for each Ubuntu package. Signed-off-by: mm667937 <marketa.muzikova@broadcom.com> Signed-off-by: mm667937 <marketa.muzikova@broadcom.com>
* Use FQCN for module set_stats (#74028)Baptiste Mille-Mathias2021-03-251-6/+6
|
* Docs: Add filter "urlencode" with example (#74034)saruter2021-03-251-0/+8
| | | * Add example for URLENCODE filter
* use present tense for porting guide entries (#74021)Alicia Cozine2021-03-251-11/+8
| | | | Co-authored-by: Toshio Kuratomi <a.badger@gmail.com> Co-authored-by: Sandra McCann <samccann@redhat.com>
* dev_guide/testing_integration: update image list (#74017)Andrew Klychkov2021-03-251-3/+3
|
* Introduce the concept of playbooks early on (#74018)David Greaves2021-03-251-0/+50
| | | | * Introduce the concept of playbooks early on Co-authored-by: Sandra McCann <samccann@redhat.com>
* argspec validation - fix apply_defaults (#74029)Felix Fontein2021-03-254-2/+46
| | | * Add test
* Updating Community docs with DO information (#74019)Mark Mercado2021-03-241-0/+1
|
* dnf test - update libmodulemd when updating python3-dnf (#74025)Sam Doran2021-03-241-0/+1
| | | | | The dependency version is set too low in the latest version of the package. https://bugzilla.redhat.com/show_bug.cgi?id=1942236
* Documentation: update committer_guidelines.rst (#73782)Andrew Klychkov2021-03-241-110/+31
| | | | Co-authored-by: Sandra McCann <samccann@redhat.com> Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
* Update the porting guide for a new ansible version (#74016)Toshio Kuratomi2021-03-241-0/+21
|
* Docsite: clarify a changelog entry format (#73902)Andrew Klychkov2021-03-241-1/+19
| | | | | | Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Sandra McCann <samccann@redhat.com>
* apt_key - update key ID and URL used in testSam Doran2021-03-231-4/+4
| | | | | The GPG key in getfedore.org/static/fedora.gpg changed and caused the test to fail. Update to using the new key ID and save the GPG file in our S3 to prevent spontaneous changes/breakage.
* Add integration tests for add_collection_to_versions_and_dates(), and extend ↵Felix Fontein2021-03-2316-0/+618
| | | | | | | | | | | ansible-doc tests (#73601) * Add add_collection_to_versions_and_dates integration tests. * Add doc fragment tests with fragments from other collections. * Remove trailing whitespace (Python 2's json.dump inserts some). * Use ' ' instead of '\s'.
* setup virtualization: fix RHEV product_name (#73919)Martin Nečas2021-03-231-1/+1
|
* Adding jborean93/WindowsServer2019 in docs (#73950)Jim Speir2021-03-231-0/+1
|
* fix wait_for looping when missing net module (#73963)Brian Coca2021-03-232-27/+32
| | | fixes #43486
* Fix trailing whitespace in Conditional debug() (#73956)Alex Willmer2021-03-231-1/+1
| | | Signed-off-by: Alex Willmer <alex@moreati.org.uk>
* less blocking on fact reading (#73951)Brian Coca2021-03-232-10/+33
| | | | | | | * less blocking on fact reading Co-authored-by: Martin Krizek <martin.krizek@gmail.com>
* Fix wrong backup directory var name in apt module (#73840)Xabier Napal2021-03-222-1/+5
| | | * Fix wrong backup directory var name in apt module
* Update Ansible release version to v2.11.0b3.post0. (#73980)Rick Elrod2021-03-201-1/+1
|
* New release v2.11.0b3 (#73977)v2.11.0b3Rick Elrod2021-03-204-1/+71
|
* add porting guide info for optional module_utils (#73979)Matt Davis2021-03-201-0/+2
|
* Use ArgumentSpecValidator in AnsibleModule (#73703)Sam Doran2021-03-1919-1118/+1034
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Begin using ArgumentSpecValidator in AnsibleModule * Add check parameters to ArgumentSpecValidator Add additional parameters for specifying required and mutually exclusive parameters. Add code to the .validate() method that runs these additional checks. * Make errors related to unsupported parameters match existing behavior Update the punctuation in the message slightly to make it more readable. Add a property to ArgumentSpecValidator to hold valid parameter names. * Set default values after performining checks * FIx sanity test failure * Use correct parameters when checking sub options * Use a dict when iterating over check functions Referencing by key names makes things a bit more readable IMO. * Fix bug in comparison for sub options evaluation * Add options_context to check functions This allows the parent parameter to be added the the error message if a validation error occurs in a sub option. * Fix bug in apply_defaults behavior of sub spec validation * Accept options_conext in get_unsupported_parameters() If options_context is supplied, a tuple of parent key names of unsupported parameter will be created. This allows the full "path" to the unsupported parameter to be reported. * Build path to the unsupported parameter for error messages. * Remove unused import * Update recursive finder test * Skip if running in check mode This was done in the _check_arguments() method. That was moved to a function that has no way of calling fail_json(), so it must be done outside of validation. This is a silght change in behavior, but I believe the correct one. Previously, only unsupported parameters would cause a failure. All other checks would not be executed if the modlue did not support check mode. This would hide validation failures in check mode. * The great purge Remove all methods related to argument spec validation from AnsibleModule * Keep _name and kind in the caller and out of the validator This seems a bit awkward since this means the caller could end up with {name} and {kind} in the error message if they don't run the messages through the .format() method with name and kind parameters. * Double moustaches work I wasn't sure if they get stripped or not. Looks like they do. Neat trick. * Add changelog * Update unsupported parameter test The error message changed to include name and kind. * Remove unused import * Add better documentation for ArgumentSpecValidator class * Fix example * Few more docs fixes * Mark required and mutually exclusive attributes as private * Mark validate functions as private * Reorganize functions in validation.py * Remove unused imports in basic.py related to argument spec validation * Create errors is module_utils We have errors in lib/ansible/errors/ but those cannot be used by modules. * Update recursive finder test * Move errors to file rather than __init__.py * Change ArgumentSpecValidator.validate() interface Raise AnsibleValidationErrorMultiple on validation error which contains all AnsibleValidationError exceptions for validation failures. Return the validated parameters if validation is successful rather than True/False. Update docs and tests. * Get attribute in loop so that the attribute name can also be used as a parameter * Shorten line * Update calling code in AnsibleModule for new validator interface * Update calling code in validate_argument_spec based in new validation interface * Base custom exception class off of Exception * Call the __init__ method of the base Exception class to populate args * Ensure no_log values are always updated * Make custom exceptions more hierarchical This redefines AnsibleError from lib/ansible/errors with a different signature since that cannot be used by modules. This may be a bad idea. Maybe lib/ansible/errors should be moved to module_utils, or AnsibleError defined in this commit should use the same signature as the original. * Just go back to basing off Exception * Return ValidationResult object on successful validation Create a ValidationResult class. Return a ValidationResult from ArgumentSpecValidator.validate() when validation is successful. Update class and method docs. Update unit tests based on interface change. * Make it easier to get error objects from AnsibleValidationResultMultiple This makes the interface cleaner when getting individual error objects contained in a single AnsibleValidationResultMultiple instance. * Define custom exception for each type of validation failure These errors indicate where a validation error occured. Currently they are empty but could contain specific data for each exception type in the future. * Update tests based on (yet another) interface change * Mark several more functions as private These are all doing rather "internal" things. The ArgumentSpecValidator class is the preferred public interface. * Move warnings and deprecations to result object Rather than calling deprecate() and warn() directly, store them on the result object so the caller can decide what to do with them. * Use subclass for module arg spec validation The subclass uses global warning and deprecations feature * Fix up docs * Remove legal_inputs munging from _handle_aliases() This is done in AnsibleModule by the _set_internal_properties() method. It only makes sense to do that for an AnsibleModule instance (it should update the parameters before performing validation) and shouldn't be done by the validator. Create a private function just for getting legal inputs since that is done in a couple of places. It may make sense store that on the ValidationResult object. * Increase test coverage * Remove unnecessary conditional ci_complete * Mark warnings and deprecations as private in the ValidationResult They can be made public once we come up with a way to make them more generally useful, probably by creating cusom objects to store the data in more structure way. * Mark valid_parameter_names as private and populate it during initialization * Use a global for storing the list of additonal checks to perform This list is used by the main validate method as well as the sub spec validation.
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-29 23:48:00 +0100