diff options
| author | Nathan Cutler <ncutler@suse.com> | 2016-03-25 17:34:47 +0100 |
|---|---|---|
| committer | Nathan Cutler <ncutler@suse.com> | 2016-03-25 17:39:39 +0100 |
| commit | 65770059cb319da9ffbc2866df1ffa8b35267614 (patch) | |
| tree | bbf60cfd636708f7c76af9bf3dc27b9125bdc3e5 /SubmittingPatches.rst | |
| parent | Merge pull request #8038 from badone/wip-crushtool-crash (diff) | |
| download | ceph-65770059cb319da9ffbc2866df1ffa8b35267614.tar.xz ceph-65770059cb319da9ffbc2866df1ffa8b35267614.zip | |
doc: amend Fixes instructions in SubmittingPatches
Since the "Fixes: #..." line is interpreted by GitHub as referring to a
pull request, yet the intention is for it to refer to the tracker issue,
change our instructions to use the full tracker issue URL.
Now that github pull request numbers are in the 8000s, there are cases when
a PR is wrongly closed by a "Fixes: #..." line in a commit message. See
https://github.com/ceph/ceph/pull/8286#event-603120191
for one such case.
Signed-off-by: Nathan Cutler <ncutler@suse.com>
Diffstat (limited to 'SubmittingPatches.rst')
| -rw-r--r-- | SubmittingPatches.rst | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/SubmittingPatches.rst b/SubmittingPatches.rst index 87855d5f813..1f6c23166b9 100644 --- a/SubmittingPatches.rst +++ b/SubmittingPatches.rst @@ -405,7 +405,7 @@ feature. tracked by http://tracker.ceph.com, consider adding a ``Fixes:`` tag to connect this change to addressed issue(s). So a line saying :: - Fixes: #12345 + Fixes: http://tracker.ceph.com/issues/12345 is added before the ``Signed-off-by:`` line stating that this commit addresses http://tracker.ceph.com/issues/12345. It helps the reviewer to @@ -419,7 +419,7 @@ feature. * update the man page for bar with the newly added "--foo" option. * fix a typo - Fixes: #12345 + Fixes: http://tracker.ceph.com/issues/12345 Signed-off-by: Random J Developer <random@developer.example.org> 4. Separate your changes. |