crimson/common: write configs synchronously on shard.0

to avoid potential racings on the same shard. before this change, we
apply the change in async. after this change, all changes happens on the
owner shard (i.e. shard.0), and the changes are applied synchronously.

Signed-off-by: Kefu Chai <kchai@redhat.com>

1 files changed, 6 insertions, 8 deletions

diff --git a/src/test/crimson/test_config.cc b/src/test/crimson/test_config.cc
index eaf9261c30a..5d0c104b8fc 100644
--- a/src/test/crimson/test_config.cc
+++ b/src/test/crimson/test_config.cc
@@ -11,17 +11,15 @@ static seastar::future<> test_config()
   return ceph::common::sharded_conf().start().then([] {
     return ceph::common::sharded_conf().invoke_on(0, &Config::start);
   }).then([] {
-    return ceph::common::sharded_conf().invoke_on_all([](auto& config) {
+    return ceph::common::sharded_conf().invoke_on_all([](Config& config) {
       return config.set_val("osd_tracing", "true");
     });
   }).then([] {
-    return ceph::common::local_conf().get_val<bool>("osd_tracing");
-  }).then([](bool osd_tracing) {
-    if (osd_tracing) {
-      return seastar::make_ready_future<>();
-    } else {
-      throw std::runtime_error("run osd_tracing");
-    }
+    return ceph::common::sharded_conf().invoke_on_all([](Config& config) {
+      if (!config.get_val<bool>("osd_tracing")) {
+        throw std::runtime_error("run osd_tracing");
+      }
+    });
   }).then([] {
     return ceph::common::sharded_conf().stop();
   });