diff options
author | Kefu Chai <kchai@redhat.com> | 2021-08-11 05:40:46 +0200 |
---|---|---|
committer | Kefu Chai <kchai@redhat.com> | 2021-08-13 03:33:14 +0200 |
commit | c537ffe22c2888e5e20394947922353e3134584d (patch) | |
tree | cb13983e218cb5e7f66c567ed4bc64eeed6f2580 /src/tools/rbd/action/Snap.cc | |
parent | test/crimson: build without "using namespace std" (diff) | |
download | ceph-c537ffe22c2888e5e20394947922353e3134584d.tar.xz ceph-c537ffe22c2888e5e20394947922353e3134584d.zip |
tools/rbd: build without "using namespace std"
* add "std::" prefix in headers
* add "using" declarations in .cc files.
so we don't rely on "using namespace std" in one or more included
headers.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Diffstat (limited to '')
-rw-r--r-- | src/tools/rbd/action/Snap.cc | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/tools/rbd/action/Snap.cc b/src/tools/rbd/action/Snap.cc index e8a9cb1b8d1..cb87735f905 100644 --- a/src/tools/rbd/action/Snap.cc +++ b/src/tools/rbd/action/Snap.cc @@ -72,7 +72,7 @@ int do_list_snaps(librbd::Image& image, Formatter *f, bool all_snaps, librados:: struct timespec timestamp; bool snap_protected = false; image.snap_get_timestamp(s->id, ×tamp); - string tt_str = ""; + std::string tt_str = ""; if(timestamp.tv_sec != 0) { time_t tt = timestamp.tv_sec; tt_str = ctime(&tt); @@ -186,7 +186,7 @@ int do_list_snaps(librbd::Image& image, Formatter *f, bool all_snaps, librados:: t << s->id << s->name << stringify(byte_u_t(s->size)) << protected_str << tt_str; if (all_snaps) { - ostringstream oss; + std::ostringstream oss; oss << snap_namespace_name; if (get_group_res == 0) { @@ -291,7 +291,7 @@ int do_purge_snaps(librbd::Image& image, bool no_progress) } else if (0 == snaps.size()) { return 0; } else { - list<std::string> protect; + std::list<std::string> protect; snaps.erase(remove_if(snaps.begin(), snaps.end(), boost::bind(utils::is_not_user_snap_namespace, &image, _1)), @@ -415,7 +415,7 @@ int execute_list(const po::variables_map &vm, bool all_snaps = vm[ALL_NAME].as<bool>(); r = do_list_snaps(image, formatter.get(), all_snaps, rados); if (r < 0) { - cerr << "rbd: failed to list snapshots: " << cpp_strerror(r) + std::cerr << "rbd: failed to list snapshots: " << cpp_strerror(r) << std::endl; return r; } @@ -462,8 +462,8 @@ int execute_create(const po::variables_map &vm, r = do_add_snap(image, snap_name.c_str(), flags, vm[at::NO_PROGRESS].as<bool>()); if (r < 0) { - cerr << "rbd: failed to create snapshot: " << cpp_strerror(r) - << std::endl; + std::cerr << "rbd: failed to create snapshot: " << cpp_strerror(r) + << std::endl; return r; } return 0; |