summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #59821 from rhcs-dashboard/bz-2311899afreen232024-09-1912-17/+17
|\ | | | | | | | | mgr/dashboard: Fix space between the text in few sections Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
| * mgr/dashboard: Fix space between the text in few sectionsPrachi Goel2024-09-1812-17/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: https://tracker.ceph.com/issues/68098 Signed-off-by: Prachi prgoel@redhat.com Fixes: Fix space between the text in below sections Observability/Alerts —> Active Alerts
 Observability/ Alerts —> Alerts
 Observability/Alerts —> Silences Cluster/Pools —> overall performance Cluster/Hosts/ —> overall performance

 Cluster/ OSDs —> overall performance Block/iSCSI/ —> Targets Object/Overview —> Multi-Site Sync Status cluster --> pools -->Pools list --> under each entry: Performance details section Cluster --> Hosts --> Hosts List --> under each entry: Performance details section Cluster --> OSDs --> OSD's List --> under each entry: Performance details section Signed-off-by: Prachi Goel <prachi@li-f0e8f2cc-27e0-11b2-a85c-b2772164128d.ibm.com>
* | Merge pull request #59026 from aclamk/fix-aclamk-blk-kernel-uninitializedIgor Fedotov2024-09-191-0/+1
|\ \ | | | | | | | | | | | | | | | blk/kernel: Fix uninitialized discard_stop Revewied-by: Radoslaw Zarzynski <rzarzyns@redhat.com> Revewied-by: Ronen Friedman <rfriedma@redhat.com>
| * | blk/kernel: Fix uninitialized discard_stopAdam Kupczyk2024-08-051-0/+1
| | | | | | | | | | | | | | | | | | Value discard_stop could be uninitialized. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
* | | Merge pull request #59611 from cbodley/wip-cls-rgw-busy-reshardingCasey Bodley2024-09-1914-210/+374
|\ \ \ | | | | | | | | | | | | | | | | cls/rgw: duplicate reshard checks in all cls_rgw write operations Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
| * | | cls/rgw: duplicate reshard checks in all cls_rgw write operationsCasey Bodley2024-09-054-27/+96
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with the addition of the reshard log, all write ops now have to read the omap header themselves. this read duplicates the one in cls_rgw_guard_bucket_resharding(), leading to a minor performance regression this commit prepares a long-term fix for this regression by duplicating the the reshard check done by cls_rgw_guard_bucket_resharding() in each write operation. this will allow the cls_rgw_guard_bucket_resharding() calls to be removed from rgw two releases later when we can guarantee that all OSDs are performing this check for all write operations Signed-off-by: Casey Bodley <cbodley@redhat.com>
| * | | cls/rgw: remove unused cls_rgw_bi_get_vals()Casey Bodley2024-09-055-115/+0
| | | | | | | | | | | | | | | | Signed-off-by: Casey Bodley <cbodley@redhat.com>
| * | | rgw/rados: remove unused RGWRados::bi_get_vals()Casey Bodley2024-09-052-12/+0
| | | | | | | | | | | | | | | | Signed-off-by: Casey Bodley <cbodley@redhat.com>
| * | | rgw/reshard: use cls_rgw_bi_put_entries() when replaying the reshard logCasey Bodley2024-09-051-29/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | use cls_rgw_bi_put_entries() in BucketReshardShard::flush() to avoid blocking on the extra call to bi_get_vals() Signed-off-by: Casey Bodley <cbodley@redhat.com>
| * | | cls/rgw: add bulk cls_rgw_bi_put_entries() op for reshardCasey Bodley2024-09-058-0/+248
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | adds a bulk api for reshard to write entries to the target index shard object. this takes care of the bucket stats updates so that rgw's reshard logic doesn't have to worry about it Signed-off-by: Casey Bodley <cbodley@redhat.com>
| * | | test/cls/rgw: simplify set_reshard_status()Casey Bodley2024-09-051-7/+4
| | | | | | | | | | | | | | | | Signed-off-by: Casey Bodley <cbodley@redhat.com>
| * | | test/cls/rgw: helpers take const stringsCasey Bodley2024-09-051-5/+5
| | | | | | | | | | | | | | | | Signed-off-by: Casey Bodley <cbodley@redhat.com>
| * | | cls/rgw: remove rgw_bucket_dir_entry_meta default ctorCasey Bodley2024-09-051-7/+4
| | | | | | | | | | | | | | | | | | | | | | | | to allow aggregate initialization Signed-off-by: Casey Bodley <cbodley@redhat.com>
| * | | cls/rgw/client: expose cls_rgw_bucket_init_index2()Casey Bodley2024-09-052-3/+9
| | | | | | | | | | | | | | | | Signed-off-by: Casey Bodley <cbodley@redhat.com>
| * | | cls/rgw: rgw_cls_bi_entry::get_info() is constCasey Bodley2024-09-052-2/+2
| | | | | | | | | | | | | | | | Signed-off-by: Casey Bodley <cbodley@redhat.com>
| * | | cls/rgw: remove rgw_cls_bi_entry default ctorCasey Bodley2024-09-051-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | to allow aggregate initialization Signed-off-by: Casey Bodley <cbodley@redhat.com>
* | | | Merge pull request #59793 from ronen-fr/wip-rf-15sreduce-qprioRonen Friedman2024-09-191-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | osd/scrub: reduce osd_requested_scrub_priority default value Reviewed-by: Samuel Just <sjust@redhat.com> Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
| * | | | osd/scrub: reduce osd_requested_scrub_priority default valueRonen Friedman2024-09-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | No scrub messages should have a higher priority than client op messages. The default value should therefore be below osd_client_op_priority, which is 63. But as a followup PR would eliminate the special queue priority for 'requested' scrub messages, the default value is set to equal osd_scrub_priority. Fixes: https://tracker.ceph.com/issues/68072 Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
* | | | | Merge pull request #59807 from afreen23/wip-group-switcherafreen232024-09-1912-46/+206
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | mgr/dashboard: Add group selector in subsystems views Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
| * | | | | mgr/dashboard: Add group selector in subsystems viewsAfreen Misbah2024-09-1912-46/+206
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allows listing the subsystems per gateway group. Using carbon combobox component for the selector. Adds unit tests for switcher and updates existing. Fixes https://tracker.ceph.com/issues/68129 Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
* | | | | | Merge pull request #59824 from rhcs-dashboard/wizard-carbonNizamudeen A2024-09-1919-406/+501
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | mgr/dashboard: carbonize the wizard component Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
| * | | | | | mgr/dashboard: carbonize the wizard componentNizamudeen A2024-09-1819-406/+501
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: https://tracker.ceph.com/issues/68103 Signed-off-by: Nizamudeen A <nia@redhat.com>
* | | | | | | Merge pull request #59488 from adk3798/revert-cephadm-require-nvmeof-groupAdam King2024-09-195-211/+6
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | mgr/cephadm: default to empty string nvmeof group name rather than requiring it Reviewed-by: John Mulligan <jmulligan@redhat.com>
| * | | | | | | mgr/orchestrator: allow passing group to apply/add nvmeof commandsAdam King2024-08-281-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We no longer require the group when applying an nvmeof spec but we still want to allow the commands to take a group parameter (and this will at least make a group name required when creating a new service on the command line) Signed-off-by: Adam King <adking@redhat.com>
| * | | | | | | Revert "mgr/cephadm: migrate nvmeof specs without group field"Adam King2024-08-283-207/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d7b00eab08b006c5d10268a5aab7bc8dfc146c08. It was decided by the nvmeof team to stick with defaulting to an empty string rather than forcing the users onto other non-empty names when they upgrade Signed-off-by: Adam King <adking@redhat.com>
| * | | | | | | Revert "mgr/orchestrator: require "group" field for nvmeof specs"Adam King2024-08-282-7/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit f6d552d7c777f1160545188dcffa6b685b05ca8a. It was decided by the nvmeof team to stick with defaulting to an empty string rather than forcing the users onto other non-empty names when they upgrade Signed-off-by: Adam King <adking@redhat.com>
* | | | | | | | Merge pull request #59709 from ronen-fr/wip-rf-rm-flagRonen Friedman2024-09-1910-415/+197
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | osd/scrub: remove the requested_scrub flags set Reviewed-by: Samuel Just <sjust@redhat.com>
| * | | | | | | | osd/scrub: remove the 'planned scrub' flag setRonen Friedman2024-09-106-107/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
| * | | | | | | | osd/scrub: remove requested_scrub_t::need_autoRonen Friedman2024-09-103-79/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | as part of the ongoing work to remove the 'planned scrub' flag set. flags_to_deep_priority() is no longer needed, and can be removed. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
| * | | | | | | | osd/scrub: set_op_parameters() no longer uses the 'requested' flagsRonen Friedman2024-09-103-66/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ... and the same goes for request_rescrubbing(). The requested_flag_t::auto_repair can now be removed. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
| * | | | | | | | osd/scrub: remove requested_scrub_t::must_repairRonen Friedman2024-09-092-12/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | as part of the ongoing work to remove the 'planned scrub' flag set. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
| * | | | | | | | osd/scrub: complete on_mid_scrub_abort() refactoringRonen Friedman2024-09-092-26/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now - referring to the aborted target and the updated job's target of that urgency, to set the scheduling details of the latter. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
| * | | | | | | | osd/scrub: fix scheduled_at for distinct urgenciesRonen Friedman2024-09-091-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that both 'after repair' scrubs and 'repair after errors' scrubs each have their own urgency, we no longer need to set the scheduled_at to a magic, before everything else, value. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
| * | | | | | | | osd/scrub: implement urgency_t::repairingRonen Friedman2024-09-094-24/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | to be used for repair scrubs triggered when a shallow scrub ends with repairable errors. The deep scrub that follows should not have the same urgency as an operator-requested repair scrub. It should not, for example, be allowed to run when the OSD is performing a recovery, osd_scrub_during_recovery is false, and osd_repair_during_recovery is set. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
| * | | | | | | | osd/scrub: remove requested_scrub_t::must_deep_scrubRonen Friedman2024-09-092-21/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | as part of the ongoing work to remove the 'planned scrub' flag set. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
| * | | | | | | | osd/scrub: remove requested_scrub_t::must_scrubRonen Friedman2024-09-092-20/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | as part of the ongoing work to remove the 'planned scrub' flag set. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
| * | | | | | | | osd/scrub: base queue priority on the urgency of the scrub targetRonen Friedman2024-09-093-13/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | instead of querying 'planned scrub' flags. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
| * | | | | | | | osd/scrub: remove remaining refs to the Scrubber's 'required' flagRonen Friedman2024-09-092-24/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and the flag itself Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
| * | | | | | | | osd/scrub: mid-scrub-aborts logic should use the new urgency attributesRonen Friedman2024-09-091-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixing PgScrubber::should_abort() to use the observes_noscrub_flags() qualifier on the scrubbing target's urgency, instead of the testing the 'required' flag. This is a part of the ongoing work to remove the 'planned scrub' flag set, including all logic that uses it. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
| * | | | | | | | osd/scrub: remove flags_to_shallow_priority()Ronen Friedman2024-09-094-39/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As part of the removal of the 'planned scrub' flags (initiated in the previous PRs): flags_to..() is called from PgScrubber::update_targets(), and checks for two special cases before calling adjust_shallow_schedule(): 1) if the scrub is mandatory due to stats_invalid: the code to handle this case is moved to PgScrubber::update_targets(). 2) if the scrub is mandatory due to operator request: this is already handled by operator_forced_targets(). Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
* | | | | | | | | Merge pull request #59845 from phlogistonjohn/jjm-py312-mypy-importAdam King2024-09-191-1/+1
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | pybind/mgr: attempt to fix mypy importing from python-common Reviewed-by: Adam King <adking@redhat.com> Reviewed-by: Sachin Prabhu <sp@spui.uk>
| * | | | | | | | | pybind/mgr: attempt to fix mypy importing from python-commonJohn Mulligan2024-09-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For some reason mypy on python 3.12 can no longer automatically find imports from python-common. Help it out by expanding the MYPYPATH value for the tox.ini. Signed-off-by: John Mulligan <jmulligan@redhat.com>
* | | | | | | | | | Merge pull request #59653 from ↵Matan Breizman2024-09-191-5/+3
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | NitzanMordhai/wip-nitzan-crimson-add-crontab-weekly-tests qa/crontab: Add weekly crimson-rados suites Reviewed-by: Matan Breizman <mbreizma@redhat.com>
| * | | | | | | | | | qa/crontab: Add weekly crimson-rados suitesNitzan Mordechai2024-09-081-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit adds the Crimson-RADOS suite to the crontab jobs that run weekly, matching the priority of the RADOS suite. Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
* | | | | | | | | | | Merge pull request #59859 from afreen23/wip-nvme-service-fixesNizamudeen A2024-09-193-12/+12
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | mgr/dashboard: Service form fixes for mTLS Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com> Reviewed-by: Nizamudeen A <nia@redhat.com>
| * | | | | | | | | | | mgr/dashboard: Service form fixes for mTLSAfreen Misbah2024-09-183-12/+12
| | |_|_|_|_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Due to conflicts with SSO PR, mTLS fields are not updated properly in code. This is not happening only in main as noted: https://github.com/ceph/ceph/pull/59819#issuecomment-2356523491 The effect of this issue is mtls based fields not showing in service form Fixes https://tracker.ceph.com/issues/68133 Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
* | | | | | | | | | | Merge pull request #59856 from ↵Zac Dover2024-09-191-9/+10
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | zdover23/wip-doc-2024-09-18-rados-ops-health-checks doc/rados: add confval directives to health-checks Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
| * | | | | | | | | | | doc/rados: add confval directives to health-checksZac Dover2024-09-181-9/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add confval directives to doc/rados/operations/health-checks.rst, as requested by Anthony D'Atri here: https://github.com/ceph/ceph/pull/59635#pullrequestreview-2286205705 Signed-off-by: Zac Dover <zac.dover@proton.me>
* | | | | | | | | | | | Merge PR #59809 into mainPatrick Donnelly2024-09-197-16/+98
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * refs/pull/59809/head: COPYING,common/*s390x*: distribute under Apache 2 license for s390x arch/s390x: add license notices, use LGPL Reviewed-by: Ilya Dryomov <idryomov@redhat.com> Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
| * | | | | | | | | | | | COPYING,common/*s390x*: distribute under Apache 2 license for s390xPatrick Donnelly2024-09-185-14/+72
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Ceph project cannot distributed GPL code as it is incompatible with the LGPL that all Ceph code is licensed under. Since s390x is dual-licensed, we choose to use the Apache 2 license. Fixes: https://tracker.ceph.com/issues/68084 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-20 06:28:05 +0100