| Commit message (Collapse) | Author | Files | Lines |
|
We've seen this failing on both btrfs (Guido) and XFS (Oliver). This works
around #2535.
Signed-off-by: Sage Weil <sage@inktank.com>
|
|
Reported-by: Guido Winkelmann <guido-ceph@thisisnotatest.de>
Signed-off-by: Sage Weil <sage@inktank.com>
|
|
This hunk was inadvertantly included in a330c64.
Reported-by: Guido Winkelmann <guido-ceph@thisisnotatest.de>
Signed-off-by: Sage Weil <sage@inktank.com>
|
|
This was required to build on CentOS 6.2. I'm not sure why it worked
without it on Debian.
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
|
|
This fixes #2465. We should never ever use the dumped value
as the format. Never.
Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
|
|
|
|
Signed-off-by: Sage Weil <sage@newdream.net>
|
|
Add BuildRequires: libxml2-devel.
Move BuildRequires: libcurl-devel to a more proper place.
[libs3 and librgw.h bits of patch dropped -sw]
Signed-off-by: Alexandre Oliva <oliva@lsd.ic.unicamp.br>
Signed-off-by: Sage Weil <sage@newdream.net>
|
|
|
|
We appended libs3 to SUBDIRS unconditionally, we only need that
when we actually want to compile it.
Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
|
|
The addition of accounting for simultaneous writers in
f3043fee3e22600cb4349072287842db129588eb could lead to an infinite
loop. This could happen because starting a flush doesn't decrease
dirty_waiters, only the number of dirty bytes (they change to tx). If
dirty_waiters is more than target_dirty, the loop would continue
forever while holding the object cacher lock, since the object cacher
lock is required by the write callbacks.
The extra while (!flusher_stop) loop is unnecessary, so remove it.
This means the flusher thread always releases the lock after starting
flushing, so progress can be made.
Signed-off-by: Sage Weil <sage@inktank.com>
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
|
|
|
|
There isn't one we can rely on existing yet. Broken by
1314a00798ed4b7ef2f2686f0195c5c53c98c2ce while fixing #2452.
Backport: dho
Signed-off-by: Sage Weil <sage@inktank.com>
|
|
|
|
New release key for signing packages. Signed by me (the old release key)
so that existing apt keyrings should be sufficient. New keyrings should
just add the new release key.
Signed-off-by: Sage Weil <sage@newdream.net>
|
|
Backport: dho
Signed-off-by: Sage Weil <sage@inktank.com>
|
|
This lets us ensure that calc_pg_masks() is called when pg[p]_num is set or
modified.
Fixes: #2448
Backport: dho
Signed-off-by: Sage Weil <sage@inktank.com>
|
|
This is sufficient to break our fcntl lock, which breaks the check for
other running daemons.
Broken by f03dc34f7e2fc1707fa00339b917c0d2c93dbdd3
Fixes: #2452
Backport: dho
Signed-off-by: Sage Weil <sage@inktank.com>
|
|
Signed-off-by: Sage Weil <sage@inktank.com>
|
|
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
|
|
Return errors from flushing to the caller. Warn
if an error occurs during invalidation, but don't retry,
since the higher level handles these cases, namely:
* rollback (doing this with an image open is asking for trouble)
* shrink (doing this with writes in flight may create extra objects anyway)
* shutdown (qemu flushes before closing the device)
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
|
|
If a write error occurs, mark the BufferHead dirty again, and
pass the return value to the completion. This makes flushing
return the write error, if one occurs, since the flush callback
is passed as the write callback.
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
|
|
Previously the return value of a read operation was ignored. Now a
read error sets the error field, and changes the BufferHead to a new
error state. Error state BufferHeads are treated as misses so they can
be retried when requested by a user of the ObjectCacher. When _readx
is called again internally, they're treated as hits so the error can
be returned to the user.
The error value is ignored if the BufferHead is not in the error
state.
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
|
|
Only take our absence from the monmap to mean that we were removed if we
were ever a member in the first places.
This fixes the bootstrap case:
- create temp_monmap with existing member(s) plus new guy
- ceph-mon --mkfs --monmap temp_monmap --fsid ...
- start ceph-mon
Basically, this is just using the seed monmap as a way to tell the new
daemon which ip:port to use. Specifying mon addr, public network, or
public addr would also work.
Fixes: #2436
Signed-off-by: Sage Weil <sage@inktank.com>
|
|
This parameter is required and was missing. And fix a typo
|
|
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
|
|
_readx is called again after each bh is read by C_RetryRead. This
resulted in the read being counted many times for the internal
caller that was just checking whether it was done yet.
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
|
|
Make log messages easier to interpret, without subtracting timestamps in
your head.
Signed-off-by: Sage Weil <sage@inktank.com>
|
|
Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
|
|
1) Adjust h2 tags so that section titles are visually differentiated
2) Add 1.5em of margin to all pre blocks and tables
Signed-off-by: Ross Turk <ross@inktank.com>
|
|
Throttling is intended to stop the caller from submitting too many
requests, not blocking requests that are being resent internally. This
prevents a deadlock when handling an osdmap - previously
handle_osd_map could block when resending linger ops due to the
throttling. This would stop the messenger's dispatch thread from
delivering any subsequest messages, so the throttle budget would never
be replenished.
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>
|
|
Also, make sure that we initialize linger_op.session once
we have it.
Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net>
|
|
1) Background color in navbar
2) Correct body fonts
3) Document pane background (below the content)
|
|
|
|
Pass the size of the weight vector into crush_do_rule() to ensure that we
don't access values past the end. This can happen if the caller misbehaves
and passes a weight vector that is smaller than max_devices.
Currently the monitor tries to prevent that from happening, but this will
gracefully tolerate previous bad osdmaps that got into this state. It's
also a bit more defensive.
Signed-off-by: Sage Weil <sage@inktank.com>
|
|
If we insert a new item, make sure max_devices is still the max id + 1.
Signed-off-by: Sage Weil <sage@inktank.com>
|
|
If an osd doesn't exist, don't let users add/update it in the crush map.
Signed-off-by: Sage Weil <sage@inktank.com>
|
|
Signed-off-by: Sage Weil <sage@inktank.com>
|
|
It is possible that the crush map contains device ids that do not exist as
osds. Filter them out of the CRUSH result.
Signed-off-by: Sage Weil <sage@newdream.net>
|
|
error: os/FileJournal.h:48:51: call of overloaded ‘utime_t(int)’ is ambiguous
Signed-off-by: Sage Weil <sage@newdream.net>
|
|
This replaces the hard-coded 1 second writeback timer.
Signed-off-by: Sage Weil <sage@newdream.net>
|
|
Signed-off-by: Sage Weil <sage@newdream.net>
|
|
This is for interpreting lockdep reports.
Signed-off-by: Sage Weil <sage@inktank.com>
|
|
Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
|
|
These default arguments, although handy when we just want to run the test,
just mess things up when we don't actually need them. If we don't specify
them on the CLI, we'll end up using the default ones, and that is just
annoying.
Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
|
|
Use '--test-max-in-flight VAL' (default: 50) or check '--help' for more.
Also, allow the test to work even if we don't specify a conf file.
Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
|
|
Allow the user to have more control on:
- the sizes of the data being written by the operations;
- which operations are suppressed from execution;
- view the throughput;
- specify the periodicity of throughput output.
For the CLI options, '--help' should suffice.
Signed-off-by: Joao Eduardo Luis <jecluis@gmail.com>
|
|
drwxr-xr-x 1031/1031 0 2012-05-07 11:15 ceph-0.46/src/libs3/inc/
drwxr-xr-x 1031/1031 0 2012-05-04 15:28 ceph-0.46/src/libs3/inc/inc/
-rw-r--r-- 1031/1031 2343 2012-05-04 15:28 ceph-0.46/src/libs3/inc/inc/simplexml.h
etc. Freaking autotools!
Signed-off-by: Sage Weil <sage@newdream.net>
|
|
Signed-off-by: Sage Weil <sage@newdream.net>
|
|
Signed-off-by: Sage Weil <sage@newdream.net>
|