| Commit message (Collapse) | Author | Files | Lines |
|---|
|
Currently, RGW returns a 200 on a successful DELETE on a bucket policy but
the S3 API expects a 204:
https://docs.aws.amazon.com/AmazonS3/latest/API/API_DeleteBucketPolicy.html
The sample response in the example above is a 204.
This patch checks the op_ret in `RGWDeleteBucketPolicy::send_response()`
and on a success we turn it to a 204 (or STATUS_NO_CONTENT).
Fixes: https://tracker.ceph.com/issues/69539
Signed-off-by: Simon Jürgensmeyer <simon.juergensmeyer@hetzner-cloud.de>
|
|
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
|
|
Make sure that first_in_ceph_log() doesn't return None (which is
treated as success/"no badness" by the caller) if the cluster log file
is missing.
Fixes: https://tracker.ceph.com/issues/57864
Co-authored-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Christopher Hoffman <choffman@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
|
|
Fixes: https://tracker.ceph.com/issues/69536
Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>
|
|
This commit updates RGW Config Reference - Lifecycle Settings section. In particular it changes the section where two different tunings for two different workloads are suggested. It aims for a more understandable description as asked by the contributors.
Signed-off-by: Laimis Juzeliunas <laimis.juzeliunas@oxylabs.io>
|
|
Handle scenarios where the SSH connection is closed or broken. Ensure
commands like exiting maintenance attempt to reconnect rather than
throwing an error to the user.
Fixes: https://tracker.ceph.com/issues/67905
Signed-off-by: Joshua Blanch <joshua.blanch@clyso.com>
|
|
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
|
|
currently, the dependency logic is duplicated between the different Service
classes and the module.py::_calc_daemon_deps function, which can lead
to issues such as BUGSs, difficulty in maintenance, and other problems
associated with duplicated code. In this change, we are consolidating
all the dependency logic into the Service subclasses to eliminate this
duplication. This way, we also force anybody creating a new Service to
think about its potential dependencies.
Fixes: https://tracker.ceph.com/issues/69021
Signed-off-by: Redouane Kachach <rkachach@ibm.com>
|
|
moved out of the main commit to
facilitate backporting it to pre-C++20.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
|
|
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
|
|
In its get_tracked_conf_keys() member function, the
cacher (in the existing code) initializes a static
function-block variable ('keys'), and uses it for
registering the observer.
But the cacher is instantiated on the type of
the configuration value. Thus, multiple cacher
objects for which the configuration values are
of the same type - share the static 'keys'. Only
one of the observers is registered.
Note that the code could have been simplified
somewhat, if the signature of the
get_tracked_conf_keys() function
was changed to return 'const char* const *'.
Fixes: https://tracker.ceph.com/issues/69236
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
|
|
Signed-off-by: Anuradha Gadge <anuradha.gadge@ibm.com>
|
|
GNU grep v3.8 release notes[1] has the following mention about the usage
of backslashes:
"Regular expressions with stray backslashes now cause warnings, as their
unspecified behavior can lead to unexpected results."
. . .
"The warnings are intended as a transition aid; they are likely to be
errors in future releases."
As a result we see the warning "grep: warning: stray \ before /" during
script execution. Therefore remove the extra `\` from grep command.
[1] https://git.savannah.gnu.org/cgit/grep.git/tree/NEWS#n85
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
|
|
Fixes: https://tracker.ceph.com/issues/68979
Signed-off-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
|
|
Fixes: https://tracker.ceph.com/issues/68979
Signed-off-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
|
|
Signed-off-by: Samuel Just <sjust@redhat.com>
|
|
Add the actual EOL date for the Quincy release (it's 2025-01-13).
Signed-off-by: Zac Dover <zac.dover@proton.me>
|
|
As discussed in https://tracker.ceph.com/issues/69475 this
setting is effectively useless as it only controls the directory
inside the container where the ceph-exporter will write out
its asok file, and has no influence over where it is on the
host where the ceph-exporter daemon is deployed. Given any
custom values for the sock_dir setting would have always
been broken, we decided to skip out on writing a proper migration
step in cephadm to deal with this, and instead just force this
field to be unset
Signed-off-by: Adam King <adking@redhat.com>
|
|
Fixes: https://tracker.ceph.com/issues/69475
It turns out the sock-dir for ceph-exporter only needs to
exist within the container, not on the host. Previous code,
including the validation function this commit removes
and previous patches trying to fix the ceph-exporter asok
file not appearing on the host, were all done assuming
it mattered what was on the host. This patch changes things
so all we do with the sock dir is mount it to /var/run/ceph/<fsid>
and don't worry about whether that dir exists on the host.
Additionally, the patch makes it so /var/run/ceph/<fsid> is
created during ceph-exporter deployment.
Signed-off-by: Adam King <adking@redhat.com>
|
|
Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
|
|
`beast::ssl_stream` is deprecated as of 1.86, and its loss of the move
constructor keeps it from compiling on that version.
Hopefully this passes tests on 1.85, too, or it will have to wait
until the boost bump.
Signed-off-by: Adam Emerson <aemerson@redhat.com>
|
|
Modifying the default value of osd_scrub_load_threshold from 0.5
to 10.0, rendering it mostly irrelevant.
That is done following a combination of reasons:
- the new mclock scheduler, which provides a better mechanism to
control scrub load under all conditions;
- the inapplicability of the existing mechanism to Crimson; and
- users` requests.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
|
|
This adds Python type annotations to `api.lvm`, along with all
necessary adjustments to ensure compatibility and maintain code
clarity.
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
|
|
Ensures the stringstream is empty before sending a command in the RadosIO class
Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
|
|
In `struct bluefs_fnode_t` there is a vector `extents` and
the vector `extents_index` that is a log2 seek cache.
Until modifications to truncate() we never removed extents from files.
Modified truncate() did not update extents_index.
For example 10 extents long files when truncated to 0 will have:
0 extents, 10 extents_index.
After writing some data to file:
1 extents, 11 extents_index.
Now, `bluefs_fnode_t::seek` will binary search extents_index,
lets say it located seek at item #3.
It will then jump up from #0 extent (that exists) to #3 extent which
does not exist at.
The worst part is that code is now broken, as #3 != extent.end().
There are 3 parts of the fix:
1) assert in `bluefs_fnode_t::seek` to protect against
jumping outside extents
2) code in BlueFS::truncate to sync up `extents_index` with `extents`
3) dampening down assert in _replay to give a way out of cases
where incorrect "offset 12345" (12345 is file size) instead of
"offset 20000" (allocations occupied) was written to log.
Fixes: https://tracker.ceph.com/issues/69481
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
|
|
* when source bucket is deleted
* when logging is disabled
* when logging conf changes
* when target bucket is deleted
also add "bucket logging info" admin command
returning logging conf for source bucket, and list
of source buckets for log bucket
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
|
|
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
|
|
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
|
|
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
|
|
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
|
|
Thanks to the maintainers of the Arch User Repository Ceph PKGBUILD
for this fix.
Signed-off-by: Adam Emerson <aemerson@redhat.com>
|
|
https://tracker.ceph.com/issues/68552
Signed-off-by: Adam Emerson <aemerson@redhat.com>
|
|
Help from Pritha and Casey appreciated
Plus, fix 3 explicit mapping tests in test_rgw_iam_policy.cc.
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
|
|
This adds Python type annotations to `ceph_volume.util.device`,
along with all necessary adjustments to ensure compatibility
and maintain code clarity.
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
|
|
This commit adds:
1. workflow summary in the first section along with an image.
2. sub-section "Pushing to ceph-ci repository" to second section.
3. file doc/dev/developer_guide/testing_integration_tests/workflow.png
Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
|
|
Unittest showing 2 different flavours of problems:
1) bluefs log corruption
2) bluefs sigsegv
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
|
|
So that PhyscalNodeMapping doesn't contain LBAMapping specific
interfaces
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
|
|
02b70a62a4 moved the call to complete() into the finally block,
so we need to hold a reference to the pg until the complete()
resolves.
Signed-off-by: Samuel Just <sjust@redhat.com>
|
|
02b70a62a4 moved the call to handle.complete() into the finally,
but didn't extend the op ref lifetime until after the complete
resolved.
Signed-off-by: Samuel Just <sjust@redhat.com>
|
|
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
|
|
Remove "Quincy" from the list of "Active Releases" in
doc/releases/index.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
|
|
Converted string_view members to string to avoid use after free.
Bug introduced in commit: e84c7fc
Signed-off-by: Alex Wojno <awojno@bloomberg.net>
|
|
clarify the following error when migrating a user into an account:
> could not modify user: unable to modify user, UserName contains invalid characters
Fixes: https://tracker.ceph.com/issues/69470
Signed-off-by: Casey Bodley <cbodley@redhat.com>
|
|
Fixes: https://tracker.ceph.com/issues/69303
Signed-off-by: Adam Emerson <aemerson@redhat.com>
|
|
the admin api uses a separate dump_user_info() function that wasn't
updated with the account changes to RGWUserInfo::dump()
Fixes: https://tracker.ceph.com/issues/69462
Signed-off-by: Casey Bodley <cbodley@redhat.com>
|
|
Issue: mon/test_mon_osdmap_prune.sh is failing due to
PG_DEGRADED state.
Cause: We are writing an objects to a newly created PG before
it has enough OSDs in acting set to create enough replicas.
This is expected behaviour, thus the solution is to add the
warning to ignorelist.
Fixes: https://tracker.ceph.com/issues/69288
Signed-off-by: Shraddha Agrawal <shraddha.agrawal000@gmail.com>
|
|
Update these in config.libsonnet:
- NVMeoFMaxGatewaysPerGroup (4->8)
- NVMeoFMaxGatewaysPerCluster (4->32)
- NVMeoFMaxNamespaces (1024->2048)
- NVMeoFHighClientCount (32->128)
Also update prometheus_alerts.yml and test_alerts.yml
accordingly.
Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
|
|
Fixes: https://tracker.ceph.com/issues/69459
Signed-off-by: lightmelodies <lightmelodies@outlook.com>
|
|
Added more content and rewrite some sections
Signed-off-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
|
|
This commit updates RGW Config Reference - Lifecycle Settings section. In particular it addresses an incorrect suggestion to decrease parallel threads in the workers pool for a more aggressive/accelerated per-bucket lifecycle processing. A more aggressive lifecycle processing for a bucket containing higher number of objects is achieved by increasing, not decreasing parallel threads.
Current suggestion is miss-leading.
Fixes: https://tracker.ceph.com/issues/63659
Signed-off-by: Laimis Juzeliunas <laimis.juzeliunas@oxylabs.io>
|
