| Commit message (Collapse) | Author | Files | Lines |
|
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
|
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
|
Printed messages were messed up due to the erroneous comma.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
|
|
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
|
|
It was introduced in dca575992b34611d20f50c5db47e4b533cd7dc69.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
|
|
Add some unit tests to cover setup_device() in devices.lvm.prepare
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
|
|
The uuid set for tags['ceph.journal_uuid'] should point to its
corresponding lv_uuid instead of the uuid generated for the lv_name.
The variable name 'uuid' used so far was probably too confusing so let's
change it to make it more clear.
Closes: https://tracker.ceph.com/issues/48271
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
|
|
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
|
for better readability
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
|
easier to maintain the options of sphinx extensions in a single place.
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
|
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
|
this allows us to reuse this python script as a module.
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
|
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
|
This commit changes the crypto prepare_copyup implementation to correctly
translate object extents to image extents, via the remap_extents api.
Additionally, we fix relevant unit tests that call this api to correctly expect these calls.
Signed-off-by: Or Ozeri <oro@il.ibm.com>
|
|
Signed-off-by: Jianshen Liu <jliu120@ucsc.edu>
|
|
This commit implements the prepare_copyup api by the crypto object dispatch layer.
Signed-off-by: Or Ozeri <oro@il.ibm.com>
|
|
Signed-off-by: Neha Ojha <nojha@redhat.com>
|
|
Signed-off-by: Neha Ojha <nojha@redhat.com>
|
|
This commit removes an unwanted extra
nested list layer from a list.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
|
|
The cephadm package contains an architecture-independent Python script,
empty directories, and an empty authorized_keys file. There are no
architecture-dependent files here, so we can use a single noarch RPM
across all host architectures.
Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
|
|
This commit updates the text in the "How
Unit Tests Are Declared" section of
tests-unit-tests.rst. This commit breaks
long sentences into shorter sentences and
breaks a sentence into a bulleted list that
might reduce the reader's cognitive load.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
|
|
Ceph fails to parse config files that lack a trailing newline.
This mainly affects Windows, where text editors won't add one by
default.
This issue has been addressed by a previous commit [1] but that
code path is no longer reached [2][3], so we need to go down a level.
[1] 3b590314ac49b955b2123f03f4c4417e5534ec98
[2] http://paste.openstack.org/raw/800153/
[3] https://github.com/ceph/ceph/commit/e7dcc403b20922ffeeca114899f90a385bf25f0e
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
|
|
Yaml syntax cleaned too.
Fixes: https://github.com/ceph/ceph/pull/38107#issuecomment-729300615
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
|
|
Signed-off-by: Jan Fajerski <jfajerski@suse.com>
|
|
win_socketpair can fail with EADDRINUSE under load, which will
lead to an unhandled exception/crash as per this commit [1].
This change adds a retry, also ensuring that the right error code
gets propagated (the one returned by WSAGetLastError() instead of
the generic SOCKET_ERROR).
While at it, we're fixing the "win_socketpair" indentation and
addressing the SOCKET to int casts.
[1] https://github.com/ceph/ceph/commit/633805060a1002c86570fe50d099e0c1e223e2d7
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
|
|
"wnbd" will be the only supported device type on Windows, for now.
We'll update the "rbd" wrapper accordingly.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
|
|
This change will allow mapping rbd images on Windows, leveraging the
WNBD[1] Virtual Storport Miniport driver [2].
The behavior and CLI is similar to the Linux rbd-nbd, with a few
notable differences:
* device paths cannot be requested. The disk number and path will
be picked by Windows. If a device path is provided by the user
when mapping an image, it will be used as an identifier, which
can also be used when unmapping the image.
* the "show" command was added, which describes a specific mapping.
This can be used for retrieving the disk path.
* the "service" command was added, allowing rbd-wnbd to run as a
Windows service. All mappings are currently perisistent, being
recreated when the service stops, unless explicitly unmapped.
The service disconnects the mappings when being stopped.
* the "list" command also includes a "status" column.
The purpose of the "service" mode is to ensure that mappings survive
reboots and that the Windows service start order can be adjusted so
that rbd images can be mapped before starting services that may depend
on it, such as VMMS.
The mapped images can either be consumed by the host directly or exposed
to Hyper-V VMs.
While at it, we'll skip building rbd-mirror as it's quite unlikely that
this daemon is going to be used on Windows for now.
[1] https://github.com/cloudbase/wnbd
[2] https://docs.microsoft.com/en-us/windows-hardware/drivers/storage/overview-of-storage-virtual-miniport-drivers
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
|
|
At the moment, a few methods will be stubbed if
BOOST_ASIO_HAS_POSIX_STREAM_DESCRIPTOR is undefined.
The issue is that FileStream::get_size is undefined, so we're
getting link issues on Windows.
In the future, we might consider using asio::windows::stream_handle
on Windows.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
|
|
Passing "-fstack-protector-strong" doesn't seem to work with Mingw,
complaining about undefied "__stack_chk_fail". For this reason,
we'll disable it for now.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
|
|
This change updates the Windows readme, describing rbd-wnbd
configuration and usage.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
|
|
When importing an image, the rbd command uses only the file name
and expects "/" to be used as a separator. On Windows, it will
use the entire path as image name since the path separator is not
the same.
This change updates it so that the "\\" path separator can be
properly handled as well.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
|
|
We ended up with quite a few files having the "_win32" suffix.
It's probably better if we move them to a separate folder and drop
the suffix.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
|
|
silences warnings reported by clang iike:
btree_lba_manager.cc:439:50: warning: lambda capture 't' is not used [-Wunused-lambda-capture]
lba_node->get_node_meta().depth).safe_then([=, &t](LBANodeRef c) {
~~~^
1 warning generated.
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
|
silence "detached HEAD" warning like:
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:
git checkout -b <new-branch-name>
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
|
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
|
this method replaces `PG::get_or_load_clone_obc()`. so we can
with `seastar::with_lock()` to ensure that `lock.unlock()` is always
called when accessing clone obc.
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
|
as it is not used anymore.
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
|
for better readability, and ensure that `lock.unlock()` is called when
an error is returned after the lock is acquired.
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
|
this method replicates `PG::get_or_load_head_obc()`. but uses a different
way to ensure that the "lock" on obc is always released even if the
called func throws. it always guard the called func with a
`with_lock()`, so `lock.unlock()` is always called. the plan is to
replace `PG::get_or_load_head_obc()` with `PG::with_head_obc()` in
the following changes piecemeal.
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
|
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
|
this methods is used by PG::with_locked_obc(). so mark it private.
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
|
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
|
it's a leftover of 688b95798bfd88b409abce9b70bb6d2933819bef
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
|
We'll add a class that implements Windows service hooks. Subclasses
must overide the start, stop and shutdown hooks.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
|
|
We'll add some helpers facilitating Windows registry key operations.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
|
|
in cache.
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
|
|
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
|
|
split.
Haven't seen any real issues due to this though.
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
|
|
This commit updates the language at the beginning
of the Unit Test section of the developer guide.
The language in this edit is more grammatical than
it used to be, and should now reduce the reader's
cognitive load.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
|
|
This commit updates the "What does 'make
check' mean" section of the "Unit Tests" chapter
of the Developer Guide. It makes the wording a
bit less editorial and attempts to reduce the
reader's cognitive load.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
|