| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
| |
CID 1219611 (#1 - 5): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable saw_name going out of scope
leaks the storage it points to.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
|
|
|
|
|
|
| |
Implement modprobe() in terms of module_load() from common/module.h
Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
|
|
|
|
|
|
|
|
| |
Fedora's rpmlint complains that some of the source code files in the
tree happen to be executable. Remove the execute bits from these files
to resolve the rpmlint warning.
Signed-off-by: Ken Dreyer <ken.dreyer@inktank.com>
|
|
|
|
|
|
| |
/proc/mounts (e.g. Debian Wheezy), otherwise automounting a ceph file system fails. Also useful when /etc is read-only. feature 7006
Signed-off-by: Steve Stock <steve@technolope.org>
|
|
|
|
| |
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
|
|
|
|
| |
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
|
|
|
|
| |
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
|
|
|
|
|
|
| |
Fix includes: remove twice included string.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
|
|
|
|
|
|
| |
There were a few places where we didn't check malloc return code.
Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net>
|
|
|
|
|
|
|
| |
If a secret is specified, store and use it, but otherwise
check for a pre-existing secret to use.
Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
|
|
|
|
|
|
|
|
|
|
|
| |
These should have no functional changes:
* Check errors from functions that currently cannot return any
* Initialize variables that gcc can't determine will be initialized
in a following function call
* Remove unused variables
Signed-off-by: Josh Pieper <jjp@pobox.com>
Signed-off-by: Sage Weil <sage@newdream.net>
|
|
|
|
|
|
|
| |
The only remaining uses of strerror are in single-threaded programs
that don't depend on libcommon.
Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
|
|\ |
|
| |
| |
| |
| | |
Signed-off-by: Sage Weil <sage@newdream.net>
|
|/
|
|
|
|
| |
This is tolerant of colons in the mount subdir.
Signed-off-by: Sage Weil <sage@newdream.net>
|
|
|
|
|
|
|
|
| |
Make coverity shut up.
Coverity cid 44
Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
|
|
|
|
|
|
|
|
|
| |
canonicalize_path() does not free/touch it's argument; no need to strdup()
here.
Coverity cid 39
Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
|
|
|
|
|
|
|
|
| |
Use strdup here, mostly to make coverity shut up.
Coverity cid 45
Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
|
|
|
|
|
|
| |
Coverity cid 54
Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
|
|
|
|
|
|
| |
Coverity cid 55
Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
|
|
|
|
|
| |
Fixes: #1188
Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
|
|
|
|
| |
Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
|
|
|
|
|
|
| |
Use sprintf instead of safe_cat, since we're just writing a string once.
Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
|
|
|
|
|
|
|
| |
In that case we get ENOSYS. This also implies an old version of the client
and that we should fall back.
Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
|
|
|
|
| |
Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
|
|
|
|
|
|
|
| |
Backwards compatible with older kenrnels, for now.
Fixes: #852
Signed-off-by: Tommi Virtanen <tommi.virtanen@dreamhost.com>
|
|
|
|
|
|
|
|
| |
This will be needed for the next few commits, where we try to load the
keys into the kernel; without ceph.ko loaded, the key type will not be
recognized.
Signed-off-by: Tommi Virtanen <tommi.virtanen@dreamhost.com>
|
|
|
|
|
| |
Fixes: #914
Signed-off-by: Tommi Virtanen <tommi.virtanen@dreamhost.com>
|
|
|
|
| |
Signed-off-by: Tommi Virtanen <tommi.virtanen@dreamhost.com>
|
|\
| |
| |
| |
| |
| | |
Conflicts:
src/common/signal.cc
src/os/FileStore.cc
|
| |
| |
| |
| |
| |
| |
| |
| | |
Passing -o secretfile would cause a segfault since searching for = would
result in a null pointer. New version checks for that case. Also, *end
cannot be a ,.
Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
|
|/
|
|
|
|
| |
To squash a gcc warning.
Signed-off-by: Colin McCabe <colin.mccabe@dreamhost.com>
|
|
|
|
| |
Signed-off-by: Colin McCabe <colinm@hq.newdream.net>
|
|
|
|
| |
Signed-off-by: Colin McCabe <colinm@hq.newdream.net>
|
|
|
|
| |
Signed-off-by: Colin McCabe <colinm@hq.newdream.net>
|
|
|
|
| |
Signed-off-by: Colin McCabe <colinm@hq.newdream.net>
|
|
|
|
|
|
|
|
|
|
| |
* Functions that are local to the file are now static
* Don't modify the string argument to mount_resolve_src / parse_options
* Don't segfault when mount_resolve_src / parse_options return NULL
Signed-off-by: Colin McCabe <colinm@hq.newdream.net>
|
|
|
|
| |
Signed-off-by: Sage Weil <sage@newdream.net>
|
|
|
|
|
| |
We use value pointer outside of this block; move declaration up to function
level.
|
|
|
|
| |
Signed-off-by: Sage Weil <sage@newdream.net>
|
|
|
|
| |
Signed-off-by: Sage Weil <sage@newdream.net>
|
|
|
|
|
|
| |
noatime, nodiratime, relatime. Some cleanup.
Signed-off-by: Sage Weil <sage@newdream.net>
|
| |
|
| |
|
| |
|
|
|
|
| |
Also pass buffer size to relevant functions when required.
|
| |
|
| |
|
| |
|
| |
|