summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix project description rendering for org (#30587)wxiaoguang2024-04-211-2/+2
| | | | | | | | | Fix #30263 ![image](https://github.com/go-gitea/gitea/assets/2114189/41cabe6c-f94a-4874-a26f-d01bb89bb28c) Co-authored-by: Giteabot <teabot@gitea.io> (cherry picked from commit eb24d973b036e4dddf505d8c12e905ecb1a688f9)
* Avoid importing `modules/web/middleware` in `modules/session` (#30584)Jason Song2024-04-212-10/+18
| | | | | | | | | | | | | | Related to #30375. It doesn't make sense to import `modules/web/middleware` and `modules/setting` in `modules/web/session` since the last one is more low-level. And it looks like a workaround to call `DeleteLegacySiteCookie` in `RegenerateSession`, so maybe we could reverse the importing by registering hook functions. (cherry picked from commit 61457cdf6b49225ae831fd9fb084deadd8bdb0fb)
* Improve "Reference in new issue" modal (#30547)silverwind2024-04-212-18/+23
| | | | | | | | | | | Fixes: https://github.com/go-gitea/gitea/issues/29994 Also some misc enhancements done to the form in the modal. <img width="840" alt="Screenshot 2024-04-17 at 23 02 55" src="https://github.com/go-gitea/gitea/assets/115237/e71fba55-55cd-4e48-a497-6b1025c36a43"> (cherry picked from commit dd8e6ae270b4b5e91a152a145978029dacb938ff)
* Add a few root files to lint-spell (#30530)silverwind2024-04-211-2/+2
| | | | | | | | | | | | | | Files in root were not linted, add them. No new violations. (cherry picked from commit 354705450a410329d253023d2c66ef6d68ecc046) Conflicts: - CHANGELOG.md Gitea specific, removed. - Makefile Adjusted SPELLCHECK_FILES: we don't need to filter the CHANGELOG.md out. The conflict itself was resolved by manually applying the change.
* Fixup app.example.ini for task section, which is now queue.task (#30555)Jerry Jacobs2024-04-211-16/+0
| | | | | | | | | | | | | | Config section `[task]` has been deprecated in favor of `[queue.task]` --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> (cherry picked from commit 86d4c8a4662e9ab49888569d77529d2d22292e6b) Conflicts: - docs/content/administration/config-cheat-sheet.en-us.md - docs/content/administration/config-cheat-sheet.zh-cn.md Removed, they're Gitea specific.
* Fix border-radius on view, blame and code search (#30545)silverwind2024-04-214-5/+5
| | | | | | | | | | | | | | | | | | | | | | Fixes: https://github.com/go-gitea/gitea/issues/30540 1. Fix all these boxes by adding `bottom attached` and removing a problematic CSS rule: <img width="1319" alt="Screenshot 2024-04-17 at 22 25 31" src="https://github.com/go-gitea/gitea/assets/115237/346445a4-4944-4003-a1ef-6f5b0eda624e"> <img width="643" alt="Screenshot 2024-04-17 at 22 21 18" src="https://github.com/go-gitea/gitea/assets/115237/10f17ed3-9ad6-48de-92fa-bac6621815b9"> 2. Change the "last commit" box to `ui segment` which has correct border-radius. Also included is a tiny tweak to make author name ellipse instead of wrap. <img width="1331" alt="Screenshot 2024-04-17 at 22 23 23" src="https://github.com/go-gitea/gitea/assets/115237/285fbd45-ced0-4d33-abe3-7384ffa03188"> Co-authored-by: Giteabot <teabot@gitea.io> (cherry picked from commit 31538133c32009532897989ad623067bd224f924)
* Disable enter key for accepting code completion in Monaco (#30548)silverwind2024-04-211-0/+4
| | | | | | | | Fixes https://github.com/go-gitea/gitea/issues/28114 and behaviour matches vscode on desktop as well. Co-authored-by: Giteabot <teabot@gitea.io> (cherry picked from commit 49b80f8ac1cf9f0b56da0c73d0f34ef030f4c447)
* Fix branch_protection api shows users/teams who has no readAccess (#30291)Edward Zhang2024-04-212-25/+39
| | | | | | | | | | | | | | Add some logic in `convert.ToBranchProtection` to return only the names associated with readAccess instead of returning all names. This will ensure consistency in behavior between the frontend and backend. Fixes: #27694 --------- Co-authored-by: techknowlogick <techknowlogick@gitea.com> Co-authored-by: wenzhuo.zhang <wenzhuo.zhang@geely.com> Co-authored-by: Giteabot <teabot@gitea.io> (cherry picked from commit 02e183bf3fa502b7cef76e8dcdbf01b85ce641f0)
* Run `go generate` and `go vet` on all packages (#30529)silverwind2024-04-216-11/+9
| | | | | | | | | | | | | | | | | Fixes: https://github.com/go-gitea/gitea/issues/30512 I think this does mean those tools would run on a potential `vendor` directory, but I'm not sure we really support vendoring of dependencies anymore. `release` has a `vendor` prerequisite so likely the source tarballs contain vendor files? (cherry picked from commit 8e12ef911a1d10dedb03e3127c42ca76f9850aca) Conflicts: - Makefile Manually adjusted the changes.
* Fix and tweak pull request commit list (#30528)silverwind2024-04-212-27/+26
| | | | | | | | | | | | | Fixes https://github.com/go-gitea/gitea/issues/30493, regression from https://github.com/go-gitea/gitea/pull/30374. Also did the flexbox convertion as suggested by the existing comment. <img width="850" alt="Screenshot 2024-04-16 at 22 28 48" src="https://github.com/go-gitea/gitea/assets/115237/e8905944-620a-4211-b5c5-53ed3b3ee23e"> Co-authored-by: Giteabot <teabot@gitea.io> (cherry picked from commit 311f5261cdb23b46d3f510e40fd4e2ac06e376c0)
* Fix install page checkboxes and dropdown width (#30526)silverwind2024-04-211-1/+2
| | | | | | | | | | | | | Fixes: https://github.com/go-gitea/gitea/issues/30523 1. Fix checkbox rendering 2. Fix width of selection dropdowns (was too small) --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Giteabot <teabot@gitea.io> (cherry picked from commit 4f276a336355c4bf999034fb79f0fe5c967ceb50)
* Reduce unnecessary database queries on actions table (#30509)Lunny Xiao2024-04-211-0/+6
| | | | (cherry picked from commit 6f7d70fb3d2624507c3ccd5640f6d1837259c27d)
* Tweak and fix toggle checkboxes (#30527)silverwind2024-04-211-9/+10
| | | | | | | | | | | | Fixes: https://github.com/go-gitea/gitea/issues/30524. Slightly restyled them so that the "knob" is contained inside the background. <img width="179" alt="Screenshot 2024-04-16 at 21 58 09" src="https://github.com/go-gitea/gitea/assets/115237/be94517b-9cb7-46e2-ae96-fcf6767ce4ba"> <img width="187" alt="Screenshot 2024-04-16 at 21 58 50" src="https://github.com/go-gitea/gitea/assets/115237/c13a1959-5c5a-4e88-9225-e5f6fb72e3e0"> (cherry picked from commit 5ccd042f7080e1f4ef4b96591e1b1002a4826115)
* Update API to return 'source_id' for users (#29718)Tobias Balle-Petersen2024-04-213-0/+9
| | | | | | | | | | Using the API, a user's _source_id_ can be set in the _CreateUserOption_ model, but the field is not returned in the _User_ model. This PR updates the _User_ model to include the field _source_id_ (The ID of the Authentication Source). (cherry picked from commit 58b204b813cd3a97db904d889d552e64a7e398ff)
* Fix empty field `login_name` in API response JSON when creating user (#30511)yp053272024-04-211-3/+3
| | | | | | | Fix #30508 ps: if `sourceID` is not set, `LoginName` will be ignored (cherry picked from commit cf9061f44a439aa7775e301a7467dbda22a06eaa)
* feat(api): implement branch/commit comparison API (#30349)Bo-Yi Wu2024-04-218-14/+250
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Add new `Compare` struct to represent comparison between two commits - Introduce new API endpoint `/compare/*` to get commit comparison information - Create new file `repo_compare.go` with the `Compare` struct definition - Add new file `compare.go` in `routers/api/v1/repo` to handle comparison logic - Add new file `compare.go` in `routers/common` to define `CompareInfo` struct - Refactor `ParseCompareInfo` function to use `common.CompareInfo` struct - Update Swagger documentation to include the new API endpoint for commit comparison - Remove duplicate `CompareInfo` struct from `routers/web/repo/compare.go` - Adjust base path in Swagger template to be relative (`/api/v1`) GitHub API https://docs.github.com/en/rest/commits/commits?apiVersion=2022-11-28#compare-two-commits --------- Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> (cherry picked from commit c70e442ce4b99e2a1f1bf216afcfa1ad78d1925a) Conflicts: - routers/api/v1/swagger/repo.go Conflict resolved by manually adding the lines from the Gitea PR.
* Fix various overflows on actions view (#30344)silverwind2024-04-213-13/+43
| | | | | | | | | | | | | | | | | | Fix a number of text overflow issues in actions view and run list. Also improve mobile view of run list. Fixes: https://github.com/go-gitea/gitea/issues/30328 <img width="782" alt="Screenshot 2024-04-08 at 23 10 16" src="https://github.com/go-gitea/gitea/assets/115237/3d9f9f88-3eab-44a0-8144-30c2b58b24cb"> <img width="935" alt="Screenshot 2024-04-08 at 23 17 46" src="https://github.com/go-gitea/gitea/assets/115237/581d73ea-a31d-416b-be3a-47313b879b12"> <img width="1008" alt="Screenshot 2024-04-08 at 23 49 05" src="https://github.com/go-gitea/gitea/assets/115237/c5d10565-f285-477f-8659-1caf94797647"> <img width="397" alt="Screenshot 2024-04-08 at 23 55 30" src="https://github.com/go-gitea/gitea/assets/115237/368aaa75-1903-4058-9d75-d1fe91c564d6"> (cherry picked from commit b9f69b4a4d1d6b5b1f94852f6dfcae41b30658ff)
* Convert max file name length to 255 (#30489)yp053272024-04-212-2/+2
| | | | | | | | | | | | | | | | | | | Quick/Partly fix #29907 In Linux and MacOS, by default the max file name length is 255. In windows, it depends on the version and settings, and has no file name length limitation, but has path length limitation. By default it is 260, considering path length is longer than filename, so I think it is ok to do this. For Windows, see https://learn.microsoft.com/windows/win32/fileio/maximum-file-path-limitation?tabs=registry For Linux, see https://github.com/torvalds/linux/blob/master/include/uapi/linux/limits.h#L12-L13 For MacOS, see https://discussions.apple.com/thread/254788848?sortBy=best (cherry picked from commit 2c80421243ed1fd6f53c3e1a84c06648524f7c66)
* Fix overflow on issue dependency (#30484)silverwind2024-04-211-0/+6
| | | | | | | | | | | Small tweak here to prevent this and likely other events from overflowing in the timeline: <img width="895" alt="Screenshot 2024-04-14 at 22 53 17" src="https://github.com/go-gitea/gitea/assets/115237/001b4f6b-f649-44ff-b2f0-c8e0dedeb384"> Co-authored-by: Giteabot <teabot@gitea.io> (cherry picked from commit 1508a85f6235814271ea927d651bcbcd8c9f5f18)
* Kill all gitea processes before air build (#30477)silverwind2024-04-211-1/+2
| | | | | | | | | | | | | | | | | | So it happened to me multiple times that air leaves zombie processes after termination. I think ultimately it's some kind of bug in air, but we can work around. The change in the delay is unrelated to the zombie processes but seems to help a bit with duplicate changes resulting in duplicate `make generate` as seen here: <img width="424" alt="Screenshot 2024-04-14 at 17 05 47" src="https://github.com/go-gitea/gitea/assets/115237/6dd1d787-6be3-4fb2-8b0b-cd711c281793"> --------- Co-authored-by: delvh <dev.lh@web.de> (cherry picked from commit 994920c677b04a720726d982e4d6212664b82a43)
* [skip ci] Updated licenses and gitignoresGiteaBot2024-04-213-0/+47
| | | | (cherry picked from commit 708e87e17df2b6a03eca3cac026a51beed296b5b)
* Revert 100% label max-width (#30481)silverwind2024-04-212-2/+1
| | | | | | | | | | | | Partial revert of https://github.com/go-gitea/gitea/pull/30479 It's causing problems at least here: https://github.com/go-gitea/gitea/pull/30344#discussion_r1564895591 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> (cherry picked from commit ef3941f2ebe9d8353f9546e7df00b24092c71cb7)
* Improve flex ellipsis (#30479)wxiaoguang2024-04-213-0/+31
| | | | | | | | | | | | | | ![image](https://github.com/go-gitea/gitea/assets/2114189/857794d8-2170-42be-a5bf-47ebacbafebd) --------- Co-authored-by: silverwind <me@silverwind.io> (cherry picked from commit b84baf21fa19521e1ab303a60918c74f85fcad1c) Conflicts: - web_src/css/base.css Trivial commit resolved by removing the conflicting part. (it conflicted because we did not pick a previous PR)
* Improve "must-change-password" logic and document (#30472)wxiaoguang2024-04-213-24/+31
| | | | | | | | | | | | | Unify the behaviors of "user create" and "user change-password". Co-authored-by: KN4CK3R <admin@oldschoolhack.me> (cherry picked from commit 4c6e2da088cf092a9790df5c84b7b338508fede7) Conflicts: - cmd/admin_user_create.go Resolved by favoring Gitea's version of the conflicting areas. - docs/content/administration/command-line.en-us.md Removed, Gitea specific.
* Use `flex-container` for dashboard layout (#30214)silverwind2024-04-213-9/+15
| | | | | | | | | | | | | | | | | | | | | Added new class `flex-container-sidebar` to cover the dashboard sidebar. Previously this was 37.5% with more padding. Now there is less empty space between the two columns and this matches other pages like repo or admin settings page. Desktop: <img width="1345" alt="Screenshot 2024-03-31 at 15 11 36" src="https://github.com/go-gitea/gitea/assets/115237/717389d9-d42c-466e-a8fe-e968f79447fd"> Mobile: <img width="444" alt="Screenshot 2024-03-31 at 15 11 44" src="https://github.com/go-gitea/gitea/assets/115237/7faa840b-513a-411b-bf2d-26d52b9b71a0"> --------- Co-authored-by: Giteabot <teabot@gitea.io> (cherry picked from commit 044cc169e75dccbf1d846f8774ef2feccd0da1fd)
* Pulse page improvements (#30149)silverwind2024-04-216-16/+33
| | | | | | | | | | | | | 1. add border-radius and spacing to bars 2. use tailwind background classes 3. Add more space around activity list headers <img width="983" alt="Screenshot 2024-03-27 at 23 40 54" src="https://github.com/go-gitea/gitea/assets/115237/70f72c30-e69f-4ecb-882f-32b8bc94d638"> <img width="1020" alt="Screenshot 2024-03-27 at 23 41 02" src="https://github.com/go-gitea/gitea/assets/115237/a35dbbda-515c-40b0-938a-d759f9686b8e"> (cherry picked from commit 6999a88fd9bef6baa0a8cc5f63e419079611fc9b)
* Merge pull request 'cleanup(tests): remove manual testing submodule' (#3347) ↵Earl Warren2024-04-212-3/+0
|\ | | | | | | | | | | | | from earl-warren/forgejo:wip-manual-testing into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3347 Reviewed-by: 0ko <0ko@noreply.codeberg.org>
| * cleanup(tests): remove manual testing submoduleEarl Warren2024-04-212-3/+0
|/ | | | It is not effective, a different approach is needed
* Merge pull request 'Fix some edge cases with permalink rendering' (#3286) ↵Earl Warren2024-04-203-105/+348
|\ | | | | | | | | | | | | | | from Mai-Lapyst/forgejo:fix-permalink-rendering-edgecases into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3286 Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org> Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
| * Fix panic where now a third link breaks everythingMai-Lapyst2024-04-192-2/+84
| |
| * Fix issue where rendering stops after the first invalid parmalinkMai-Lapyst2024-04-193-26/+75
| |
| * Fix some edge cases; closes #3232Mai-Lapyst2024-04-173-80/+192
| | | | | | | | | | | | - Fixes wrong usage of AppURL - Fixes wrong rendering with extra path segments when AppSubURL is empty - Now also renders all links when 2+ permalinks are present
* | Merge pull request 'hooks: Harden when we accept push options that change ↵Earl Warren2024-04-202-0/+153
|\ \ | | | | | | | | | | | | | | | | | | | | | repo settings' (#3314) from earl-warren/forgejo:wip-push-options into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3314 Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org> Reviewed-by: Gergely Nagy <algernon@noreply.codeberg.org>
| * | hooks: Harden when we accept push options that change repo settingsGergely Nagy2024-04-192-0/+153
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is possible to change some repo settings (its visibility, and template status) via `git push` options: `-o repo.private=true`, `-o repo.template=true`. Previously, there weren't sufficient permission checks on these, and anyone who could `git push` to a repository - including via an AGit workflow! - was able to change either of these settings. To guard against this, the pre-receive hook will now check if either of these options are present, and if so, will perform additional permission checks to ensure that these can only be set by a repository owner or an administrator. Additionally, changing these settings is disabled for forks, even for the fork's owner. There's still a case where the owner of a repository can change the visibility of it, and it will not propagate to forks (it propagates to forks when changing the visibility via the API), but that's an inconsistency, not a security issue. Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu> Signed-off-by: Earl Warren <contact@earl-warren.org>
* | | Merge pull request 'Various improvements to pages: notifications and ↵0ko2024-04-205-35/+53
|\ \ \ | |/ / |/| | | | | | | | | | | | | | subscriptions' (#3175) from 0ko/forgejo:meet-your-subscribtions into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3175 Reviewed-by: Otto <otto@codeberg.org>
| * | Various improvements to pages: notifications and subscriptions0ko2024-04-165-35/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | - fix rounding on /notifications/subscriptions - add navigation interconnectivity between notifications and subscriptions - use modern style for tabs - clearing notificatons: hide the whole form instead of div. It doesn't seem like its changed via JS? - replace issue-title-buttons and edit-buttons with universal top-right-buttons, get rid of tw-mr-0 helpers - repo issues: fix misalignments on mobile view
* | | Merge pull request 'Remove EasyMDE from various areas' (#2916) from ↵0ko2024-04-194-1/+31
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | 0ko/forgejo:easymde into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2916 Reviewed-by: Gusted <gusted@noreply.codeberg.org>
| * | | Add integration test for EasyMDE button0ko2024-04-151-0/+25
| | | |
| * | | Remove EasyMDE from various areas0ko2024-04-156-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ref https://codeberg.org/forgejo/forgejo/issues/2831 Removed from: - form for creating comment - form for updating comment - popup reviewing form - line reviewing form - I did not check the use of textarea.tmpl but I belive its used for issue templates, so also removed - I did not check the use of box.tmpl, could not get any comments on compare EasyMDE is left for these pages: - release notes editor - wiki editor
| * | | Make display of EasyMDE in UI optional to template0ko2024-04-159-1/+12
| | | | | | | | | | | | | | | | This commit adds EasyMDE field to combomarkdowneditor, as well as to all its calls.
* | | | Merge pull request 'fix(tests): 30s to cancel processes to avoid false ↵Earl Warren2024-04-191-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | negatives' (#3317) from earl-warren/forgejo:wip-cancel-test into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3317 Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org> Reviewed-by: Otto <otto@codeberg.org>
| * | | | fix(tests): 30s to cancel processes to avoid false negativesEarl Warren2024-04-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | on slower machines it can take more than 1 second to cancel leftover tasks
* | | | | Merge pull request '[RELEASE] v1.21.11-1 release notes' (#3330) from ↵Earl Warren2024-04-191-0/+16
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | earl-warren/forgejo:wip-release-notes-1.21 into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3330 Reviewed-by: twenty-panda <twenty-panda@noreply.codeberg.org>
| * | | | | [RELEASE] v1.21.11-1 release notesEarl Warren2024-04-191-0/+16
| | | | | |
* | | | | | Merge pull request 'Update citation-js monorepo to v0.7.11' (#3321) from ↵Earl Warren2024-04-192-15/+15
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | renovate/citation-js-monorepo into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3321 Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
| * | | | | Update citation-js monorepo to v0.7.11Renovate Bot2024-04-192-15/+15
| | | | | |
* | | | | | Merge pull request 'services: Use proper Message-IDs for release mails' ↵Gusted2024-04-193-2/+21
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#3309) from algernon/forgejo:are-we-dot-atom-text-yet into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3309 Reviewed-by: Otto <otto@codeberg.org> Reviewed-by: Gusted <gusted@noreply.codeberg.org>
| * | | | | services: Use proper Message-IDs for release mailsGergely Nagy2024-04-183-2/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When sending notification emails about a release, use a properly formatted, RFC-compliant message id, rather than the release's HTML URL wrapped in angle brackets (which would not be compliant). Fixes #3105. Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
* | | | | | Merge pull request 'v1.21.11-0 release notes' (#3287) from ↵Earl Warren2024-04-181-1/+33
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | crystal/forgejo:pr/releasenotes-1.21.11-0 into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3287 Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org> Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
| * | | | | | slight wording change and most serious fix firstEarl Warren2024-04-181-3/+3
| | | | | | |
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-20 08:43:28 +0100