summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* build: Update configure.ac to reflect new master versionfrr-8.1-devDonald Sharp2021-05-181-1/+1
| | | | | | That we are building towards. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* Merge pull request #8608 from Fredi-raspall/pr_isis_sr_anycastbase_8.0Renato Westphal2021-05-181-5/+4
|\ | | | | isisd: clear the N-flag in ext. reachability TLVs
| * isisd: simplify node Sid handlingFredi Raspall2021-05-181-4/+3
| | | | | | | | | | | | Centralize the n-flag-clear processing to a single point. Signed-off-by: Fredi Raspall <fredi@voltanet.io>
| * isisd: clear the N-flag in ext. reachability TLVsFredi Raspall2021-05-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | If the n-flag-clear option is set in the configuration of a prefix segment, clear the flag in the extended ip reachability TLVs. RFCs 7794 and 8667 are not too strict on the setting / clearing the N-flag in prefix SIDs. However, if there exists a cmd line option to clear it, it should be cleared in the TLVs announced, as other vendors do. Signed-off-by: Fredi Raspall <fredi@voltanet.io>
* | Merge pull request #8133 from gpnaveen/ospf_basic_testcasesOlivier Dugeon2021-05-184-2/+244
|\ \ | | | | | | tests: adding ospf basic 2 testcases.
| * | tests: adding ospf basic 2 testcases.nguggarigoud2021-05-184-2/+244
| | | | | | | | | | | | | | | | | | Test cases included are 1 ospf cost, 1 ospf mtu. Signed-off-by: nguggarigoud <nguggarigoud@vmware.com>
* | | Merge pull request #8673 from LabNConsulting/chopps/ly2-againDonald Sharp2021-05-188-65/+88
|\ \ \ | | | | | | | | lib: libyang2 add missed conversion
| * | | lib: libyang2 add missed conversionChristian Hopps2021-05-188-65/+88
| | | | | | | | | | | | | | | | Signed-off-by: Christian Hopps <chopps@labn.net>
* | | | Merge pull request #8646 from chiragshah6/mdevPatrick Ruddy2021-05-181-2/+5
|\ \ \ \ | |_|_|/ |/| | | zebra: evpn check vni oper state in svi up/down event
| * | | zebra: check vni oper state in svi up notifChirag Shah2021-05-081-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When clagd is stopped on secondary device, all vxlan interfaces (vnis) are kept in protodown state. FRR treats protodown vxlan interfaces (vnis) as interface down and sends vni delete to bgpd. In the event of clagd down, SVIs are flapping as underlying bridge is going through churn. When FRR receives SVI up notification do not trigger event to bgpd if vnis are operationaly down. Ticket:#2600210 CM-22929 Reviewed By:CCR-11544 Testing Done: Performed CLAG stop/start on secondary device, all vxlan devices remained in protodown along with this validated the vnis are cleaned up and added back in bgpd. Signed-off-by: Chirag Shah <chirag@nvidia.com>
* | | | Merge pull request #8535 from opensourcerouting/zlog-rnodeDonatas Abraitis2021-05-181-27/+42
|\ \ \ \ | |_|_|/ |/| | | zebra: replace _rnode_zlog with %pZN ext
| * | | zebra: replace _rnode_zlog with %pZN extDavid Lamparter2021-05-021-27/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since _rnode_zlog was wrapping zlog(), these messages weren't getting an unique ID assigned through the xref mechanism. Replace macro with a small extension that prints (almost) the same thing. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* | | | Merge pull request #8680 from idryzhov/rip-ripng-fix-crashRenato Westphal2021-05-182-0/+6
|\ \ \ \ | |_|_|/ |/| | | ripd, ripngd: fix interface wakeup after shutdown
| * | | ripngd: fix interface wakeup after shutdownIgor Ryzhov2021-05-171-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | RIPNG schedules a call to `ripng_interface_wakeup` in 1 second after receiving the interface UP event from zebra. The function is called even if the interface was shut down during this interval. This is incorrect and also leads to a crash in the following scenario: ``` vtysh -c "conf" -c "router ripng vrf red" -c "network enp2s0" ip link add red type vrf table 1 ip link set enp2s0 vrf red ip link set enp2s0 down ip link set enp2s0 up && sleep 2 && ip link del red ``` Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
| * | | ripd: fix interface wakeup after shutdownIgor Ryzhov2021-05-171-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | RIP schedules a call to `rip_interface_wakeup` in 1 second after receiving the interface UP event from zebra. The function is called even if the interface was shut down during this interval. This is incorrect and also leads to a crash in the following scenario: ``` vtysh -c "conf" -c "router rip vrf red" -c "network enp2s0" ip link add red type vrf table 1 ip link set enp2s0 vrf red ip link set enp2s0 down ip link set enp2s0 up && ip link del red ``` Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
* | | | Merge pull request #8643 from icosahedral/masterSri Mohana Singamsetty2021-05-171-4/+8
|\ \ \ \ | | | | | | | | | | bgpd: modify path selection for EVPN type-5 routes
| * | | | bgpd: scope evpn specific path selection to type-2 routesNeal Shrader2021-05-101-4/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For EVPN routes, there is specific logic in place for path selection surrounding MAC Mobility. For pure type-5 routes, if a route is advertised with a MED, this is ignored since it ultimately falls inside of the EVPN specific path selection logic, and ultimately selects the lower IP address. This change ensures only type-2 routes fall into the EVPN BGP path selection. Signed-off-by: Neal Shrader <neal@digitalocean.com>
* | | | | Merge pull request #8676 from idryzhov/test-gitignoreMark Stapp2021-05-171-0/+1
|\ \ \ \ \ | | | | | | | | | | | | tests: fix missing gitignore entry
| * | | | | tests: fix missing gitignore entryIgor Ryzhov2021-05-171-0/+1
| | |/ / / | |/| | | | | | | | | | | | | Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
* | | | | Merge pull request #8672 from qlyoung/fix-bgp-timer-displayIgor Ryzhov2021-05-151-1/+1
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | bgpd: fix display of timers when only 1 is changedQuentin Young2021-05-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When only one of the keepalive or hold timers is changed from the default, bgp won't print the timers command in the config. Signed-off-by: Quentin Young <qlyoung@nvidia.com>
* | | | | Merge pull request #8556 from donaldsharp/bgp_pbr_weirdRuss White2021-05-143-54/+38
|\ \ \ \ \ | | | | | | | | | | | | Bgp flowspec cleanups
| * | | | | tests: Add pytestmark to the flowspec topotestDonald Sharp2021-05-121-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | | | bgpd: Remove usage of prefix2str and use builtin in bgp_zebra.cDonald Sharp2021-05-121-11/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Convert over from prefix2str explicit call and use the builtin %pFX we have now. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | | | bgpd: reduce cut-n-paste of bgp_zebra_announce_default for installDonald Sharp2021-05-121-11/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This bit of code was cut-n-pasted all over the place: if (!bpa->installed && !bpa->install_in_progress) { bgp_send_pbr_rule_action(bpa, NULL, true); bgp_zebra_announce_default(bgp, nh, bpa->afi, bpa->table_id, true); } Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | | | bgpd: reduce cut-n-paste code in bgp_pbr.cDonald Sharp2021-05-121-32/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Create a function bgp_bpr_bpa_remove that is this cut-n-paste code: if (bpa->refcnt == 0) { if (bpa->installed && bpa->table_id != 0) { bgp_send_pbr_rule_action(bpa, NULL, false); bgp_zebra_announce_default(bpa->bgp, &(bpa->nh), AFI_IP, bpa->table_id, false); bpa->installed = false; } } Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | | | | | Merge pull request #8144 from LabNConsulting/chopps/ly2Martin Winter2021-05-1471-1267/+1226
|\ \ \ \ \ \ | | | | | | | | | | | | | | libyang2
| * | | | | | lib: adapt to version 2 of libyangChristian Hopps2021-05-1371-1267/+1226
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Compile with v2.0.0 tag of `libyang2` branch of: https://github.com/CESNET/libyang staticd init load time of 10k routes now 6s vs ly1 time of 150s Signed-off-by: Christian Hopps <chopps@labn.net>
* | | | | | | Merge pull request #8658 from gromit1811/bugfix_8567Martin Winter2021-05-131-8/+10
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix #8567 OSPFv3-26.13 ANVL failure
| * | | | | | | ospf6d: Send MAXAGE LS update for received old self-originated LSAsMartin Buck2021-05-111-8/+10
| | |_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes OSPFv3-26.13 ANVL RFC conformance bug #8576 by improving the bugfix for #7030 from 4c63a76a. That commit changed handling of received old non-MAXAGE LSAs with a MAXAGE counterpart in the LSDB from "add all LSAs to LSDB and flood non-self-originated ones" to "add & flood only non-self-originated LSAs and ignore self-originated LSAs". The new behaviour is similar but adds sending a MAXAGE LS Update for received self-originated LSAs to remove the old LSAs from the network, resulting in "add & flood non-self-originated LSAs, don't add but send MAXAGE LS Update for self-originated LSAs". The missing MAXAGE LS Update is what OSPFv3-26.13 ANVL complained about. Signed-off-by: Martin Buck <mb-tmp-tvguho.pbz@gromit.dyndns.org>
* | | | | | | Merge pull request #8649 from ton31337/fix/unify-naming-for-topotests-directoryDonald Sharp2021-05-132086-8/+11
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | tests: Rename tests/topotests directories to be consistent
| * | | | | | | tests: Skip example_topojson_test and example_test from being testedDonatas Abraitis2021-05-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
| * | | | | | | tools: Ignore mass renaming of topotests for git blameDonatas Abraitis2021-05-111-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
| * | | | | | | tests: Unify directory naming for topotestsDonatas Abraitis2021-05-112082-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change every `-` to `_` in directory names. This is to avoid mixing _ and -. Just for consistency and directory sorting properly. Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
| * | | | | | | tools: Fix topotest directory for TravisDonatas Abraitis2021-05-111-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ospf1-topo1 => ospf1_topo1 Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
| * | | | | | | doc: Require topotests directory to be consistent with othersDonatas Abraitis2021-05-111-5/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Just add a requirement to avoid hyphens in directory naming. Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
* | | | | | | | Merge pull request #8659 from mjstapp/fix_connected_multiDonald Sharp2021-05-132-5/+26
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | lib,zebra: Use a flag to track down status for connected addrs
| * | | | | | | | lib,zebra: Use a flag to track down status for connected addrsMark Stapp2021-05-122-5/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Track 'down' state of connected addresses with a new flag. We may have multiple addresses on an interface that share a prefix; in those cases, we need to determine when the first address is valid, to install a connected route, and similarly detect when the last address goes 'down', to remove the connected route. Signed-off-by: Mark Stapp <mjs@voltanet.io>
* | | | | | | | | Merge pull request #8663 from donaldsharp/pretty_functionDonatas Abraitis2021-05-1312-59/+46
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Use __func__ instead of __PRETTY_FUNCTION__
| * | | | | | | | | pimd: Use __func__ instead of __PRETTY_FUNCTION__Donald Sharp2021-05-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | | | | | | | ospfd: Use _func__ instead of __PRETTY_FUNCTION__Donald Sharp2021-05-126-43/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | | | | | | | zebra: Use __func__ instead of __PRETTY_FUNCTION__Donald Sharp2021-05-123-10/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | | | | | | | bgpd: use __func__ instead of __PRETTY_FUNCTION__Donald Sharp2021-05-122-5/+5
| | |_|_|_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | | | | | | | | Merge pull request #8544 from donaldsharp/weird_stuff_in_topoMark Stapp2021-05-121-15/+15
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | tests: Fix pylint issues in test_bgp_recursive_route_ebgp_multi_hop.py
| * | | | | | | | tests: Fix pylint issues in test_bgp_recursive_route_ebgp_multi_hop.pyDonald Sharp2021-05-121-15/+15
| | |_|_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Tests had format for strings with 2 variables but 1 place to put the data. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | | | | | | | Merge pull request #8661 from donaldsharp/more_privsMark Stapp2021-05-122-0/+5
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | lib: Add ZCAP_IPC_LOCK
| * | | | | | | lib: Add ZCAP_IPC_LOCKDonald Sharp2021-05-122-0/+5
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We'll need ZCAP_IPC_LOCK for future work coming down the pike related to dataplane work being done. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | | | | | | Merge pull request #8660 from ↵Donatas Abraitis2021-05-121-1/+1
|\ \ \ \ \ \ \ | |_|_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | qlyoung/fix-bgp-conditional-advertisement-deconfig-removing-unrelated-filters bgpd: fix deconfig of conditional advertisement
| * | | | | | bgpd: fix deconfig of conditional advertisementQuentin Young2021-05-111-1/+1
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Deconfiguring conditional advertisement resulted in all other policy settings on the peer getting removed due to an excessively large memset. This also created a desync with the northbound config tree, which caused its own set of problems... Fix the memset to just remove the conditional advertisement config. Signed-off-by: Quentin Young <qlyoung@nvidia.com>
* | | | | | Merge pull request #8629 from donaldsharp/parse_rtattrIgor Ryzhov2021-05-123-32/+16
|\ \ \ \ \ \ | | | | | | | | | | | | | | Parse rtattr