summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* build: FRR 8.5 development versionfrr-8.5-devDonatas Abraitis2022-10-041-1/+1
| | | | Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
* Merge pull request #12058 from donaldsharp/fabricd_excessive_debugsbase_8.4Donatas Abraitis2022-10-041-5/+9
|\ | | | | fabricd: Turn off excessive logging when peering will not come up
| * fabricd: Turn off excessive logging when peering will not come upDonald Sharp2022-10-041-5/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When fabricd is configured to use an interface and there will be no peers out that interface, the log file is filling up with: Oct 04 10:50:03 host2 fabricd[1444769]: [HHXDJ-1DA93] ISIS-Adj (1): Threeway state change Initializing to Up Oct 04 10:50:03 host2 fabricd[1444769]: [R18GA-MS9R7] OpenFabric: Started initial synchronization with 1111.1111.1111 on enp1s0f1np1 Oct 04 10:50:06 host2 fabricd[1444769]: [HHXDJ-1DA93] ISIS-Adj (1): Threeway state change Up to Initializing Oct 04 10:50:07 host2 fabricd[1444769]: [NT6J7-1RYRF] OpenFabric: Initial synchronization on enp1s0f1np1 timed out! Oct 04 10:50:07 host2 fabricd[1444769]: [R18GA-MS9R7] OpenFabric: Started initial synchronization with 3333.3333.3333 on enp1s0f0np0 Oct 04 10:50:08 host2 fabricd[1444769]: [HHXDJ-1DA93] ISIS-Adj (1): Threeway state change Up to Initializing Oct 04 10:50:11 host2 fabricd[1444769]: [NT6J7-1RYRF] OpenFabric: Initial synchronization on enp1s0f0np0 timed out! Oct 04 10:50:11 host2 fabricd[1444769]: [HHXDJ-1DA93] ISIS-Adj (1): Threeway state change Initializing to Up Oct 04 10:50:11 host2 fabricd[1444769]: [R18GA-MS9R7] OpenFabric: Started initial synchronization with 1111.1111.1111 on enp1s0f1np1 Oct 04 10:50:14 host2 fabricd[1444769]: [HHXDJ-1DA93] ISIS-Adj (1): Threeway state change Up to Initializing Oct 04 10:50:15 host2 fabricd[1444769]: [NT6J7-1RYRF] OpenFabric: Initial synchronization on enp1s0f1np1 timed out! Oct 04 10:50:16 host2 fabricd[1444769]: [R18GA-MS9R7] OpenFabric: Started initial synchronization with 1111.1111.1111 on enp1s0f1np1 Oct 04 10:50:18 host2 fabricd[1444769]: [HHXDJ-1DA93] ISIS-Adj (1): Threeway state change Initializing to Up The `Threeway state change..` message is guarded by a debug, but the other 2 are not. Let's guard those with debugs since the log will be filled up rather quickly with any sort of aggressive timers. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | Merge pull request #12061 from mruprich/show-bgp-graceful-restart-typoDonatas Abraitis2022-10-041-1/+1
|\ \ | | | | | | bgpd: show ip bgp neighbors graceful-restart typo
| * | bgpd: show ip bgp neighbors graceful-restart typoMichal Ruprich2022-10-041-1/+1
|/ / | | | | | | | | | | | | Noticed a typo in the definition of show_ip_bgp_neighbors_graceful_restart function. Signed-off-by: Michal Ruprich <mruprich@redhat.com>
* | Merge pull request #12047 from donaldsharp/bgp_nexthop_individualRuss White2022-10-041-1/+1
|\ \ | |/ |/| bgpd: Fix `show bgp nexthop A.B.C.D`
| * bgpd: Fix `show bgp nexthop A.B.C.D`Donald Sharp2022-09-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The issuing of `show bgp nexthop A.B.C.D` fails even if that nexthop exists: eva# show bgp nexthop 192.168.119.120 specified nexthop does not have entry Fixed: eva# show bgp nexthop 192.168.119.120 192.168.119.120 valid [IGP metric 0], #paths 0, peer 192.168.119.120 if enp39s0 Last update: Fri Sep 30 14:55:13 2022 Paths: Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | Merge pull request #12043 from donaldsharp/bgp_hateDonatas Abraitis2022-10-011-13/+49
|\ \ | |/ |/| Bgp hate
| * bgpd: Ensure FRR has enough data to read 2 bytes in bgp_open_option_parseDonald Sharp2022-09-301-7/+28
| | | | | | | | | | | | | | | | | | | | | | In bgp_open_option_parse the code is checking that the stream has at least 2 bytes to read ( the opt_type and the opt_length). However if BGP_OPEN_EXT_OPT_PARAMS_CAPABLE(peer) is configured then FRR is reading 3 bytes. Which is not good since the packet could be badly formateed. Ensure that FRR has the appropriate data length to read the data. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * bgpd: Ensure FRR has enough data to read 2 bytes in peek_for_as4_capabilityDonald Sharp2022-09-301-6/+21
|/ | | | | | | | | | | In peek_for_as4_capability the code is checking that the stream has at least 2 bytes to read ( the opt_type and the opt_length ). However if BGP_OPEN_EXT_OPT_PARAMS_CAPABLE(peer) is configured then FRR is reading 3 bytes. Which is not good since the packet could be badly formated. Ensure that FRR has the appropriate data length to read the data. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* Merge pull request #12035 from donaldsharp/pim6_write_non_integratedDonatas Abraitis2022-09-292-5/+2
|\ | | | | pimd: Allow v6 to do non-integrated configuration
| * pimd: Remove some unused defines in pimd.hDonald Sharp2022-09-281-2/+0
| | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * pimd: Assign a vty port value for v6Donald Sharp2022-09-282-1/+2
| | | | | | | | | | | | Let's use 2620 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * pimd: Allow v6 to do non-integrated configurationDonald Sharp2022-09-271-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Proof: eva# conf eva(config)# no service integrated-vtysh-config eva(config)# end eva# wr mem Note: this version of vtysh never writes vtysh.conf Building Configuration... Configuration saved to /etc/frr/zebra.conf Configuration saved to /etc/frr/ripd.conf Configuration saved to /etc/frr/ripngd.conf Configuration saved to /etc/frr/ospfd.conf Configuration saved to /etc/frr/ospf6d.conf Configuration saved to /etc/frr/bgpd.conf Configuration saved to /etc/frr/isisd.conf Configuration saved to /etc/frr/pimd.conf Configuration saved to /etc/frr/nhrpd.conf Configuration saved to /etc/frr/eigrpd.conf Configuration saved to /etc/frr/babeld.conf Configuration saved to /etc/frr/sharpd.conf Configuration saved to /etc/frr/fabricd.conf Configuration saved to /etc/frr/pbrd.conf Configuration saved to /etc/frr/staticd.conf Configuration saved to /etc/frr/bfdd.conf Configuration saved to /etc/frr/vrrpd.conf Configuration saved to /etc/frr/pim6d.conf eva# Fixes: #12011 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | Merge pull request #12036 from ↵Donald Sharp2022-09-281-0/+2
|\ \ | | | | | | | | | | | | opensourcerouting/fix/show_single_allow-reserved-ranges vtysh: Show allow-reserved-ranges once in config
| * | vtysh: Show allow-reserved-ranges once in configDonatas Abraitis2022-09-271-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before: ``` donatas-pc# sh run | include allow-reserved-ranges allow-reserved-ranges allow-reserved-ranges allow-reserved-ranges allow-reserved-ranges allow-reserved-ranges allow-reserved-ranges donatas-pc# ``` Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
* | | Merge pull request #12028 from mobash-rasool/igmp-querierDonald Sharp2022-09-271-3/+10
|\ \ \ | |/ / |/| | pimd: IGMP Querier election is not correct in LAN scenario
| * | pimd: IGMP Querier election is not correct in LAN scenarioMobashshera Rasool2022-09-271-3/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When more than 2 routers are present in LAN and the querier goes down, the other routers will wait for other querier present timer to expire to elect a new querier. This issue will be seen when the router having next lower ip address expires the other querier present timer first and it starts sending the query message. Now on the other non-querier routers it will receive this query and reset its other querier present timer but the querier is still the old one and since it is lowest ip, it never gets updated to the newly elected querier. Reset the other querier timer only if query is received from the previously elected querier or a better new querier This will make sure that non-querier elects the new querier whose ip address is higher than the old querier when the old querier goes down via other querier querier timer expiry Issue: #12027 Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
* | | Merge pull request #11990 from spk-hebbar/patch-1Donald Sharp2022-09-271-1/+1
|\ \ \ | | | | | | | | Update setup.rst
| * | | doc: Update setup.rstSpoorthi K2022-09-271-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Spoorthi K <spk@redhat.com>
* | | | Merge pull request #12018 from pguibert6WIND/pathd_warning_notedDonald Sharp2022-09-271-1/+1
|\ \ \ \ | | | | | | | | | | pathd: change the vty output, when no ted is enabled on pathd
| * | | | pathd: change the vty output, when no ted is enabled on pathdPhilippe Guibert2022-09-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change the vty output, in case ted is not enabled. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
* | | | | Merge pull request #12029 from donaldsharp/cputime_statsDonatas Abraitis2022-09-271-1/+7
|\ \ \ \ \ | | | | | | | | | | | | Cputime stats
| * | | | | vtysh: Properly handle `service cputime-warning XX` in configDonald Sharp2022-09-271-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prevent duplicate lines from each daemon in vtysh output. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | | | vtysh: Properly handle `[no] service cputime-stats` in configDonald Sharp2022-09-271-1/+5
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Prevent duplicate lines from each daemon in vtysh output. Fixes: #12022 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | | | | Merge pull request #11985 from opensourcerouting/fix/thread_off_llgrRuss White2022-09-271-1/+3
|\ \ \ \ \ | | | | | | | | | | | | bgpd: Stop LLGR thread when deleting a peer and/or GR flags changed
| * | | | | bgpd: Stop LLGR thread when deleting a peer and/or GR flags changedDonatas Abraitis2022-09-211-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also valid when shutting down a BGP instance. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
* | | | | | Merge pull request #12006 from opensourcerouting/fix/doc_for_rfc9072Russ White2022-09-271-0/+9
|\ \ \ \ \ \ | | | | | | | | | | | | | | doc: Add `neighbor PEER extended-optional-parameters` command
| * | | | | | doc: Add `neighbor PEER extended-optional-parameters` commandDonatas Abraitis2022-09-251-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
* | | | | | | Merge pull request #12010 from opensourcerouting/fix/logging_for_route_refreshRuss White2022-09-271-5/+4
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | bgpd: Print hostname for peer as well when marking as stale for route-refresh
| * | | | | | | bgpd: Print hostname for peer as well when marking as stale for route-refreshDonatas Abraitis2022-09-261-5/+4
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before: ``` 2022/09/26 10:13:35.261 BGP: [QCZ1W-VKS36] 192.168.0.1(r0) sending REFRESH_REQ for afi/safi: IPv4/unicast 2022/09/26 10:13:35.262 BGP: [VF3QY-FP1PP] 192.168.0.1: route-refresh for IPv4/unicast, marking prefix 172.16.1.1/32 as stale 2022/09/26 10:13:35.262 BGP: [VF3QY-FP1PP] 192.168.0.1: route-refresh for IPv4/unicast, marking prefix 192.168.0.0/24 as stale 2022/09/26 10:13:35.262 BGP: [SDZS7-XVC4W] 192.168.0.1(r0) rcvd route-refresh (BoRR) for IPv4/unicast, triggering timer for 360 seconds 2022/09/26 10:13:35.362 BGP: [Y6XKR-PF89P] 192.168.0.1(r0) rcvd route-refresh (EoRR) for IPv4/unicast, stopping BoRR timer ``` Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
* | | | | | | Merge pull request #12016 from opensourcerouting/fix/route_map_show_jsonRuss White2022-09-271-1/+0
|\ \ \ \ \ \ \ | |_|_|_|_|/ / |/| | | | | | lib: Fix `show route-map NAME json` command and memory leak
| * | | | | | lib: Fix `show route-map NAME json` command and memory leakDonatas Abraitis2022-09-261-1/+0
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | JSON object was generated, but not printed, because the function returned immediatelly, even without freeing the memory. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
* | | | | | Merge pull request #11989 from maduri111/bgpd-cond-adv-peer-unsetDonatas Abraitis2022-09-272-36/+111
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | bgpd: conditional advertise-map unset on peer not re-advertising with…
| * | | | | bgpd: conditional advertise-map unset on peer fixing warning messagesMadhuri Kuruganti2022-09-251-4/+11
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Madhuri Kuruganti <maduri111@gmail.com>
| * | | | | bgpd: conditional advertise-map unset on peer not re-advertising withdrawn ↵Madhuri Kuruganti2022-09-252-37/+105
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | routes Signed-off-by: Madhuri Kuruganti <maduri111@gmail.com>
* | | | | | Merge pull request #11910 from fdumontet6WIND/NAI_AdjOlivier Dugeon2022-09-271-8/+8
|\ \ \ \ \ \ | | | | | | | | | | | | | | pathd: nai adjacency fix query type f for IPV6
| * | | | | | pathd: nai adjacency fix query type f for IPV6Francois Dumontet2022-09-061-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit is dedicated to fix some issues in path_ted_query_type_f function. Issues are related to IPv6 implementation. -key is not based on the pertinent part of IPv6 address. -test on memcmp return value is mismatch. -wrong flag value tested (ipv4 against ipv6). -return adj_sid was the wrong one. Signed-off-by: Francois Dumontet <francois.dumontet@6wind.com>
* | | | | | | Merge pull request #12009 from AbhishekNR/json_last-member-query-countDonatas Abraitis2022-09-271-0/+2
|\ \ \ \ \ \ \ | |_|_|_|_|/ / |/| | | | | | pim6d: Adding last member query count field in "show ipv6 mld interface [ifname] json" command.
| * | | | | | pim6d: Adding last member query count field in "show ipv6 mld interface ↵Abhishek N R2022-09-261-0/+2
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ifname] json" command. Fixes: #12004 Signed-off-by: Abhishek N R <abnr@vmware.com>
* | | | | | Merge pull request #12002 from ↵Donald Sharp2022-09-261-19/+54
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | opensourcerouting/fix/add_doc_missing_bgp_implemented_rf doc: Update supported BGP RFC list
| * | | | | | doc: Update supported BGP RFC listDonatas Abraitis2022-09-251-19/+54
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added such RFCs (missing): https://datatracker.ietf.org/doc/html/rfc2385 https://datatracker.ietf.org/doc/html/rfc2918 https://datatracker.ietf.org/doc/html/rfc4360 https://datatracker.ietf.org/doc/html/rfc4456 https://datatracker.ietf.org/doc/html/rfc4724 https://datatracker.ietf.org/doc/html/rfc4760 https://datatracker.ietf.org/doc/html/rfc5065 https://datatracker.ietf.org/doc/html/rfc5291 https://datatracker.ietf.org/doc/html/rfc5292 https://datatracker.ietf.org/doc/html/rfc6472 https://datatracker.ietf.org/doc/html/rfc5492 https://datatracker.ietf.org/doc/html/rfc7911 https://datatracker.ietf.org/doc/html/rfc6996 https://datatracker.ietf.org/doc/html/rfc6938 https://datatracker.ietf.org/doc/html/rfc8093 https://datatracker.ietf.org/doc/html/rfc7947 https://datatracker.ietf.org/doc/html/rfc9012 https://datatracker.ietf.org/doc/html/rfc8669 https://datatracker.ietf.org/doc/html/rfc8050 Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
* | | | | | Merge pull request #12000 from ↵Donald Sharp2022-09-261-45/+0
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | opensourcerouting/fix/remove_deprecated_ospf_command ospfd: Remove deprecated command `graceful-restart helper-only`
| * | | | | | ospfd: Remove deprecated command `graceful-restart helper-only`Donatas Abraitis2022-09-231-45/+0
| |/ / / / / | | | | | | | | | | | | | | | | | | Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
* | | | | | Merge pull request #12003 from anlancs/fix/fpm-crashDonald Sharp2022-09-263-0/+33
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | zebra: fix fpm crash
| * | | | | zebra: fix fpm crashanlan_cs2022-09-253-0/+33
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix issue#11996. When removing VRF ( all routes of this VRF), zebra mistakenly forgot to check whether its routes are in update queue of FPM. So FPM module will crash during its dealing with these routes, which are already freed. Add a new HOOK `rib_shutdown()`, `zebra_rtable_node_cleanup()` will use it to remove these routes from update queue of FPM module before freeing them. Signed-off-by: anlan_cs <vic.lan@pica8.com>
* | | | | Merge pull request #12001 from donaldsharp/use_integratedDonatas Abraitis2022-09-251-5/+1
|\ \ \ \ \ | |/ / / / |/| | | | doc: Align docs to recommend integrated config
| * | | | doc: Align docs to recommend integrated configDonald Sharp2022-09-231-5/+1
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Docs were recommending both integrated and non-integrated config in different sections. Remove the recommendation for non-integrated config from vtysh.rst. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | | | Merge pull request #11982 from samanvithab/bgp_mem_fixDonatas Abraitis2022-09-235-4/+36
|\ \ \ \ | | | | | | | | | | bgpd: multiple memory leak issue fixes
| * | | | bgpd: Cleanup memory leaks associated with t_deferral_timerSamanvitha B Bhargav2022-09-233-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are allocating temporary memory for information about what to process in this thread, which is not being cleaned up on thread cancelling. Signed-off-by: Samanvitha B Bhargav <bsmanvitha@vmware.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-19 15:02:36 +0100