summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* pbrd: remove json optionsQuentin Young2018-06-121-10/+6
| | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* pbrd: allow configurable table id rangeQuentin Young2018-06-122-2/+30
| | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* vtysh: fix config writeQuentin Young2018-06-121-0/+3
| | | | | | | Changing vtysh to use vty_out() for everything broke writing to config files. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* Merge pull request #2402 from ↵Jafar Al-Gharaibeh2018-06-127-26/+23
|\ | | | | | | | | qlyoung/germx-hand-sanitizer-kills-99-percent-of-germs *: disable all sanitizers for clippy build
| * *: disable all sanitizers for clippy buildQuentin Young2018-06-087-26/+23
| | | | | | | | | | | | | | | | | | | | | | * Move configure flag propagations out of user flags * Use AC_SUBST to transfer flag values to Automake * Set default AM_CFLAGS and AM_CPPFLAGS in common.am and change child Makefiles to modify these base variables * Add flag override to turn off all sanitizers when building clippy * Remove LSAN suppressions blacklist as it's no longer needed Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* | Merge pull request #2379 from qlyoung/docuserJafar Al-Gharaibeh2018-06-127-272/+255
|\ \ | | | | | | Improve introductory user docs
| * | doc: move find command docs to better spotQuentin Young2018-06-081-27/+27
| | | | | | | | | | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
| * | doc: remove :caption: from toctreeQuentin Young2018-06-081-6/+17
| | | | | | | | | | | | | | | | | | | | | Older versions of Sphinx don't support toctree captions, so we can't use them yet unfortunately. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
| * | doc: update EXTRA_DISTQuentin Young2018-06-081-2/+1
| | | | | | | | | | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
| * | doc: clean up introductory user docsQuentin Young2018-06-083-230/+190
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update the list of protocol daemons from 5 to the current 13 * Rewrap and clean up formatting for lots of miscellaneous code blocks * Improve English in various spots * Update architecture description and diagram * Remove duplicate information on reporting bugs Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
| * | doc: reorganize into multiple toctreesQuentin Young2018-06-084-14/+27
| | | | | | | | | | | | | | | | | | Use multiple toctrees to reorganize the user docs into logical sections. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* | | Merge pull request #2384 from qlyoung/docs-bgp-updateJafar Al-Gharaibeh2018-06-121-767/+737
|\ \ \ | | | | | | | | doc: massive cleanup of bgp.rst
| * | | doc: cleanup community list docs moreQuentin Young2018-06-081-92/+74
| | | | | | | | | | | | | | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
| * | | doc: massive cleanup of bgp.rstQuentin Young2018-06-081-675/+663
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This doc needed (and still needs) a lot of love. * Reorganize doc into logical sections * Clean up lots of grammatical mistakes and misspellings * Clean up lots of bad formatting * Remove non-existent configuration options and commands * Mark deprecated configuration options as deprecated * Fix all cross-references to follow a standard format * Fix capitalization on section and subsection titles * Fix section and subsection level underlines Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* | | | Merge pull request #2392 from chiragshah6/evpn_devLou Berger2018-06-121-1/+37
|\ \ \ \ | | | | | | | | | | bgpd: accept vni rd_rt command for default vrf only
| * | | | bgpd: accept vni rd_rt command for default vrfChirag Shah2018-06-101-1/+37
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | L2VNI route-distinguisher and route-target configuartions should only applied under DEFAULT VRF bgpd instance. Add newline to each vni display. router bgp 65006 address-family l2vpn evpn vni 1000101 route-target import 1:1000101 do not allow under router bgp 65006 vrf RED Ticket:CM-20204 Reviewed By: Testing Done: Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
* | | | Merge pull request #2399 from ↵Donald Sharp2018-06-121-2/+3
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | pacovn/Coverity_1469894_Dereference_null_return_value lib: null return value check (Coverity 1469894)
| * | | | lib: null return value check (Coverity 1469894)paco2018-06-121-2/+3
| | | | | | | | | | | | | | | | | | | | Signed-off-by: F. Aragon <paco@voltanet.io>
* | | | | Merge pull request #2404 from ↵Donald Sharp2018-06-121-0/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | pacovn/Coverity_1455338_Dereference_null_return_value eigrpd: null return value check (Coverity 1455338)
| * | | | | eigrpd: null return value check (Coverity 1455338)paco2018-06-121-0/+1
| |/ / / / | | | | | | | | | | | | | | | Signed-off-by: F. Aragon <paco@voltanet.io>
* | | | | Merge pull request #2406 from pacovn/Coverity_1465495_Out-of-bounds_readRafael Zalamena2018-06-121-1/+1
|\ \ \ \ \ | | | | | | | | | | | | zebra: Out-of-bounds read (Coverity 1465495)
| * | | | | zebra: Out-of-bounds read (Coverity 1465495)paco2018-06-121-1/+1
| |/ / / / | | | | | | | | | | | | | | | Signed-off-by: F. Aragon <paco@voltanet.io>
* | | | | Merge pull request #2405 from pacovn/Coverity_1399236_Logically_dead_codeDonald Sharp2018-06-121-3/+0
|\ \ \ \ \ | | | | | | | | | | | | ospfd: logically dead code (Coverity 1399236)
| * | | | | ospfd: logically dead code (Coverity 1399236)paco2018-06-121-3/+0
| |/ / / / | | | | | | | | | | | | | | | Signed-off-by: F. Aragon <paco@voltanet.io>
* | | | | Merge pull request #2397 from ↵Quentin Young2018-06-111-2/+4
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | pacovn/Coverity_1469896_Dereference_after_null_check vtysh: null dereference (Coverity 1469896)
| * | | | | vtysh: null dereference (Coverity 1469896)paco2018-06-111-2/+4
| |/ / / / | | | | | | | | | | | | | | | Signed-off-by: F. Aragon <paco@voltanet.io>
* | | | | Merge pull request #2398 from ↵Quentin Young2018-06-111-3/+5
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | pacovn/Coverity_1469895_Dereference_after_null_check lib: null dereference (Coverity 1469895)
| * | | | | lib: null dereference (Coverity 1469895)paco2018-06-111-3/+5
| |/ / / / | | | | | | | | | | | | | | | Signed-off-by: F. Aragon <paco@voltanet.io>
* | | | | Merge pull request #2396 from ↵Quentin Young2018-06-111-6/+6
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | pacovn/Coverity_1469897_1469893_Out-of-bounds_access bgpd: OoB access (Coverity 1469897, 1469893)
| * | | | bgpd: OoB access (Coverity 1469897, 1469893)paco2018-06-111-6/+6
| |/ / / | | | | | | | | | | | | Signed-off-by: F. Aragon <paco@voltanet.io>
* | | | Merge pull request #2390 from pacovn/Coverity_1221459_Use_after_freeDonald Sharp2018-06-081-2/+3
|\ \ \ \ | | | | | | | | | | spf6d: fix use after free (Coverity 1221459)
| * | | | spf6d: fix use after free (Coverity 1221459)paco2018-06-081-2/+3
| |/ / / | | | | | | | | | | | | Signed-off-by: F. Aragon <paco@voltanet.io>
* | | | Merge pull request #2389 from ↵Donald Sharp2018-06-081-1/+1
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | pacovn/Coverity_1455482_Incorrect_sizeof_expression lib: fix sizeof expression (Coverity 1455482)
| * | | lib: fix sizeof expression (Coverity 1455482)paco2018-06-081-1/+1
| |/ / | | | | | | | | | Signed-off-by: F. Aragon <paco@voltanet.io>
* | | Merge pull request #2388 from pacovn/Coverity_1453454_Resource_leakDonald Sharp2018-06-081-1/+1
|\ \ \ | | | | | | | | zebra: resource leak fix (Coverity 1453454)
| * | | zebra: resource leak fix (Coverity 1453454)paco2018-06-081-1/+1
| |/ / | | | | | | | | | Signed-off-by: F. Aragon <paco@voltanet.io>
* | | Merge pull request #2387 from pacovn/Coverity_1465679_Resource_leakDonald Sharp2018-06-081-5/+9
|\ \ \ | | | | | | | | zebra: resource leak fix (Coverity 1465679)
| * | | zebra: resource leak fix (Coverity 1465679)paco2018-06-081-5/+9
| |/ / | | | | | | | | | Signed-off-by: F. Aragon <paco@voltanet.io>
* | | Merge pull request #2386 from gromit1811/pim-connected-nexthop-fix2Donald Sharp2018-06-082-7/+15
|\ \ \ | |/ / |/| | pimd: Fix connected route nexthop fix from 66f5152f
| * | pimd: Fix connected route nexthop fix from 66f5152fMartin Buck2018-06-082-7/+15
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix a couple of problems in my 1st fix for PIM nexthops reachable via a connected route: Use NEXTHOP_TYPE_IPV4_IFINDEX instead of NEXTHOP_TYPE_IPV4 since we add an IPv4 address to an already known ifindex. Assign nexthop_tab[num_ifindex].protocol_distance and .route_metric before incrementing num_ifindex. Revert the default: to individual switch case statement conversion in zclient_read_nexthop() as requested by donaldsharp in #2347 Signed-off-by: Martin Buck <mb-tmp-tvguho.pbz@gromit.dyndns.org>
* | Merge pull request #2298 from qlyoung/pipe-actions-vtyshRuss White2018-06-0816-364/+963
|\ \ | | | | | | *: add support for `|` actions
| * | doc: add docs on | actions, find commandQuentin Young2018-06-061-2/+58
| | | | | | | | | | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
| * | lib: fix output mangling with | includeQuentin Young2018-06-063-28/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sometimes output would be mangled when filtering with include as a result of the following bugs: * Filters were applied per each call to vty_out() instead of buffering until a line break and then applying * Long output would sometimes be cut due to using the wrong buffer pointer Also remove the trailing \n as it should no longer be necessary to ensure the vty prompt ends up on a new line. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
| * | lib: initialize vty->ofQuentin Young2018-06-061-0/+2
| | | | | | | | | | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
| * | lib: add vector_compact(), use after str splitsQuentin Young2018-06-064-2/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Add function to move all data to the start of a vector by shifting over contiguous empty slots * Use this function to remove empty slots leftover after frrstr_filter_vec Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
| * | lib: fix static analysis issues, use regfree()Quentin Young2018-06-064-6/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix potential NULL dereference * Fix use of uninitialized value * Fix leaking memory by not freeing regex_t * Fix extra \n when using empty regex filter * Clean up still-reachable hook memory * Handle nonexistent pager Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
| * | lib: add vector_remove() to vector.[ch]Quentin Young2018-06-064-5/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | An optimized version of this has already been implemented within graph.c that assumes some specialized constraints for that code. It's generally useful so this change implements a general purpose version of it. This fixes cmd_make_strvec() that was broken by some code shuffling in previous commits. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
| * | *: style for | supportQuentin Young2018-06-065-8/+17
| | | | | | | | | | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
| * | vtysh: add | supportQuentin Young2018-06-068-278/+326
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Rewrite pager implementation * Replace fprintf() with vty_out() * Modify vty_out() for better vtysh support * Remove static global outputfile var * Remove fp argument from many vtysh functions * Add some docs for stuff along the way Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
| * | lib: add cli preprocessor for `|` actionsQuentin Young2018-06-064-15/+116
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds a CLI preprocessor function that activates when `|` is found in the command. This is the start of adding support for some text processing utilities intended for inline use. The first one implemented here is `| include`, which provides grep-like filtering of command output. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>