summaryrefslogtreecommitdiffstats
path: root/alpine (unfollow)
Commit message (Collapse)AuthorFilesLines
2022-10-04bgpd: show ip bgp neighbors graceful-restart typoMichal Ruprich1-1/+1
Noticed a typo in the definition of show_ip_bgp_neighbors_graceful_restart function. Signed-off-by: Michal Ruprich <mruprich@redhat.com>
2022-10-04fabricd: Turn off excessive logging when peering will not come upDonald Sharp1-5/+9
When fabricd is configured to use an interface and there will be no peers out that interface, the log file is filling up with: Oct 04 10:50:03 host2 fabricd[1444769]: [HHXDJ-1DA93] ISIS-Adj (1): Threeway state change Initializing to Up Oct 04 10:50:03 host2 fabricd[1444769]: [R18GA-MS9R7] OpenFabric: Started initial synchronization with 1111.1111.1111 on enp1s0f1np1 Oct 04 10:50:06 host2 fabricd[1444769]: [HHXDJ-1DA93] ISIS-Adj (1): Threeway state change Up to Initializing Oct 04 10:50:07 host2 fabricd[1444769]: [NT6J7-1RYRF] OpenFabric: Initial synchronization on enp1s0f1np1 timed out! Oct 04 10:50:07 host2 fabricd[1444769]: [R18GA-MS9R7] OpenFabric: Started initial synchronization with 3333.3333.3333 on enp1s0f0np0 Oct 04 10:50:08 host2 fabricd[1444769]: [HHXDJ-1DA93] ISIS-Adj (1): Threeway state change Up to Initializing Oct 04 10:50:11 host2 fabricd[1444769]: [NT6J7-1RYRF] OpenFabric: Initial synchronization on enp1s0f0np0 timed out! Oct 04 10:50:11 host2 fabricd[1444769]: [HHXDJ-1DA93] ISIS-Adj (1): Threeway state change Initializing to Up Oct 04 10:50:11 host2 fabricd[1444769]: [R18GA-MS9R7] OpenFabric: Started initial synchronization with 1111.1111.1111 on enp1s0f1np1 Oct 04 10:50:14 host2 fabricd[1444769]: [HHXDJ-1DA93] ISIS-Adj (1): Threeway state change Up to Initializing Oct 04 10:50:15 host2 fabricd[1444769]: [NT6J7-1RYRF] OpenFabric: Initial synchronization on enp1s0f1np1 timed out! Oct 04 10:50:16 host2 fabricd[1444769]: [R18GA-MS9R7] OpenFabric: Started initial synchronization with 1111.1111.1111 on enp1s0f1np1 Oct 04 10:50:18 host2 fabricd[1444769]: [HHXDJ-1DA93] ISIS-Adj (1): Threeway state change Initializing to Up The `Threeway state change..` message is guarded by a debug, but the other 2 are not. Let's guard those with debugs since the log will be filled up rather quickly with any sort of aggressive timers. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-09-30bgpd: Fix `show bgp nexthop A.B.C.D`Donald Sharp1-1/+1
The issuing of `show bgp nexthop A.B.C.D` fails even if that nexthop exists: eva# show bgp nexthop 192.168.119.120 specified nexthop does not have entry Fixed: eva# show bgp nexthop 192.168.119.120 192.168.119.120 valid [IGP metric 0], #paths 0, peer 192.168.119.120 if enp39s0 Last update: Fri Sep 30 14:55:13 2022 Paths: Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-09-30bgpd: Ensure FRR has enough data to read 2 bytes in bgp_open_option_parseDonald Sharp1-7/+28
In bgp_open_option_parse the code is checking that the stream has at least 2 bytes to read ( the opt_type and the opt_length). However if BGP_OPEN_EXT_OPT_PARAMS_CAPABLE(peer) is configured then FRR is reading 3 bytes. Which is not good since the packet could be badly formateed. Ensure that FRR has the appropriate data length to read the data. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-09-30bgpd: Ensure FRR has enough data to read 2 bytes in peek_for_as4_capabilityDonald Sharp1-6/+21
In peek_for_as4_capability the code is checking that the stream has at least 2 bytes to read ( the opt_type and the opt_length ). However if BGP_OPEN_EXT_OPT_PARAMS_CAPABLE(peer) is configured then FRR is reading 3 bytes. Which is not good since the packet could be badly formated. Ensure that FRR has the appropriate data length to read the data. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-09-28pimd: Remove some unused defines in pimd.hDonald Sharp1-2/+0
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-09-28pimd: Assign a vty port value for v6Donald Sharp2-1/+2
Let's use 2620 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-09-27vtysh: Show allow-reserved-ranges once in configDonatas Abraitis1-0/+2
Before: ``` donatas-pc# sh run | include allow-reserved-ranges allow-reserved-ranges allow-reserved-ranges allow-reserved-ranges allow-reserved-ranges allow-reserved-ranges allow-reserved-ranges donatas-pc# ``` Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-27pimd: Allow v6 to do non-integrated configurationDonald Sharp1-2/+0
Proof: eva# conf eva(config)# no service integrated-vtysh-config eva(config)# end eva# wr mem Note: this version of vtysh never writes vtysh.conf Building Configuration... Configuration saved to /etc/frr/zebra.conf Configuration saved to /etc/frr/ripd.conf Configuration saved to /etc/frr/ripngd.conf Configuration saved to /etc/frr/ospfd.conf Configuration saved to /etc/frr/ospf6d.conf Configuration saved to /etc/frr/bgpd.conf Configuration saved to /etc/frr/isisd.conf Configuration saved to /etc/frr/pimd.conf Configuration saved to /etc/frr/nhrpd.conf Configuration saved to /etc/frr/eigrpd.conf Configuration saved to /etc/frr/babeld.conf Configuration saved to /etc/frr/sharpd.conf Configuration saved to /etc/frr/fabricd.conf Configuration saved to /etc/frr/pbrd.conf Configuration saved to /etc/frr/staticd.conf Configuration saved to /etc/frr/bfdd.conf Configuration saved to /etc/frr/vrrpd.conf Configuration saved to /etc/frr/pim6d.conf eva# Fixes: #12011 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-09-27doc: Update setup.rstSpoorthi K1-1/+1
Signed-off-by: Spoorthi K <spk@redhat.com>
2022-09-27vtysh: Properly handle `service cputime-warning XX` in configDonald Sharp1-1/+3
Prevent duplicate lines from each daemon in vtysh output. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-09-27vtysh: Properly handle `[no] service cputime-stats` in configDonald Sharp1-1/+5
Prevent duplicate lines from each daemon in vtysh output. Fixes: #12022 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-09-27pimd: IGMP Querier election is not correct in LAN scenarioMobashshera Rasool1-3/+10
When more than 2 routers are present in LAN and the querier goes down, the other routers will wait for other querier present timer to expire to elect a new querier. This issue will be seen when the router having next lower ip address expires the other querier present timer first and it starts sending the query message. Now on the other non-querier routers it will receive this query and reset its other querier present timer but the querier is still the old one and since it is lowest ip, it never gets updated to the newly elected querier. Reset the other querier timer only if query is received from the previously elected querier or a better new querier This will make sure that non-querier elects the new querier whose ip address is higher than the old querier when the old querier goes down via other querier querier timer expiry Issue: #12027 Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2022-09-26pathd: change the vty output, when no ted is enabled on pathdPhilippe Guibert1-1/+1
Change the vty output, in case ted is not enabled. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2022-09-26lib: Fix `show route-map NAME json` command and memory leakDonatas Abraitis1-1/+0
JSON object was generated, but not printed, because the function returned immediatelly, even without freeing the memory. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-26bgpd: Print hostname for peer as well when marking as stale for route-refreshDonatas Abraitis1-5/+4
Before: ``` 2022/09/26 10:13:35.261 BGP: [QCZ1W-VKS36] 192.168.0.1(r0) sending REFRESH_REQ for afi/safi: IPv4/unicast 2022/09/26 10:13:35.262 BGP: [VF3QY-FP1PP] 192.168.0.1: route-refresh for IPv4/unicast, marking prefix 172.16.1.1/32 as stale 2022/09/26 10:13:35.262 BGP: [VF3QY-FP1PP] 192.168.0.1: route-refresh for IPv4/unicast, marking prefix 192.168.0.0/24 as stale 2022/09/26 10:13:35.262 BGP: [SDZS7-XVC4W] 192.168.0.1(r0) rcvd route-refresh (BoRR) for IPv4/unicast, triggering timer for 360 seconds 2022/09/26 10:13:35.362 BGP: [Y6XKR-PF89P] 192.168.0.1(r0) rcvd route-refresh (EoRR) for IPv4/unicast, stopping BoRR timer ``` Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-26pim6d: Adding last member query count field in "show ipv6 mld interface ↵Abhishek N R1-0/+2
[ifname] json" command. Fixes: #12004 Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-25doc: Add `neighbor PEER extended-optional-parameters` commandDonatas Abraitis1-0/+9
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-25doc: Update supported BGP RFC listDonatas Abraitis1-19/+54
Added such RFCs (missing): https://datatracker.ietf.org/doc/html/rfc2385 https://datatracker.ietf.org/doc/html/rfc2918 https://datatracker.ietf.org/doc/html/rfc4360 https://datatracker.ietf.org/doc/html/rfc4456 https://datatracker.ietf.org/doc/html/rfc4724 https://datatracker.ietf.org/doc/html/rfc4760 https://datatracker.ietf.org/doc/html/rfc5065 https://datatracker.ietf.org/doc/html/rfc5291 https://datatracker.ietf.org/doc/html/rfc5292 https://datatracker.ietf.org/doc/html/rfc6472 https://datatracker.ietf.org/doc/html/rfc5492 https://datatracker.ietf.org/doc/html/rfc7911 https://datatracker.ietf.org/doc/html/rfc6996 https://datatracker.ietf.org/doc/html/rfc6938 https://datatracker.ietf.org/doc/html/rfc8093 https://datatracker.ietf.org/doc/html/rfc7947 https://datatracker.ietf.org/doc/html/rfc9012 https://datatracker.ietf.org/doc/html/rfc8669 https://datatracker.ietf.org/doc/html/rfc8050 Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-25bgpd: conditional advertise-map unset on peer fixing warning messagesMadhuri Kuruganti1-4/+11
Signed-off-by: Madhuri Kuruganti <maduri111@gmail.com>
2022-09-25bgpd: conditional advertise-map unset on peer not re-advertising withdrawn ↵Madhuri Kuruganti2-37/+105
routes Signed-off-by: Madhuri Kuruganti <maduri111@gmail.com>
2022-09-25zebra: fix fpm crashanlan_cs3-0/+33
Fix issue#11996. When removing VRF ( all routes of this VRF), zebra mistakenly forgot to check whether its routes are in update queue of FPM. So FPM module will crash during its dealing with these routes, which are already freed. Add a new HOOK `rib_shutdown()`, `zebra_rtable_node_cleanup()` will use it to remove these routes from update queue of FPM module before freeing them. Signed-off-by: anlan_cs <vic.lan@pica8.com>
2022-09-23doc: Align docs to recommend integrated configDonald Sharp1-5/+1
Docs were recommending both integrated and non-integrated config in different sections. Remove the recommendation for non-integrated config from vtysh.rst. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-09-23ospfd: Remove deprecated command `graceful-restart helper-only`Donatas Abraitis1-45/+0
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-23bgpd: Cleanup memory leaks associated with t_deferral_timerSamanvitha B Bhargav3-0/+15
We are allocating temporary memory for information about what to process in this thread, which is not being cleaned up on thread cancelling. Signed-off-by: Samanvitha B Bhargav <bsmanvitha@vmware.com>
2022-09-23zebra: changes for code maintainabilitysri-mohan12-6/+4
these changes are for improving the code maintainability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
2022-09-22bgpd: Use %pRD for prefix_rd2str()Donatas Abraitis15-235/+111
Convert a bunch of prefix_rd2str() for json/vty stuff. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-22bgpd: Stop conditional advertisements thread when terminatingDonatas Abraitis1-0/+1
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-21bgpd: Drop out-of-date filesDonatas Abraitis2-245/+0
Just not maintained for > 18 years. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-21bgpd: Stop LLGR thread when deleting a peer and/or GR flags changedDonatas Abraitis1-1/+3
Also valid when shutting down a BGP instance. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-21bgpd: memory leak issue fixSamanvitha B Bhargav1-0/+11
Memory allocated when 'import vrf route maps <>' is configured, wasn't being freed when the entire bgp config was deleted through 'no router bgp'. Signed-off-by: Samanvitha B Bhargav <bsmanvitha@vmware.com>
2022-09-21bgpd: memory leak issue fixSamanvitha B Bhargav1-1/+1
In ecommunity_del_val(), ecommunity was not being freed when the last value in the ecommunity was being deleted. Signed-off-by: Samanvitha B Bhargav <bsmanvitha@vmware.com>
2022-09-21bgpd: memory leak issue fixSamanvitha B Bhargav1-3/+9
When router id is changed through config, new RD is auto generated. However new export RT was being assigned without freeing the older RT from VRF. Signed-off-by: Samanvitha B Bhargav <bsmanvitha@vmware.com>
2022-09-20docker: Keep and copy .apk files after they are builtDonatas Abraitis2-25/+13
For debugging purposes and/or to distribute them somewhere else. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-20isisd: Fix memory leak on shutdown with prefix listsDonald Sharp3-2/+7
==2623619== ==2623619== 6 bytes in 1 blocks are definitely lost in loss record 3 of 75 ==2623619== at 0x483877F: malloc (vg_replace_malloc.c:307) ==2623619== by 0x4B55E4A: strdup (strdup.c:42) ==2623619== by 0x493C992: qstrdup (memory.c:128) ==2623619== by 0x1A9212: isis_instance_fast_reroute_level_1_remote_lfa_prefix_list_modify (isis_nb_config.c:1599) ==2623619== by 0x494837C: nb_callback_modify (northbound.c:1083) ==2623619== by 0x4948C6E: nb_callback_configuration (northbound.c:1352) ==2623619== by 0x494919D: nb_transaction_process (northbound.c:1473) ==2623619== by 0x4947DA9: nb_candidate_commit_apply (northbound.c:906) ==2623619== by 0x4947EBA: nb_candidate_commit (northbound.c:938) ==2623619== by 0x494EB9E: nb_cli_classic_commit (northbound_cli.c:64) ==2623619== by 0x494F3DC: nb_cli_apply_changes_internal (northbound_cli.c:250) ==2623619== by 0x494F4E2: nb_cli_apply_changes (northbound_cli.c:268) ==2623619== by 0x1BEF0F: isis_frr_remote_lfa_plist_magic (isis_cli.c:1899) ==2623619== by 0x1B7636: isis_frr_remote_lfa_plist (isis_cli_clippy.c:3406) ==2623619== by 0x48EBA75: cmd_execute_command_real (command.c:997) ==2623619== by 0x48EBD4E: cmd_execute_command_strict (command.c:1108) ==2623619== by 0x48EC1E6: command_config_read_one_line (command.c:1268) ==2623619== by 0x48EC35B: config_from_file (command.c:1313) ==2623619== by 0x4999CC1: vty_read_file (vty.c:2347) ==2623619== by 0x499A4AF: vty_read_config (vty.c:2567) ==2623619== by 0x4924B12: frr_config_read_in (libfrr.c:984) ==2623619== by 0x498F5E3: thread_call (thread.c:2008) ==2623619== by 0x49253DA: frr_run (libfrr.c:1198) ==2623619== by 0x14FC53: main (isis_main.c:273) Fix this memory leak Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-09-20pathd: 'no mpls-te on' command was not workingPhilippe Guibert1-1/+1
Fix the 'no mpls-te on' command. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2022-09-20bgpd: Use route_map_result_t for route_map_apply() as return typeDonatas Abraitis2-1/+16
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-19pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim local-membership" ↵Abhishek N R1-14/+26
command output Before: frr# sh ipv6 pim local-membership Interface Address Source Group Membership ens224 fe80::250:56ff:feb7:9091 * ff08::1 NOINFO After: frr# sh ipv6 pim local-membership Interface Address Source Group Membership ens224 fe80::250:56ff:feb7:9091 * ff08::1 NOINFO Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-19pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim neighbor" command ↵Abhishek N R1-5/+19
output. Before: frr# show ipv6 pim neighbor Interface Neighbor Uptime Holdtime DR Pri ens192 fe80::250:56ff:feb7:38de 00:10:47 00:01:28 1 ens224 fe80::250:56ff:feb7:4bad 00:10:47 00:01:28 1 After: frr# sh ipv6 pim neighbor Interface Neighbor Uptime Holdtime DR Pri ens192 fe80::250:56ff:feb7:38de 00:00:12 00:01:32 1 ens224 fe80::250:56ff:feb7:4bad 00:00:12 00:01:32 1 Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-19pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim join" command outputAbhishek N R1-8/+24
Before: frr# sh ipv6 pim join Interface Address Source Group State Uptime Expire Prune ens224 fe80::250:56ff:feb7:9091 * ff08::1 JOIN 00:16:31 03:28 --:-- After: frr# show ipv6 pim join Interface Address Source Group State Uptime Expire Prune ens224 fe80::250:56ff:feb7:9091 * ff08::1 JOIN 00:00:51 03:27 --:-- Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-19pimd, pim6d: Changing IGMP to GM in few macro's.Abhishek N R4-25/+31
Changing IGMP_DEFAULT_ROBUSTNESS_VARIABLE to GM_DEFAULT_ROBUSTNESS_VARIABLE, IGMP_GENERAL_QUERY_INTERVAL to GM_GENERAL_QUERY_INTERVAL, IGMP_QUERY_MAX_RESPONSE_TIME_DSEC to GM_QUERY_MAX_RESPONSE_TIME_DSEC and IGMP_SPECIFIC_QUERY_MAX_RESPONSE_TIME_DSEC to GM_SPECIFIC_QUERY_MAX_RESPONSE_TIME_DSEC to accomodate both igmp and mld. And moved it to common file. Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-16bgpd: Don't forget bgp_dest_unlock_node before returnDonatas Abraitis1-0/+2
Before returning an error, unlock bgp dest which is locked by bgp_node_lookup()/bgp_node_get(). Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-16bgpd: Handle route-refresh request received before EoRXiao Liang2-0/+32
See the BGP message sequence: R1 R2 | updates | |------------------>| | | | refresh request | x<------------------| | | | updates cont. | |------------------>| | | | end-of-rib | |------------------>| | | When R1 and R2 establish BGP session, R1 begins to send initial updates. If R2 sends a route-refresh request before EoR, it's silently ignored by R1, and routes received earlier have no chance to be processed again. RFC7313 says, "for a BGP speaker that supports the BGP Graceful Restart, it MUST NOT send a BoRR for an <AFI, SAFI> to a neighbor before it sends the EoR for the <AFI, SAFI> to the neighbor." But it doesn't forbid route-refresh request to be sent before receiving EoR. To handle this scenario, postpone response to refresh request until EoR is sent. Signed-off-by: Xiao Liang <shaw.leon@gmail.com>
2022-09-16pim6d: Fixing coverity issues for pim6_mld.cMobashshera Rasool1-1/+1
CID 1519843 (#2 of 2): Uninitialized scalar variable (UNINIT) 43. uninit_use_in_call: Using uninitialized value pkt_src->sin6_addr when calling gm_rx_process Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2022-09-16bgpd: Free ecommunity before returning on warning/errorDonatas Abraitis1-0/+4
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-09-16pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim state" command ↵Abhishek N R1-60/+77
output. Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-16pim6d: (*,G) mroutes not learnt after pim6d daemon restartAbhishek N R1-1/+1
After restart pim dr address was zero due to which pim (*,G) join could not get propagated towards RP. While trying to find primary address ll_highest will be zero initially, since we have not received address from zebra yet. So we can get the best address at this point and use it as primary address whenever ll_highest is zero. Fixes: #11925 Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-16pim6d: fix clear ipv6 mroute crashSarita Patra1-48/+37
Root Cause: "clear ipv6 mroute" was not deleting the subscribers of gm_if structure. Fix: The command "clear ipv6 mroute" deletes grp_pends, gsq_pends, sgs, subscribers, expires of gm_if data structure. Deleted the common code in gm_ifp_teardown() and called gm_group_delete(). Issue: #11724 Signed-off-by: Sarita Patra <saritap@vmware.com>
2022-09-16include: clean up some white spacesanlan_cs1-6/+6
Found some extra spaces, clean up them with uniform format. Signed-off-by: anlan_cs <vic.lan@pica8.com>
2022-09-15zebra: changes for code maintainabilitysri-mohan13-6/+6
these changes are for improving the code maintainability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-19 15:31:49 +0100