summaryrefslogtreecommitdiffstats
path: root/bgpd (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #3015 from donaldsharp/no_fast_failover_and_vrfDavid Lamparter2018-09-181-11/+4
|\ | | | | bgpd: Using no bgp fast-external-failover prevents vrf intf moves
| * bgpd: Using no bgp fast-external-failover prevents vrf intf movesDonald Sharp2018-09-131-11/+4
| | | | | | | | | | | | | | | | When using `no bgp fast-external-failover` and a interface moves from one vrf into another we would not fully process the change. Fix this code path. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* | Merge branch 'pr/2986'David Lamparter2018-09-185-19/+53
|\ \ | | | | | | | | | | | | | | | | | | Conflicts: bgpd/bgp_network.c (BGP_ERR_* -> EC_BGP_*) Signed-off-by: David Lamparter <equinox@diac24.net>
| * | bgpd: Prevent possible crash when parsing v6 attributesDonald Sharp2018-09-125-19/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The peer->nexthop.ifp pointer must be set when parsing the attributes in bgp_mp_reach_parse, notice this and fail gracefully. Rework bgp_nexthop_set to remove the HAVE_CUMULUS and to fail the nexthop_set when we have a zebra connection and no ifp pointer, as that not havinga zebra connection and no ifp pointer is legal. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* | | Merge pull request #3040 from pacovn/static_analysis__drop_const_1Quentin Young2018-09-172-7/+7
|\ \ \ | | | | | | | | bgpd isisd ldpd lib: const drop fixes (SA)
| * | | bgpd isisd ldpd lib: const drop fixes (SA)F. Aragon2018-09-172-7/+7
| | |/ | |/| | | | | | | | | | | | | Can be detected with e.g. ./configure CFLAGS=-Wcast-qual CC=clang Signed-off-by: F. Aragon <paco@voltanet.io>
* | | Merge pull request #3031 from pacovn/static_analysis__WcommaLou Berger2018-09-171-2/+4
|\ \ \ | | | | | | | | bgpd isisd zebra: misuse of comma operator
| * | | bgpd isisd zebra: misuse of comma operatorF. Aragon2018-09-141-2/+4
| |/ / | | | | | | | | | | | | | | | Detected using ./configure CFLAGS=-Wcomma CC=clang Signed-off-by: F. Aragon <paco@voltanet.io>
* | | Merge pull request #3030 from pacovn/fp_type_fixes1David Lamparter2018-09-141-1/+1
|\ \ \ | | | | | | | | bgpd: type fix
| * | | bgpd: type fixF. Aragon2018-09-141-1/+1
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | For tracking the last state of the penalty (struct bgp_damp_info) a 'double' type was used instead of using the 'unsigned int' being used in the structure. Detected using ./configure CFLAGS=-Wfloat-equal CC=clang Signed-off-by: F. Aragon <paco@voltanet.io>
* | | Merge pull request #3023 from qlyoung/ultimate-warning-reference-cards-renameDavid Lamparter2018-09-1431-570/+565
|\ \ \ | | | | | | | | warning reference cards rename
| * | | *: style for EC replacementsQuentin Young2018-09-1323-215/+210
| | | | | | | | | | | | | | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
| * | | *: LIB_[ERR|WARN] -> EC_LIBQuentin Young2018-09-1311-45/+45
| | | | | | | | | | | | | | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
| * | | bgpd: BGP_[WARN|ERR] -> EC_BGPQuentin Young2018-09-1326-336/+336
| |/ / | | | | | | | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* / / bgpd lib ospf6d pbrd tests zebra: shadowing fixesF. Aragon2018-09-133-22/+22
|/ / | | | | | | | | | | This fixes all remaining local variable shadowing cases Signed-off-by: F. Aragon <paco@voltanet.io>
* | Merge pull request #3006 from pacovn/static_analysis__shadow_variables1Donald Sharp2018-09-138-28/+14
|\ \ | | | | | | bgpd isisd ospf6d ospfd: variable shadowing fixes
| * | bgpd isisd ospf6d ospfd: variable shadowing fixesF. Aragon2018-09-128-28/+14
| | | | | | | | | | | | Signed-off-by: F. Aragon <paco@voltanet.io>
* | | Merge remote-tracking branch 'frr/master' into warningsDavid Lamparter2018-09-1222-268/+306
|\| | | | | | | | | | | | | | | | | | | | | | | Conflicts: zebra/if_ioctl_solaris.c zebra/rtread_getmsg.c Signed-off-by: David Lamparter <equinox@diac24.net>
| * | bgpd: Honor origin change in bgp aggregatesDonald Sharp2018-09-101-2/+7
| |/ | | | | | | | | | | | | | | | | When the origin changed we must honor and update the aggregate to the peer. This code adds a bit of code to the bgp_aggregate_info_same code to see if the origin has changed and to indicate that it has. Fixes: #2993 Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
| * Merge pull request #2977 from opensourcerouting/doc-fixDonald Sharp2018-09-091-1/+1
| |\ | | | | | | build: fix not building docs w/o sphinx
| | * build: fix not building docs w/o sphinxDavid Lamparter2018-09-091-1/+1
| | | | | | | | | | | | | | | | | | Can't build manpages without sphinx-build, oops... Signed-off-by: David Lamparter <equinox@diac24.net>
| * | *: fix config.h/zebra.h include orderDavid Lamparter2018-09-0810-19/+9
| |/ | | | | | | | | | | | | | | config.h (or, transitively, zebra.h) must be the first include file listed for autoconf things like _GNU_SOURCE and _POSIX_C_SOURCE to work correctly. Signed-off-by: David Lamparter <equinox@diac24.net>
| * build: move RFPLDADD to bgpd/rfp-example/librfpDavid Lamparter2018-09-083-5/+4
| | | | | | | | | | | | | | This makes it slightly easier to replace the stub RFP code with an external implementation. Signed-off-by: David Lamparter <equinox@diac24.net>
| * vtysh: make RPKI node non-conditionalDavid Lamparter2018-09-081-2/+0
| | | | | | | | | | | | | | | | | | | | Whether or not RPKI is enabled during build shouldn't really influence vtysh; the user can always manually install bgpd_rpki.so later and it should work. This also means that the behaviour of "RPKI module not loaded" is consistent regardless of whether it was a compile-time or runtime decision. Signed-off-by: David Lamparter <equinox@diac24.net>
| * *: cleanup .gitignore filesDavid Lamparter2018-09-081-15/+0
| | | | | | | | Signed-off-by: David Lamparter <equinox@diac24.net>
| * build: move vtysh & manpage listings to subdir.amDavid Lamparter2018-09-082-0/+30
| | | | | | | | | | | | | | Since we're now building through one large Makefile, we can easily put things with their daemons and crossreference nicely. Signed-off-by: David Lamparter <equinox@diac24.net>
| * build: non-recursive bgpd & rfpDavid Lamparter2018-09-0810-233/+264
| | | | | | | | | | | | | | | | Note: no more --with-rfp-path on configure - badly messing with the build system like this really isn't how to do a conditional external dependency. Signed-off-by: David Lamparter <equinox@diac24.net>
* | bgpd: remove duplicate log_ref_add()Quentin Young2018-09-061-1/+0
| | | | | | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* | *: style for flog_warn conversionsQuentin Young2018-09-065-46/+60
| | | | | | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* | bgpd: Update bgp_updgrp_packet.c to use flog_warnDonald Sharp2018-09-063-6/+13
| | | | | | | | Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* | bgpd: Convert bgp_open.c to use flog_warnDonald Sharp2018-09-063-11/+50
| | | | | | | | Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* | bgpd: convert bgp_nht.c to use flog_warnDonald Sharp2018-09-063-1/+9
| | | | | | | | Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* | bgpd: Modify bgp_label to use flog_warnDonald Sharp2018-09-063-2/+10
| | | | | | | | Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* | bgpd: Convert bgp_evpn.c to use flow_warnDonald Sharp2018-09-063-9/+33
| | | | | | | | Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* | bgpd: Convert bgp_network.c to use flog_warnDonald Sharp2018-09-063-2/+18
| | | | | | | | Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* | bgpd: Convert zlog_warn to flog_warn for bgp_packet.cDonald Sharp2018-09-063-11/+31
| | | | | | | | Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* | bgpd: Convert bgp_dump.c to use flog_warnDonald Sharp2018-09-063-2/+10
| | | | | | | | Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* | bgpd: Convert zlog_warn to flog_warn for bgp_aspath.c and bgp_attr.cDonald Sharp2018-09-064-28/+117
|/ | | | Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* Merge pull request #2873 from vivek-cumulus/evpn-extended-mobilityRuss White2018-09-063-138/+108
|\ | | | | EVPN extended mobility support
| * Merge remote-tracking branch 'upstream/master' into evpn-extended-mobilityvivek2018-08-2814-201/+432
| |\ | | | | | | | | | | | | Conflicts: zebra/zebra_vxlan.c
| * | bgpd, zebra: Fix warningsvivek2018-08-211-2/+3
| | | | | | | | | | | | Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
| * | bgpd, zebra: EVPN extended mobility supportvivek2018-08-203-138/+107
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement procedures similar to what is specified in https://tools.ietf.org/html/draft-malhotra-bess-evpn-irb-extended-mobility in order to support extended mobility scenarios in EVPN. These are scenarios where a host/VM move results in a different (MAC,IP) binding from earlier. For example, a host with an address assignment (IP1, MAC1) moves behind a different PE (VTEP) and has an address assignment of (IP1, MAC2) or a host with an address assignment (IP5, MAC5) has a different assignment of (IP6, MAC5) after the move. Note that while these are described as "move" scenarios, they also cover the situation when a VM is shut down and a new VM is spun up at a different location that reuses the IP address or MAC address of the earlier instance, but not both. Yet another scenario is a MAC change for an attached host/VM i.e., when the MAC of an attached host changes from MAC1 to MAC2. This is necessary because there may already be a non-zero sequence number associated with MAC2. Also, even though (IP, MAC1) is withdrawn before (IP, MAC2) is advertised, they may propagate through the network differently. The procedures continue to rely on the MAC mobility extended community specified in RFC 7432 and already supported by the implementation, but augment it with a inheritance mechanism that understands the relationship of the host MACIP (ARP/neighbor table entry) to the underlying MAC (MAC forwarding database entry). In FRR, this relationship is understood by the zebra component which doubles as the "host mobility manager", so the MAC mobility sequence numbers are determined through interaction between bgpd and zebra. Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com> Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com> Reviewed-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
* | | Merge pull request #2970 from dslicenc/more-bool-use-jsonRuss White2018-09-053-22/+16
|\ \ \ | | | | | | | | bgpd, ospfd, pimd, zebra: Convert more use_json locations to bool
| * | | bgpd, ospfd, pimd, zebra: Convert more use_json locations to boolDon Slice2018-09-043-22/+16
| | | | | | | | | | | | | | | | Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
* | | | Merge pull request #2934 from ↵David Lamparter2018-09-042-8/+79
|\ \ \ \ | |/ / / |/| | | | | | | | | | | LabNConsulting/working/master/rfapi_topotest_support add some testing support for use in rfapi topotest
| * | | rfp_example: add 'rfp full-table-download' config to support topotestLou Berger2018-08-291-0/+33
| | | | | | | | | | | | | | | | Signed-off-by: Lou Berger <lberger@labn.net>
| * | | rfapi: debug related changes to support topotest -- add costLou Berger2018-08-291-2/+10
| | | | | | | | | | | | | | | | Signed-off-by: Lou Berger <lberger@labn.net>
| * | | rfp_example: add rfp holddown-factor to support topotestLou Berger2018-08-291-1/+26
| | | | | | | | | | | | | | | | Signed-off-by: Lou Berger <lberger@labn.net>
| * | | rfapi: debug related changes to support topotestLou Berger2018-08-281-5/+10
| | |/ | |/| | | | | | | Signed-off-by: Lou Berger <lberger@labn.net>
* | | Merge pull request #2945 from dslicenc/bgp-ospf-jsonDavid Lamparter2018-09-0117-141/+179
|\ \ \ | | | | | | | | bgpd/ospfd: make bgp and ospf json response a bit more consistent
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-19 09:12:57 +0100