summaryrefslogtreecommitdiffstats
path: root/isisd/isis_redist.h (unfollow)
Commit message (Collapse)AuthorFilesLines
2021-10-06ospf6d: remove unnecessary check when translating Type-7 LSARenato Westphal1-10/+0
In addition to being unnecessary, this check is problematic for the upcoming NSSA ranges feature since NSSA ranges aren't added to the OSPF routing table. Remove this for simplicity. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-10-06ospf6d: fix memleak when translating NSSA LSARenato Westphal1-2/+3
Stop leaking 4096 bytes for each translated LSA. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-10-06ospf6d: remove incomplete support for NSSA rangesRenato Westphal1-83/+0
This code tries to summarize NSSA Type-7 LSAs using normal ranges which are intended to summarize Type-3 LSAs only. This is not only wrong, but the code is incomplete and lacking lots of things. Better to remove it before implementing NSSA ranges correctly. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-10-06ospf6d: fix processing of translated AS-external LSAsRenato Westphal1-20/+14
The iteration performed on ospf6_abr_unapprove_translates() was wrong since AS-external LSAs are stored in the global LSDB and not in the area LSDBs. As such, the "unapproved" flag wasn't being set in any translated AS-external LSA, leading them to linger forever. Fix the LSDB iteration and make the required changes to unset the "unapproved" flag for AS-external LSAs that shouldn't be removed. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-10-06ospf6d: be careful to not refresh translated Type-5 LSAs twiceRenato Westphal1-9/+7
The ABR task already takes care of refreshing translated Type-5 LSAs that correspond to self-originated Type-7 LSAs. There's no need to do that in ospf_external_lsa_install() as well. The ospfd NSSA code takes the same precaution. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-10-06ospf6d: fix selection of NSSA forwarding addressRenato Westphal2-7/+11
Change ospf6_get_nssa_fwd_addr() to try finding a global address on any interface of the area and not on the first one only. Additionally, do a micro-optimization in ospf6_interface_get_global_address() to return as soon as a global address is found. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-10-06ospf6d: add "nssa" option to the "debug ospf6 lsa" commandRenato Westphal1-2/+4
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-10-06ospf6d: remove unnecessary codeRenato Westphal2-106/+0
Every received or originated LSA is automatically scheduled to be refreshed periodically, there's no need to do that manually here. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-10-06ospf6d: declare neighbor memtype as staticRenato Westphal1-1/+1
This is the only ospf6d memtype that wasn't being declared as static. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-10-06ospf6d: remove unused bitfieldRenato Westphal3-4/+0
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-10-06ospf6d: remove redundant loopRenato Westphal1-7/+5
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-10-06ospf6d: remove unguarded debug messageRenato Westphal1-2/+0
This debug message is of little use so remove it instead of adding a debug guard for it. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-10-06ospf6d: remove unused function parameterRenato Westphal1-14/+9
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-10-05isisd: fix redistribute CLIIgor Ryzhov4-7/+22
Currently, it is possible to configure IPv6 protocols for IPv4 redistribution and vice versa in CLI. The YANG model doesn't allow this so the user receives the following error: ``` nfware(config-router)# redistribute ipv4 ospf6 level-1 % Failed to edit configuration. YANG error(s): Invalid enumeration value "ospf6". Invalid enumeration value "ospf6". Invalid enumeration value "ospf6". YANG path: Schema location /frr-isisd:isis/instance/redistribute/ipv4/protocol. ``` Let's make CLI more user-friendly and allow only supported protocols in redistribution commands. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-10-05bgpd: large community exact match fixPhilippe Guibert1-1/+1
The pointer to large community was not the appropriate one. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2021-10-05lib: prevent gRPC assert on missing YANG nodeRafael Zalamena1-0/+4
`yang_dnode_get` will `assert` if no YANG node/model exist, so lets test for its existence first before trying to access it. This `assert` is only acceptable for internal FRR usage otherwise we might miss typos or unmatching YANG models nodes/leaves. For gRPC usage we should let users attempt to use non existing models without `assert`ing. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-10-05lib: fix spelling nits in command.hewlumpkin1-2/+2
Signed-off-by: ewlumpkin <ewlumpkin@gmail.com>