summaryrefslogtreecommitdiffstats
path: root/isisd/isis_tx_queue.h (unfollow)
Commit message (Collapse)AuthorFilesLines
2021-08-02lib: add "json" option to "show route-map"Renato Westphal2-52/+166
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-08-02lib: add "json" option to "show ip[v6] access-list"Renato Westphal2-72/+197
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-08-02bgpd: add "json" option to "show bgp as-path-access-list"Renato Westphal2-26/+76
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2021-07-31tests: add early interface config for topojson and fix testChristian Hopps2-0/+22
- A more general fix for the bgp listener test which requires interfaces be configured in the kernel when the bgpd daemons are launched. Signed-off-by: Christian Hopps <chopps@labn.net>
2021-07-30tests: add scapy_sendpkt.py util, replace arping use with itChristian Hopps2-6/+76
Signed-off-by: Christian Hopps <chopps@labn.net>
2021-07-30doc: fix bgp user docMark Stapp1-1/+1
Too many colons in the bgp doc source file. Signed-off-by: Mark Stapp <mjs.ietf@gmail.com>
2021-07-30lib, zebra: Preserve user-configured VRF on netns deletionXiao Liang2-2/+1
Don't clear VRF's user-configured flag when netns is deleted. Signed-off-by: Xiao Liang <shaw.leon@gmail.com>
2021-07-30doc: Fix code-block display for example shell commandsDonald Sharp1-8/+8
the code-block was jumbled and not displaying properly. Reported by: Drew Bloechl Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-29bgpd: use double-linked list instead of single-linked list in dampeningIgor Ryzhov2-11/+11
This code always used double-linked list before this rework in 8.0 that introduced all these crashes and memory leaks. Using single-linked list is actually a performance regression, because there are frequent removes here and single-linked list obviously handles removes much worse. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-29bgpd: fix missing damp info free when cleaning bgp pathIgor Ryzhov1-0/+3
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-29bgpd: fix missing delete from the list in dampeningIgor Ryzhov1-8/+4
When bgp_damp_info_free is called from bgp_route.c, we were never deleting the BDI from the list. Move the deletion inside bgp_damp_info_free to cover all cases. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-29bgpd: cleanup bgp_damp_info_freeIgor Ryzhov3-15/+9
bgp_damp_config, afi and safi are never used. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-29bgpd: fix memory leak in dampeningIgor Ryzhov1-5/+2
bdi->path is never NULL, therefore the structure was never freed. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-29bgpd: fix incorrect usage of slist in dampeningIgor Ryzhov2-88/+26
Current code is a complete misuse of SLIST structure. Instead of just adding a SLIST_ENTRY to struct bgp_damp_info, it allocates a separate structure to be a node in the list. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-29bgpd: fix missing list add in dampeningIgor Ryzhov1-1/+8
One more crash in dampening code... When bgp_damp_withdraw is called, if there's already a BDI structure, bgp_damp_info_claim is called to re-assign the bdi->config in case it was changed. The problem is that bgp_damp_info_claim actually removes the BDI from the reuse list of the old config and never adds it to the reuse list of the new config. We must do this to prevent the crash because all the code assumes that BDI is always in some list. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-29bgpd: Drop double-pointer for bgp_damp_info_free()Donatas Abraitis3-15/+15
This causes a crash using `clear ip bgp dampening <prefix>`. Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-07-28docs: update parensDonald Lee1-2/+2
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-28lib: Add parens around macro argsDonald Lee1-5/+5
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-28lib: Fix condition for snprintfDonald Lee1-1/+1
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-28bgpd: fix double free in dampening codeIgor Ryzhov1-10/+3
bgp_damp_info_unclaim already calls bgp_reuselist_del. We must not call it again here. Fixes #9046. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-28tests: Set addresses before we use snmpdDonald Sharp1-0/+10
The test_simple_snmp.py test starts bgp, zebra and snmpd at the same time. Then zebra configuration is read in and interface addresses are applied. If snmp start slower than zebra the snmp process can properly get it's ip address to bind to if it is faster than zebra, it will fail. Ensure that the test has addresses before we start daemons. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28zebra: bugfix of error quit of zebra, due to no nexthop ACTIVEbatmancn1-1/+3
There exists some rare situations where fpm will attempt to send a route update with no valid nexthops. In that case an assert would be hit. This is not good for trying to keep your routing daemons up and running when we can safely just recover the situation. Fixes #7588 Signed-off-by: batmancn <batmanustc@gmail.com> <fixed commit message, and used zlog_err> Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28pimd: fix missing list remove when deleting mesh groupIgor Ryzhov1-0/+1
This leads to a crash when you use "show run" after deleting the group. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-28lib: prevent crash in make check in some situationsDonald Sharp1-1/+23
When running `make check` against a build that zeromq enabled the test_zmq unit test was crashing. The commit: e08165def1c62beee0e87385e37ea5f12ca0f9b9 Introduced this crash. Removing the part of the commit that was causing the crash in the test. This is mainly to get `make check` working again for those people using zeromq in their builds. Fixes: #9176 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28bgpd: Mark the node as the correct type for bgp ipv6 unicastDonald Sharp1-1/+1
The bgp ipv6 unicast node should be called `bgp ipv6 unicast` to make it consistent with other nodes where we list the afi/safi Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28tests: add pytest.mark.isisd to those tests missing itDonald Sharp4-1/+8
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28tests: add pytest.mark.nhrpd for those missing itDonald Sharp1-1/+3
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28tests: Add pytest.mark.sharpd for those missing itDonald Sharp6-0/+14
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28tests: add pytest.mark.staticd for those tests missing itDonald Sharp2-0/+6
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28tests: Add pytest.mark.pimd for those missing itDonald Sharp8-4/+18
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28tests: Add pytest.mark.bgpd for tests missing this markDonald Sharp52-1/+123
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28tests: Add pytest.mark.ospfd on tests missing this markDonald Sharp21-0/+58
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28tests: Add pytestmark to get all snmp tests markedDonald Sharp1-0/+1
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-27ospfd: remove gratuitous non-ascii quotation marksChristian Hopps1-3/+3
Signed-off-by: Christian Hopps <chopps@labn.net>
2021-07-27tests: Increase timeout for loaded systemsDonald Sharp1-3/+3
When running this test on a locally loaded system I am seeing the static route as `queued` still after 1 second. Let's just blanket increase the timeout to something longer to give a very loaded system more time to install the route. Output on my test system when it was loaded: INFO topolog.r1:topogen.py:880 vtysh result: { "4.5.1.0/24":[ { "prefix":"4.5.1.0/24", "prefixLen":24, "protocol":"static", "vrfId":0, "vrfName":"default", "selected":true, "destSelected":true, "distance":1, "metric":0, "queued":true, "table":254, "internalStatus":8, "internalFlags":73, "internalNextHopNum":1, "internalNextHopActiveNum":1, "uptime":"00:00:00", "nexthops":[ { "flags":1, "ip":"192.168.216.3", "afi":"ipv4", "interfaceIndex":11, "interfaceName":"r1-eth6", "active":true, "weight":1 } ] }, I suspect 10 seconds should be enough( I would hope ). Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-27ospfd: don't exit when socket is not createdIgor Ryzhov1-1/+1
Let's be less radical. There's no reason to stop the whole daemon when there's a socket creation error in a single VRF. The user can always restart this single VRF to retry to create a socket. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-27ospf6d: Type-7 LSA originated with wrong sequence numberMobashshera Rasool1-6/+3
RCA: When Type-7 LSA is updated, the LSDB is searched, if the LSA is present in the LSDB then the LSA is updated with next sequence number and if not then it is originated with the INITIAL sequence number. Here while originating Type-7 LSA Process Level LSDB is searched for instead of area level LSDB. Fix: Search in the area level LSDB and not in the process level. Fixes #9099 Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2021-07-27pimd: Validate the fields before accessing itMobashshera Rasool2-22/+23
This commit is to correct the order in which the fields are accessed while verifying it. First the fields should be verified, and if it is valid then access it. Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2021-07-27pimd: fix incorrect bool returnsIgor Ryzhov1-2/+2
-1 is true when casted to bool. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-26tests: Reduce pim join/prune interval to 5 secondsDonald Sharp22-0/+22
Tests should have low enough overhead that sending the join/prune every 5 seconds should be sufficient also it should allow us to converge faster in case of dropped packets. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-26lib: formattingDonald Lee2-8/+9
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-26lib: Add new MTYPE for script resultsDonald Lee5-14/+22
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-26bgpd: Comment for includedDonald Lee1-1/+1
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-26doc: Modify documentation for timer changeDonald Sharp1-2/+4
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-26pimd: Allow join prune intervals to be as small as 5 secondsDonald Sharp2-3/+3
Allow the join-prune interval to be as small as 5 seconds instead of limiting the value to 60. This can and will come at a price of being able to converge less mroutes. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-26tests: Adding ospfv3 asbr summarisationMobashshera Rasool3-24/+2157
Total cases 9. Authored-by: nguggarigoud <nguggarigoud@vmware.com> Signed-off-by: nguggarigoud <nguggarigoud@vmware.com> Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2021-07-25vtysh: don't install "enable" command in user modeIgor Ryzhov1-20/+2
Recent change in d1b287e only fixed the problem for 3-letter words. We were still displaying error for longer words starting with "ena": ``` nfware> enac % Command not allowed: enable nfware> enad % Command not allowed: enable nfware> enaena % Command not allowed: enable ``` If we don't allow "enable" command in user mode, why add it at all? Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-23lib: Rename decode_intDonald Lee3-3/+3
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-23lib: zlog err in error cases during lua loadingDonald Lee1-2/+9
Signed-off-by: Donald Lee <dlqs@gmx.com>
2021-07-23lib: comment typoDonald Lee1-1/+1
Signed-off-by: Donald Lee <dlqs@gmx.com>