summaryrefslogtreecommitdiffstats
path: root/nhrpd/nhrp_main.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2021-03-18nhrpd: Add zbuf routine to peek at contentsAmol Lad2-0/+13
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-17pathd: remove mid-string line breaksDavid Lamparter3-22/+11
cf. workflow.rst ("lines over 80 characters are allowed for text strings to make it possible to search the code for them"), matching Linux kernel coding style. Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17pathd: use %pIA to print struct ipaddr *David Lamparter1-25/+13
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17pathd: fix %pI4 <> %pI6 snafuDavid Lamparter1-1/+1
... as noted by the frr-format GCC plugin. Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17nhrpd: When IPsec profile is added or deleted, reset the vc and re-check peerGaurav Goyal4-1/+10
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-17nhrpd: Make comments clearer, fix style issuesReuben Dowle3-11/+14
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-17nhrpd: Close IPSec connection when tunnel protection removedGaurav Goyal4-6/+18
Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-17nhrpd: Retry IPSec if NHRP is repeatedly failingGaurav Goyal3-0/+23
This prevents a failed IPSec connection from preventing DMVPN from working. A failure situation can be reproduced using a Cisco peer, and and disabling then re-enabling the tunnel IPSec protection (after the IPSec connection has already been established). Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-17bgpd: If we have a SAFI conflict do not allow labeled unicast to resetDonald Sharp1-1/+1
If we have a SAFI conflict, ie we are trying to activate safi's UNICAST and LABELED_UNICAST at the same time, we should not cause bestpath to be rerun and we should not try to put labels on everything. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-03-17bgpd: Attempting to activate unicast and labeled-unicastDonald Sharp1-2/+2
Should return an actual useful error message. Commit: 055679e915fc826fe13abdd8d60a22a0ca35c8c6 messed this error message up. Fixes: #8246 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-03-16ospf6d: Fix coverity errorslynne1-2/+5
Signed-off-by: Lynne Morrison <lynne@voltanet.io>
2021-03-16bfdd: separate echo rx/tx timersIgor Ryzhov33-106/+388
Currently there is a single interval for both RX and TX echo functions. This commit introduces separate RX and TX timers for echo packets. The main advantage is to be able to set the receive interval to zero when we don't want to receive echo packets from the remote system. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-03-16isisd: Fix coverity warningslynne1-11/+11
Signed-off-by: Lynne Morrison <lynne@voltanet.io>
2021-03-16ospfd6: Clear locks when ospf messages need to be chunkedlynne1-4/+12
When there are too many LSA updates to be sent in a packet the code needs to correctly clear the locks that are taken while walking the lists and then wait for the appropriate timer to expire to continue walking the list. The routine that was being called would not properly remove all the locks that needed to be cleared, and would also try to incorrectly delete the lsa/route. The code now clears the locks and leaves the lsa on the list. When the timers fire again the code continues walking the list to send the rest of the lsas to the neighbor. Signed-off-by: Lynne Morrison <lynne@voltanet.io>
2021-03-16tests: re-enable RTE tests after removing fixed ifindicesPat Ruddy1-2/+17
Change ifindex test to grab the correct indices using the API provided. Signed-off-by: Pat Ruddy <pat@voltanet.io>
2021-03-16tests: fix formatting error to make black cleanPat Ruddy1-4/+2
Signed-off-by: Pat Ruddy <pat@voltanet.io>
2021-03-16doc: add more notes about new topotestsMark Stapp2-5/+14
Add some extra notes to the dev doc section about writing new topotests: check for OS/kernel support if necessary; avoid volatile or unstable data like ifindices or link-locals. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2021-03-16doc: fix warnings in dev docsMark Stapp2-2/+2
Fix a couple of warnings in dev doc rst files. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2021-03-16eigrpd: fix dependency on operational state in cliIgor Ryzhov1-12/+11
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-03-16eigrpd: fix xpathsIgor Ryzhov1-2/+2
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-03-16bfdd: warn users about echo-mode restrictionsIgor Ryzhov2-1/+6
Echo-mode implementation is currently broken. Instead of sending packets to it's own address, bfdd is sending echo packets to the peer's address. It may seem to work when testing between two FRR instances, because FRR loops back such packets, but no other implementation is supposed to do that. Let's warn users that the current implementation works only between two FRR instances. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-03-16bfdd: fix starting echo receive timerIgor Ryzhov1-1/+3
Currently this timer is only started when we receive the first echo packet. If we never receive the packet, the timer is never started and the user falsely assumes that echo function is working. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-03-16tests: update LDP SNMP topotest to walk mib objects that are statisticsKaren Schoener1-0/+48
Signed-off-by: Karen Schoener <karen@voltanet.io>
2021-03-16ldpd: Add support for the read-only snmp mib objects that are statisticsKaren Schoener4-4/+261
Add support for the read-only snmp mib objects as described in RFC 3815 that are statistics. Signed-off-by: Lynne Morrison <lynne@voltanet.io> Signed-off-by: Karen Schoener <karen@voltanet.io>
2021-03-16test: fix isis-snmp testlynne6-14/+0
Remove ifindex values being tested because it can change between runs of the test. Signed-off-by: Lynne Morrison <lynne@voltanet.io>
2021-03-15pimd: Fix clang issue with -Waddress-of-packed-memberDonald Sharp1-9/+17
Recent change in commit: 6b73800ba27e7f69453a191dfb873c2e07194516 Caused this error to pop up in pim_igmp_mtrace.c: error: taking address of packed member 'rsp_addr' of class or structure 'igmp_mtrace' may result in an unaligned pointer value [-Werror,-Waddress-of-packed-member] Follow the pattern used in the code to solve this problem for clang Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-03-15bgpd: use appropriate printf formatter for some uint32_tDonald Sharp1-4/+4
newm and existm are uint32_t so let's use %u instead of %d to print them out. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-03-14*: remove remaining severity prefixesDavid Lamparter3-6/+6
Having a "warning:" prefix on a debug message is particularly dumb... Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-14zebra: move up prefix2str call in rib dumpDavid Lamparter1-1/+3
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-14zebra: use printfrr exts in EVPN/VXLAN codeDavid Lamparter7-467/+213
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-14fpm: use printfrr extsDavid Lamparter2-11/+6
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-14*: fix printf extension typesDavid Lamparter4-8/+8
Some mistakes have crept in again. Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-14lib: Convert to builtin printf functionalityDonald Sharp2-17/+11
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-03-14ospf6d: Convert to use builtin printf functionalityDonald Sharp2-54/+24
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-03-14eigrpd: Convert to using our builtin printf stuffDonald Sharp2-12/+4
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-03-14pimd: Use builtin printf functionalityDonald Sharp2-63/+20
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-03-14babeld: We do not need to put Warning into our warning messagesDonald Sharp3-15/+16
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-03-14sharpd: Convert over to using builtin printf functionalityDonald Sharp1-11/+6
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-03-14bfdd: make sessions administratively up by defaultIgor Ryzhov5-8/+5
Current behavior is inconsistent. When the session is created by another daemon, it is up by default. When we later configure peer in bfdd, the session is still up, but the NB layer thinks that it is down. More than that, even when the session is created in bfdd using peer command, it is created in DOWN state, not ADM_DOWN. And it actually starts sending and receiving packets. The sessions is marked with SHUTDOWN flag only when we try to reconfigure some parameter. This behavior is also very unexpected. Fixes #7780. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-03-14nhrpd: Set hop count to 1 in traffic indicationGaurav Goyal1-1/+1
If hop count is 0, this causes Cisco routers to reject the traffic indication as invalid. This appears to be a Cisco bug, and has been observed in processing of registration packets in the past. That problem was covered in issue #951 Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
2021-03-14doc: Add `show [ip] bgp peer-group [json]` commandDonatas Abraitis1-0/+68
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-03-14bgpd: Add JSON output for `show ip bgp peer-group` commandDonatas Abraitis1-48/+170
``` exit1-debian-9# show bgp peer-group BGP peer-group test, remote AS 123 Peer-group type is external Configured address-families: IPv4 Unicast; IPv6 Unicast; 1 IPv4 listen range(s) 192.168.100.0/24 2 IPv6 listen range(s) 2001:db8:1::/64 2001:db8:2::/64 Peer-group members: 192.168.200.1 Active 2001:db8::1 Active BGP peer-group test3 Peer-group type is external Configured address-families: IPv4 Unicast; exit1-debian-9# exit1-debian-9# show bgp peer-group json { "test":{ "remoteAs":123, "type":"external", "addressFamiliesConfigured":[ "IPv4 Unicast", "IPv6 Unicast" ], "dynamicRanges":{ "IPv4":{ "count":1, "ranges":[ "192.168.100.0\/24" ] }, "IPv6":{ "count":2, "ranges":[ "2001:db8:1::\/64", "2001:db8:2::\/64" ] } }, "members":{ "192.168.200.1":{ "status":"Active" }, "2001:db8::1":{ "status":"Active" } } }, "test3":{ "type":"external", "addressFamiliesConfigured":[ "IPv4 Unicast" ] } } ``` Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-03-14doc: update the FRR format tableRafael Zalamena1-0/+4
Let other developers know that we have `%pIA` to print `struct ipaddr *`. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-03-14bgpd: fix wrong debug formatRafael Zalamena1-1/+1
Use `%pIA` instead of `%pI4` for `struct ipaddr *`. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-03-14topotests: temporary disable test assertRafael Zalamena1-1/+1
The test has been failing often recently and it is causing some false positives for unrelated PRs. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-03-12topotests: remove some interface index checkRafael Zalamena6-7/+0
Don't expect the interface index to be always the same. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-03-12topotests: remove some FRR version checksRafael Zalamena2-95/+0
We version the tests with the source code so we should no longer attempt to support old versions in development branch. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-03-12Revert "zebra: Remove `first_p` which is never used"Jafar Al-Gharaibeh1-1/+4
This reverts commit 8617eb7c5ff9fe9ae1efb69af1493585d69a37f5.
2021-03-12zebra: Remove `first_p` which is never usedDonald Sharp1-4/+1
Remove dead code. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-03-10tools: add explicit licence phraseJafar Al-Gharaibeh1-2/+17
Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-19 17:20:18 +0100