summaryrefslogtreecommitdiffstats
path: root/pceplib (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #15215 from donaldsharp/pceplib_fixupDonatas Abraitis2024-01-258-116/+113
|\ | | | | Compile issue fixups
| * pceplib: Fix code not building properlyDonald Sharp2024-01-248-116/+113
| | | | | | | | | | | | | | | | | | | | The series of pceplib tests are not being run at the moment due to them not even building. Apparently adding the `libcunit1` debian package is enough to get them to build in our system. While weird, let's get this building at least for people that have this and `--enable-werror` turned on. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | pceplib: Fix some new coverity issues that trickled inDonald Sharp2024-01-252-24/+9
|/ | | | | | | | Several new issues came in because the coverity build system was not building the test infrastrucuture for the pceplib. Now we do, so we fixed it. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* pceplib: fix compilation errorPhilippe Guibert2024-01-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | The following compilation error happens, with pcep test files. > In file included from pceplib/test/pcep_utils_counters_test.c:31: > pceplib/test/pcep_utils_counters_test.c: In function 'test_create_subgroup_counter': > pceplib/test/pcep_utils_counters_test.c:127:25: error: too few arguments to function 'create_subgroup_counter' > 127 | CU_ASSERT_FALSE(create_subgroup_counter(subgroup, counter_id + 1, > | ^~~~~~~~~~~~~~~~~~~~~~~ > In file included from pceplib/test/pcep_utils_counters_test.c:33: > ./pceplib/pcep_utils_counters.h:163:6: note: declared here > 163 | bool create_subgroup_counter(struct counters_subgroup *subgroup, > | ^~~~~~~~~~~~~~~~~~~~~~~ > Makefile:10948: recipe for target 'pceplib/test/pceplib_test_pcep_utils_tests-pcep_utils_counters_test.o' failed > make[3]: *** [pceplib/test/pceplib_test_pcep_utils_tests-pcep_utils_counters_test.o] Error 1 > make[3]: *** Waiting for unfinished jobs.... There is a missing parameter. Fixes: 09047d2bf614 ("pceplib: add json string option to subgroup counter") Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
* pceplib: add json string option to subgroup counterPhilippe Guibert2024-01-184-113/+141
| | | | | | | | | | | | | | The created counters in pceplib library are structures with a string attribute which is used for further display. This string information is not formatted for json output. Add a second option in the create_subgroup_counter() creation API to provide the json attribute output. Create a json naming compatible with caml format for each subgroup counter used. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
* *: auto-convert to SPDX License IDsDavid Lamparter2023-02-0990-1170/+90
| | | | | | Done with a combination of regex'ing and banging my head against a wall. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* Merge pull request #12707 from donaldsharp/missed_enumsDonatas Abraitis2023-02-073-8/+61
|\ | | | | Missed enums
| * pceplib: Add missing enum's to switch statementDonald Sharp2023-01-313-8/+61
| | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | pceplib: add <time.h> include for time_tSam James2023-02-061-0/+1
|/ | | | | | | Fixes build on musl. Used for time_t in the header. Bug: https://bugs.gentoo.org/862558 Signed-off-by: Sam James <sam@gentoo.org>
* *: apply proper format string attributesDavid Lamparter2023-01-271-1/+3
| | | | | | So that we get warnings about broken format strings. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* pceplib: Fix clang-16 not happy with buildDonald Sharp2022-10-2611-25/+23
| | | | | | In this case it was functions without a prototype Signed-off-by: Donald Sharp <donaldsharp72@gmail.com>
* *: Properly use memset() when zeroingDonatas Abraitis2022-05-111-1/+1
| | | | | | | Wrong: memset(&a, 0, sizeof(struct ...)); Good: memset(&a, 0, sizeof(a)); Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
* Merge pull request #11163 from opensourcerouting/fix/same_type_castingIgor Ryzhov2022-05-091-2/+1
|\ | | | | *: Avoid casting to the same type as on the left
| * *: Avoid casting to the same type as on the leftDonatas Abraitis2022-05-081-2/+1
| | | | | | | | | | | | Just not necessary. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
* | *: Fix doesnt spelling mistakesDonald Sharp2022-05-074-8/+9
|/ | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* *: Fix spelling of ojbectDonald Sharp2022-04-021-1/+1
| | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* pceplib: Fix uninited data in test vehicleDonald Sharp2022-02-221-1/+1
| | | | | | Coverity SA found this. Fix Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* pceplib: Fix spelling mistakesDonald Sharp2022-02-141-1/+1
| | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* pceplib: fix style issuesQuentin Young2021-12-067-46/+45
| | | | | | | | | | run clang-format run clang-format run clang-format run clang-format run clang-format Signed-off-by: Quentin Young <qlyoung@nvidia.com>
* tests: clean up temp files in libpcep testsMark Stapp2021-11-022-13/+53
| | | | | | Clean up temp files used by some libpcep unit tests. Signed-off-by: Mark Stapp <mstapp@nvidia.com>
* pceplib: fix for -Wstrict-prototypesDavid Lamparter2021-09-023-4/+4
| | | | | | Just some "void" missing between empty braces. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* pceplib: Extract fields needed for PcInitiated with Cisco pce. (1/4)Javier Garcia2021-06-225-10/+32
| | | | | | | | | 1.- Unknown/non-standard tlv where cisco sends BSID. 2.- Non-standard Vendor Info object where cisco sends color. Co-authored-by: Javier Garcia <javier.garcia@voltanet.io> Signed-off-by: Sebastien Merle <sebastien@netdef.org> Signed-off-by: Javier Garcia <javier.garcia@voltanet.io>
* pceplib: fix mixup of global/local variablesIgor Ryzhov2021-05-281-2/+2
| | | | | | CID 1502790 Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
* pceplib: Clean scan-build static analyzer messages.Javier Garcia2021-05-0513-0/+188
| | | | Signed-off-by: Javier Garcia <javier.garcia@voltanet.io>
* *: make sure `config.h` or `zebra.h` is firstDavid Lamparter2021-04-2343-0/+172
| | | | | | | | | | | | `config.h` has all the defines from autoconf, which may include things that switch behavior of other included headers (e.g. _GNU_SOURCE enabling prototypes for additional functions.) So, the first include in any `.c` file must be either `config.h` (with the appropriate guard) or `zebra.h` (which includes `config.h` first thing.) Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* build: properly split CFLAGS from AC_CFLAGSDavid Lamparter2021-04-212-3/+3
| | | | | | | | `CFLAGS` is a "user variable", not intended to be controlled by configure itself. Let's put all the "important" stuff in AC_CFLAGS and only leave debug/optimization controls in CFLAGS. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* Merge pull request #8421 from opensourcerouting/xrelfo-armMark Stapp2021-04-122-0/+18
|\ | | | | fix xrelfo on ARM(32) & cross-compile
| * pceplib: add missing endian.h and config.hDavid Lamparter2021-04-092-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | endian.h supplies be*toh() and htobe*() functions. This fixes the build on musl libc. On other systems it seems endian.h comes in transitively from some other header. (Also, all .c files should have config.h or zebra.h as the first include, even if it works without that it's b0rked and only works due to luck.) Tested-by: Lucian Cristian <lucian.cristian@gmail.com> Signed-off-by: David Lamparter <equinox@diac24.net>
* | lib: use platform-neutral value for TCP MD5 signature lenMark Stapp2021-04-094-9/+15
|/ | | | | | | Use a pcep-specific value for MD5SIG_MAXLEN, use the OS value if present. Signed-off-by: Mark Stapp <mjs@voltanet.io>
* build: add pceplib test output to gitignoreMark Stapp2021-03-311-0/+12
| | | | | | Add some pcep unit-test output files to gitignore. Signed-off-by: Mark Stapp <mjs@voltanet.io>
* libs: fix race in pcep libMark Stapp2021-03-251-4/+7
| | | | | | Fix a race in the libpcep timer code; reported by coverity. Signed-off-by: Mark Stapp <mjs@voltanet.io>
* pceplib: Fixing coverity messages.Javier Garcia2021-03-2015-41/+178
| | | | Signed-off-by: Javier Garcia <javier.garcia@voltanet.io>
* pathd: remove mid-string line breaksDavid Lamparter2021-03-171-2/+1
| | | | | | | | cf. workflow.rst ("lines over 80 characters are allowed for text strings to make it possible to search the code for them"), matching Linux kernel coding style. Signed-off-by: David Lamparter <equinox@diac24.net>
* pceplib: Integrate pcelib into frrJavier Garcia2021-03-05100-0/+26051
Signed-off-by: Brady Johnson <brady@voltanet.io> Co-authored-by: Javier Garcia <javier.garcia@voltanet.io> Signed-off-by: Javier Garcia <javier.garcia@voltanet.io>
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-30 18:30:20 +0100