summaryrefslogtreecommitdiffstats
path: root/sharpd (unfollow)
Commit message (Collapse)AuthorFilesLines
2021-07-28pimd: fix missing list remove when deleting mesh groupIgor Ryzhov1-0/+1
This leads to a crash when you use "show run" after deleting the group. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-28bgpd: Mark the node as the correct type for bgp ipv6 unicastDonald Sharp1-1/+1
The bgp ipv6 unicast node should be called `bgp ipv6 unicast` to make it consistent with other nodes where we list the afi/safi Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28tests: add pytest.mark.isisd to those tests missing itDonald Sharp4-1/+8
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28tests: add pytest.mark.nhrpd for those missing itDonald Sharp1-1/+3
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28tests: Add pytest.mark.sharpd for those missing itDonald Sharp6-0/+14
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28tests: add pytest.mark.staticd for those tests missing itDonald Sharp2-0/+6
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28tests: Add pytest.mark.pimd for those missing itDonald Sharp8-4/+18
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28tests: Add pytest.mark.bgpd for tests missing this markDonald Sharp52-1/+123
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28tests: Add pytest.mark.ospfd on tests missing this markDonald Sharp21-0/+58
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-28tests: Add pytestmark to get all snmp tests markedDonald Sharp1-0/+1
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-27ospfd: remove gratuitous non-ascii quotation marksChristian Hopps1-3/+3
Signed-off-by: Christian Hopps <chopps@labn.net>
2021-07-27ospfd: don't exit when socket is not createdIgor Ryzhov1-1/+1
Let's be less radical. There's no reason to stop the whole daemon when there's a socket creation error in a single VRF. The user can always restart this single VRF to retry to create a socket. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-27pimd: Validate the fields before accessing itMobashshera Rasool2-22/+23
This commit is to correct the order in which the fields are accessed while verifying it. First the fields should be verified, and if it is valid then access it. Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2021-07-27pimd: fix incorrect bool returnsIgor Ryzhov1-2/+2
-1 is true when casted to bool. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-26tests: Reduce pim join/prune interval to 5 secondsDonald Sharp22-0/+22
Tests should have low enough overhead that sending the join/prune every 5 seconds should be sufficient also it should allow us to converge faster in case of dropped packets. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-26doc: Modify documentation for timer changeDonald Sharp1-2/+4
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-26pimd: Allow join prune intervals to be as small as 5 secondsDonald Sharp2-3/+3
Allow the join-prune interval to be as small as 5 seconds instead of limiting the value to 60. This can and will come at a price of being able to converge less mroutes. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-25vtysh: don't install "enable" command in user modeIgor Ryzhov1-20/+2
Recent change in d1b287e only fixed the problem for 3-letter words. We were still displaying error for longer words starting with "ena": ``` nfware> enac % Command not allowed: enable nfware> enad % Command not allowed: enable nfware> enaena % Command not allowed: enable ``` If we don't allow "enable" command in user mode, why add it at all? Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-23bgpd: Use strcmp comparing BGP alias with an actual entered aliasDonatas Abraitis2-6/+4
It might be a case when a partial match is hit and this needs to be fixed. Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-07-22bgpd: Fix rpki spacing to be 1 for indentationDonald Sharp1-4/+4
The rpki sub-node was outputting 2 spaces instead of 1 space. Let's fix that to be consistent with the rest of our code. Fixes: #2738 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-22zebra: Remove MM seq from evpn rmac json outputTrey Aspelund1-2/+0
Currently 'show evpn rmac vni .. mac .. json' includes fields for localSequence and remoteSequence, which are misleading since they aren't applicable to a macs in the IP-VRF mac table (RMAC). This removes the localSequence + remoteSequence fields from the output. Signed-off-by: Trey Aspelund <taspelund@nvidia.com>
2021-07-22vtysh: Handle `en` better when in -u for vtyshDonald Sharp1-3/+14
vtysh was unable to distinguish between end and ena. The code can now do so: sharpd@eva ~/frr5 (master)> sudo vtysh/vtysh -u sharpd Hello, this is FRRouting (version 8.1-dev). Copyright 1996-2005 Kunihiro Ishiguro, et al. eva> e % Ambiguous command: e eva> en % Command not allowed: enable eva> ena % Command not allowed: enable eva> enab % Command not allowed: enable eva> enabl % Command not allowed: enable eva> enable % Command not allowed: enable eva> enb % Unknown command: enb eva> enc % Unknown command: enc eva> end % Unknown command: end eva> ene % Unknown command: ene eva> quit Fixes: #2296 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-21zebra: On client shutdown cleanup any vrf labels associated with itDonald Sharp5-0/+45
When a vrf label is created by a client and the client disconnects we should clean up any vrf labels associated with that client. eva# show mpls table Inbound Label Type Nexthop Outbound Label ----------------------------------------------- 1000 SHARP RED - eva# exit sharpd@eva ~/f/zebra (label_destruction)> ps -ef | grep frr root 4017793 1 0 13:57 ? 00:00:00 /usr/lib/frr/watchfrr -d -F datacenter --log file:/var/log/frr/watchfrr.log --log-level debug zebra bgpd ospfd isisd pimd eigrpd sharpd staticd frr 4017824 1 0 13:57 ? 00:00:00 /usr/lib/frr/zebra -d -F datacenter --log file:/tmp/zebra.log -r --graceful_restart 60 -A 127.0.0.1 -s 90000000 frr 4017829 1 0 13:57 ? 00:00:00 /usr/lib/frr/bgpd -d -F datacenter -M rpki -A 127.0.0.1 frr 4017836 1 0 13:57 ? 00:00:00 /usr/lib/frr/ospfd -d -F datacenter -A 127.0.0.1 frr 4017839 1 0 13:57 ? 00:00:00 /usr/lib/frr/isisd -d -F datacenter -A 127.0.0.1 frr 4017842 1 0 13:57 ? 00:00:00 /usr/lib/frr/pimd -d -F datacenter -A 127.0.0.1 frr 4017865 1 0 13:57 ? 00:00:00 /usr/lib/frr/eigrpd -d -F datacenter -A 127.0.0.1 frr 4017869 1 0 13:57 ? 00:00:00 /usr/lib/frr/sharpd -d -F datacenter -A 127.0.0.1 frr 4017888 1 0 13:57 ? 00:00:00 /usr/lib/frr/staticd -d -F datacenter -A 127.0.0.1 sharpd 4018624 3938423 0 14:02 pts/10 00:00:00 grep --color=auto frr sharpd@eva ~/f/zebra (label_destruction)> sudo kill -9 4017869 sharpd@eva ~/f/zebra (label_destruction)> sudo vtysh -c "show mpls table" sharpd@eva ~/f/zebra (label_destruction)> Fixes: #1787 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-21build: use `--coverage` for gcovDavid Lamparter1-2/+2
libtool does not understand `-coverage` with a single dash. Official gcc docs also say `--coverage` rather than `-coverage`. (clang lists both.) Also, for correct linking, libtool needs `--coverage` in LDFLAGS as opposed to `-lgcov` (with the latter you get library ordering/deps issues) Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-07-21build: fix `AM_LDFLAGS` usage (and gcov)David Lamparter16-29/+53
like the other automake variables, setting `xyz_LDFLAGS` causes `AM_LDFLAGS` to be ignored for `xyz`. For some reason I had in my mind that automake doesn't do this for LDFLAGS, but... it does. (Which is consistent with `_CFLAGS` and co.) So, all the libraries and modules have been ignoring `AM_LDFLAGS` (which includes `SAN_FLAGS` too). Set up new `LIB_LDFLAGS` and `MODULE_LDFLAGS` to handle all of this correctly (and move these bits to a central location.) Fixes: #9034 Fixes: 0c4285d77eb ("build: properly split CFLAGS from AC_CFLAGS") Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-07-21lib, zebra: fix exit from link-params nodeIgor Ryzhov1-0/+3
When exiting from link-params node, we must not decrement xpath_index because it is not incremented when entering the node. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-21vtysh: fix exit from zebra-only nodesIgor Ryzhov1-3/+30
When exiting from link-params and pseudowire nodes, we were sending exit command to all VTYSH_INTERFACE daemons. This led to a desynchronized state in vtysh and daemons other then zebra. We must send exit command only to zebra. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-21tests: fix invalid multiline formatIgor Ryzhov1-4/+4
`format` can't be used per-line when we have a multiline string. This was recently broken in 3881d05. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-07-21doc: Add `match alias` command for BGP route-mapsDonatas Abraitis1-0/+6
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-07-21tests: Check if `match alias` works for route-mapsDonatas Abraitis4-13/+48
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-07-21bgpd: Add route-map `match alias` commandDonatas Abraitis7-1/+192
Will be handy to filter BGP prefixes by using BGP community alias instead of numerical community values. Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-07-20zebra: Mark some bsd interface prefixes as SECONDARYDonald Sharp1-3/+9
Notice when a ip address on a bsd interface is considered an alias, let's mark the connected prefix we generate as a SECONDARY. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-20pathd: don't use localtimeMark Stapp1-3/+3
Use localtime_r() instead of localtime() in pathd. Signed-off-by: Mark Stapp <mjs.ietf@gmail.com>
2021-07-20ospf6d: always generate default route for stubsRafael Zalamena1-13/+0
In RFC 2328 OSPF Version 2, Section 12.4.3.1 "Originating summary-LSAs into stub areas" mentions that the stub areas should not import external routes and instead should generate a 'default summary-LSA' set to default destination. > In a stub area, instead of importing external routes > each area border router originates a "default summary- > LSA" into the area. The Link State ID for the default > summary-LSA is set to DefaultDestination, and the metric > set to the (per-area) configurable parameter > StubDefaultCost. Note that StubDefaultCost need not be > configured identically in all of the stub area's area > border routers. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-07-20ospfd: ospfd crash while giving 'clear ip ospf neighbor'rgirada1-0/+5
Description: Ospf process crashes upon giving 'clear ip ospf neighbor' with self routerId. It is asserting if it is a self neighbor in ospf neighbour kill event processing. Added a check to validate the provided router-id is self router-id. Signed-off-by: Rajesh Girada <rgirada@vmware.com>
2021-07-20zebra: trigger remove all access vlans for access portgord_chen1-14/+18
When port was removed from last access vlan, the linux kernel won't send any vlan info in the netlink message, it might affact the evpn mh not withdraw EAD-EVI routes. Signed-off-by: Gord Chen <gord_chen@edge-core.com>
2021-07-20tests: Adding ospfv3 basic functionality test casesnguggarigoud8-340/+2578
1. Adding APIs to configure and verify ospfv3. 2. Adding ospfv3 base functionality testcase. Signed-off-by: nguggarigoud <nguggarigoud@vmware.com>
2021-07-20ospf6d: use OSPF6_INTERFACE_LOOPBACK stateDavid Lamparter1-1/+3
The OSPF6_INTERFACE_LOOPBACK interface state wasn't entered anywhere, even if the interface was OSPF6_IFTYPE_LOOPBACK. Fix. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-07-20ospf6d: don't create Adv-ID:0.0.0.0 LSAs at startDavid Lamparter1-0/+10
When ospf6d comes up, it gets interface and address state before it decides on its router ID. This results in a bunch of LSAs with advertising router ID 0.0.0.0 in the LSDB. Not quite right. There's a whole bunch of paths leading to this, so just drop the LSA in ospf6_lsa_originate. The router-ID change causes everything to be readvertised anyway (... but the delete doesn't catch the 0.0.0.0 stuff because the router-ID is now different.) Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-07-20ospf6d: actually print prefix optionsDavid Lamparter1-2/+6
Well at least I had a good laugh at the "xxx". Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-07-20ospf6d: move prefix_options from _path to _routeDavid Lamparter6-14/+15
Prefix options are per-prefix, not per-path. As evident by the fact that the field is never used on ECMP paths. Move it where it belongs. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-07-20zebra: Do not allow redistribution for non-vrf tablesDonald Sharp1-0/+6
Current code was allowing redistribution of kernel routes from the non-default non vrf tables once FRR was already up and running. In the case where we add `redistribute kernel` in an upper level protocol we never consider the non-default vrf or non-vrf tables so it is never accepted. In the case where a kernel route is added after `redistribute kernel` is already in place we were never looking at the fact that the route was in a non-default non-vrf table. This code fixes that issue. Fixes: #9073 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-07-19pimd: Add TOS check for IGMP conformanceMobashshera Rasool1-0/+11
IGMPv3 packets with invalid TOS should be dropped. Test Case ID: 4.10 TEST_DESCRIPTION Every IGMP message described in this document is sent with IP Precedence of Internetwork Control (e.g., Type of Service 0xc0) (Tests that IGMPv3 Membership Query Message conforms to above statement) TEST_REFERENCE NEGATIVE: RFC 3376, IGMP Version 3, s4 p7 Message Formats Issue: #9071 Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2021-07-19pimd: Add TTL check for IGMP conformanceMobashshera Rasool1-0/+10
IGMPv3 packets with invalid TTL should be dropped. Test Case ID: 4.10 TEST_DESCRIPTION Every IGMP message described in this document is sent with an IP Time-to-Live of 1 (Tests that IGMPv3 Membership Report Message conforms to above statement) TEST_REFERENCE NEGATIVE: RFC 3376, IGMP Version 3, s4 p7 Message Formats Issue: #9070 Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2021-07-19pimd: Abstracting header verification for igmpMobashshera Rasool2-17/+31
Moving the header verification checks inside a function. Signed-off-by: Mobashshera Rasool <mrassol@vmware.com>
2021-07-19zebra: replace ipaddr2str in dplane moduleMark Stapp1-7/+3
Replace a couple of ipaddr2str calls with pIA in the dplane module. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2021-07-19tests: skip tests after errors in bgp-evpn-vxlanMark Stapp1-0/+8
In bgp-evpn-vxlan, skip test cases if there's been a failure; a couple of cases were missing this. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2021-07-19zebra: process EVPN remote VTEP updates from the workqueueMark Stapp5-111/+227
Move remote VTEP updates from immediate, inline processing in their ZAPI message handlers to the main workqueue. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2021-07-19zebra: use workqueue for vxlan remote macip updatesMark Stapp5-19/+102
Enqueue incoming vxlan remote macip updates on the main workqueue, instead of performing the updates immediately, in-line. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2021-07-19zebra: use more constMark Stapp13-103/+119
Use const in many more evpn apis, especially for macaddr, ipaddr arguments. Signed-off-by: Mark Stapp <mjs@voltanet.io>
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-19 22:59:14 +0100