From 673f1d4d57c1f48cad4734e72524e5f83353c9dc Mon Sep 17 00:00:00 2001 From: zmw12306 Date: Sat, 22 Apr 2023 15:11:13 -0400 Subject: babeld: ignore nonzero flag bits in Hello TLVs Ignore all other bits(except U) in Hello TLVs, according to RFC8966 Signed-off-by: zmw12306 --- babeld/message.c | 12 ------------ 1 file changed, 12 deletions(-) (limited to 'babeld') diff --git a/babeld/message.c b/babeld/message.c index b5c2a5898..15d772eb4 100644 --- a/babeld/message.c +++ b/babeld/message.c @@ -413,18 +413,6 @@ parse_packet(const unsigned char *from, struct interface *ifp, #define BABEL_UNICAST_HELLO 0x8000 DO_NTOHS(flags, message + 2); - /* - * RFC 8966 4.6.5 - * All other bits MUST be sent as a 0 and silently - * ignored on reception - */ - if (CHECK_FLAG(flags, ~BABEL_UNICAST_HELLO)) { - debugf(BABEL_DEBUG_COMMON, - "Received Hello from %s on %s that does not have all 0's in the unused section of flags, ignoring", - format_address(from), ifp->name); - goto done; - } - /* * RFC 8966 Appendix F * TL;DR -> Please ignore Unicast hellos until FRR's -- cgit v1.2.3