diff options
| author | Jeff King <peff@peff.net> | 2017-09-13 19:11:28 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2017-09-14 08:16:21 +0200 |
| commit | 68a423ab3e5c160e1162382d2ef0831039b298d4 (patch) | |
| tree | 85e6b35d1f5e3d27464ccba74ca9f12a99cc58be /builtin/hash-object.c | |
| parent | config: avoid "write_in_full(fd, buf, len) < len" pattern (diff) | |
| download | git-68a423ab3e5c160e1162382d2ef0831039b298d4.tar.xz git-68a423ab3e5c160e1162382d2ef0831039b298d4.zip | |
get-tar-commit-id: check write_in_full() return against 0
We ask to write 41 bytes and make sure that the return value
is at least 41. This is the same "dangerous" pattern that
was fixed in the prior commit (wherein a negative return
value is promoted to unsigned), though it is not dangerous
here because our "41" is a constant, not an unsigned
variable.
But we should convert it anyway to avoid modeling a
dangerous construct.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/hash-object.c')
0 files changed, 0 insertions, 0 deletions