summaryrefslogtreecommitdiffstats
path: root/builtin
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2022-05-04 18:51:28 +0200
committerJunio C Hamano <gitster@pobox.com>2022-05-04 18:51:28 +0200
commit8ed16bd600b0fd8e0ac0090e0dc8375614cc0ba8 (patch)
treee562fad8986a2e5f996e62fe11e82a866366ae55 /builtin
parentMerge branch 'rs/format-patch-pathspec-fix' (diff)
parentclone: plug a miniscule leak (diff)
downloadgit-8ed16bd600b0fd8e0ac0090e0dc8375614cc0ba8.tar.xz
git-8ed16bd600b0fd8e0ac0090e0dc8375614cc0ba8.zip
Merge branch 'jc/clone-remote-name-leak-fix'
"git clone --origin X" leaked piece of memory that held value read from the clone.defaultRemoteName configuration variable, which has been plugged. * jc/clone-remote-name-leak-fix: clone: plug a miniscule leak
Diffstat (limited to 'builtin')
-rw-r--r--builtin/clone.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/builtin/clone.c b/builtin/clone.c
index 5231656379..194d50f75f 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -1106,8 +1106,10 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
* apply the remote name provided by --origin only after this second
* call to git_config, to ensure it overrides all config-based values.
*/
- if (option_origin != NULL)
+ if (option_origin != NULL) {
+ free(remote_name);
remote_name = xstrdup(option_origin);
+ }
if (remote_name == NULL)
remote_name = xstrdup("origin");