diff options
| author | Jeff King <peff@peff.net> | 2015-09-24 23:07:31 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2015-09-25 19:18:18 +0200 |
| commit | 54ba4c5fa2d7de216ca090ac2e657728462c81d5 (patch) | |
| tree | c76231dded57746aa6478fe63dd5d35b49707bd3 /compat | |
| parent | http-push: use strbuf instead of fwrite_buffer (diff) | |
| download | git-54ba4c5fa2d7de216ca090ac2e657728462c81d5.tar.xz git-54ba4c5fa2d7de216ca090ac2e657728462c81d5.zip | |
http-walker: store url in a strbuf
We do an unchecked sprintf directly into our url buffer.
This doesn't overflow because we know that it was sized for
"$base/objects/info/http-alternates", and we are writing
"$base/objects/info/alternates", which must be smaller. But
that is not immediately obvious to a reader who is looking
for buffer overflows. Let's switch to a strbuf, so that we
do not have to think about this issue at all.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'compat')
0 files changed, 0 insertions, 0 deletions