diff options
| author | David Turner <dturner@twosigma.com> | 2017-04-18 23:57:43 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2017-04-19 04:58:04 +0200 |
| commit | 5781a9a2703e96b01587bb95ceebcc53f2cee91c (patch) | |
| tree | a0c233542e0d0e694a699f191a16c358d7415122 /fetch-pack.c | |
| parent | use HOST_NAME_MAX to size buffers for gethostname(2) (diff) | |
| download | git-5781a9a2703e96b01587bb95ceebcc53f2cee91c.tar.xz git-5781a9a2703e96b01587bb95ceebcc53f2cee91c.zip | |
xgethostname: handle long hostnames
If the full hostname doesn't fit in the buffer supplied to
gethostname, POSIX does not specify whether the buffer will be
null-terminated, so to be safe, we should do it ourselves. Introduce
new function, xgethostname, which ensures that there is always a \0
at the end of the buffer.
Signed-off-by: David Turner <dturner@twosigma.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'fetch-pack.c')
| -rw-r--r-- | fetch-pack.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fetch-pack.c b/fetch-pack.c index a75ed6c940..f43adfe7b5 100644 --- a/fetch-pack.c +++ b/fetch-pack.c @@ -746,7 +746,7 @@ static int get_pack(struct fetch_pack_args *args, argv_array_push(&cmd.args, "--fix-thin"); if (args->lock_pack || unpack_limit) { char hostname[HOST_NAME_MAX + 1]; - if (gethostname(hostname, sizeof(hostname))) + if (xgethostname(hostname, sizeof(hostname))) xsnprintf(hostname, sizeof(hostname), "localhost"); argv_array_pushf(&cmd.args, "--keep=fetch-pack %"PRIuMAX " on %s", |