diff options
author | Jeff King <peff@peff.net> | 2018-05-13 18:35:37 +0200 |
---|---|---|
committer | Jeff King <peff@peff.net> | 2018-05-22 05:55:12 +0200 |
commit | ed9c3220621d634d543bc4dd998d12167dfc57d4 (patch) | |
tree | 50393155b7372b6eb048e3b91ee708623ca3da69 /fsck.c | |
parent | index-pack: make fsck error message more specific (diff) | |
download | git-ed9c3220621d634d543bc4dd998d12167dfc57d4.tar.xz git-ed9c3220621d634d543bc4dd998d12167dfc57d4.zip |
fsck: simplify ".git" check
There's no need for us to manually check for ".git"; it's a
subset of the other filesystem-specific tests. Dropping it
makes our code slightly shorter. More importantly, the
existing code may make a reader wonder why ".GIT" is not
covered here, and whether that is a bug (it isn't, as it's
also covered in the filesystem-specific tests).
Signed-off-by: Jeff King <peff@peff.net>
Diffstat (limited to '')
-rw-r--r-- | fsck.c | 4 |
1 files changed, 1 insertions, 3 deletions
@@ -561,9 +561,7 @@ static int fsck_tree(struct tree *item, struct fsck_options *options) has_empty_name |= !*name; has_dot |= !strcmp(name, "."); has_dotdot |= !strcmp(name, ".."); - has_dotgit |= (!strcmp(name, ".git") || - is_hfs_dotgit(name) || - is_ntfs_dotgit(name)); + has_dotgit |= is_hfs_dotgit(name) || is_ntfs_dotgit(name); has_zero_pad |= *(char *)desc.buffer == '0'; if (update_tree_entry_gently(&desc)) { retval += report(options, &item->object, FSCK_MSG_BAD_TREE, "cannot be parsed as a tree"); |