summaryrefslogtreecommitdiffstats
path: root/pack-mtimes.c
diff options
context:
space:
mode:
authorJohannes Schindelin <johannes.schindelin@gmx.de>2022-06-16 01:35:43 +0200
committerJunio C Hamano <gitster@pobox.com>2022-06-16 22:22:03 +0200
commit41f1a8e6a417bc3e56a0eef687e28247138276d1 (patch)
treec14f4396511c8d270b66516f4c58196949ae0cc8 /pack-mtimes.c
parentread_index_from(): avoid memory leak (diff)
downloadgit-41f1a8e6a417bc3e56a0eef687e28247138276d1.tar.xz
git-41f1a8e6a417bc3e56a0eef687e28247138276d1.zip
pack-mtimes: avoid closing a bogus file descriptor
In 94cd775a6c52 (pack-mtimes: support reading .mtimes files, 2022-05-20), code was added to close the file descriptor corresponding to the mtimes file. However, it is possible that opening that file failed, in which case we are closing a file descriptor with the value `-1`. Let's guard that `close()` call. Reported by Coverity. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'pack-mtimes.c')
-rw-r--r--pack-mtimes.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/pack-mtimes.c b/pack-mtimes.c
index 0e0aafdcb0..0f9785fc5e 100644
--- a/pack-mtimes.c
+++ b/pack-mtimes.c
@@ -89,7 +89,8 @@ cleanup:
*data_p = data;
}
- close(fd);
+ if (fd >= 0)
+ close(fd);
return ret;
}