diff options
| author | Xin Li <delphij@google.com> | 2020-06-05 11:10:04 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2020-06-05 19:13:30 +0200 |
| commit | 14c7fa269e42df4133edd9ae7763b678ed6594cd (patch) | |
| tree | 5495da0e8ac4e16e1ac02158580b1e2593f98086 /setup.c | |
| parent | sparse-checkout: upgrade repository to version 1 when enabling extension (diff) | |
| download | git-14c7fa269e42df4133edd9ae7763b678ed6594cd.tar.xz git-14c7fa269e42df4133edd9ae7763b678ed6594cd.zip | |
check_repository_format_gently(): refuse extensions for old repositories
Previously, extensions were recognized regardless of repository format
version. If the user sets an undefined "extensions" value on a
repository of version 0 and that value is used by a future git version,
they might get an undesired result.
Because all extensions now also upgrade repository versions, tightening
the check would help avoid this for future extensions.
Signed-off-by: Xin Li <delphij@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'setup.c')
| -rw-r--r-- | setup.c | 12 |
1 files changed, 9 insertions, 3 deletions
@@ -507,9 +507,15 @@ static int check_repository_format_gently(const char *gitdir, struct repository_ die("%s", err.buf); } - repository_format_precious_objects = candidate->precious_objects; - set_repository_format_partial_clone(candidate->partial_clone); - repository_format_worktree_config = candidate->worktree_config; + if (candidate->version >= 1) { + repository_format_precious_objects = candidate->precious_objects; + set_repository_format_partial_clone(candidate->partial_clone); + repository_format_worktree_config = candidate->worktree_config; + } else { + repository_format_precious_objects = 0; + set_repository_format_partial_clone(NULL); + repository_format_worktree_config = 0; + } string_list_clear(&candidate->unknown_extensions, 0); if (repository_format_worktree_config) { |