diff options
| author | Johannes Schindelin <johannes.schindelin@gmx.de> | 2019-12-21 23:05:01 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2019-12-22 01:09:07 +0100 |
| commit | 4dc42c6c1867a52e22f1f04a1a247b5a7538b8af (patch) | |
| tree | 2198d9e1995d36e5448de2dcf2c9063563f03803 /t/t0060-path-utils.sh | |
| parent | mingw: short-circuit the conversion of `/dev/null` to UTF-16 (diff) | |
| download | git-4dc42c6c1867a52e22f1f04a1a247b5a7538b8af.tar.xz git-4dc42c6c1867a52e22f1f04a1a247b5a7538b8af.zip | |
mingw: refuse paths containing reserved names
There are a couple of reserved names that cannot be file names on
Windows, such as `AUX`, `NUL`, etc. For an almost complete list, see
https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file
If one would try to create a directory named `NUL`, it would actually
"succeed", i.e. the call would return success, but nothing would be
created.
Worse, even adding a file extension to the reserved name does not make
it a valid file name. To understand the rationale behind that behavior,
see https://devblogs.microsoft.com/oldnewthing/20031022-00/?p=42073
Let's just disallow them all.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to '')
| -rwxr-xr-x | t/t0060-path-utils.sh | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/t/t0060-path-utils.sh b/t/t0060-path-utils.sh index b193ed4205..eaf3be94e3 100755 --- a/t/t0060-path-utils.sh +++ b/t/t0060-path-utils.sh @@ -465,11 +465,14 @@ test_expect_success 'match .gitmodules' ' ' test_expect_success MINGW 'is_valid_path() on Windows' ' - test-tool path-utils is_valid_path \ + test-tool path-utils is_valid_path \ win32 \ "win32 x" \ ../hello.txt \ C:\\git \ + comm \ + conout.c \ + lptN \ \ --not \ "win32 " \ @@ -477,7 +480,13 @@ test_expect_success MINGW 'is_valid_path() on Windows' ' "win32." \ "win32 . ." \ .../hello.txt \ - colon:test + colon:test \ + "AUX.c" \ + "abc/conOut\$ .xyz/test" \ + lpt8 \ + "lpt*" \ + Nul \ + "PRN./abc" ' test_done |