summaryrefslogtreecommitdiffstats
path: root/t/t4018/dts-root-comment
diff options
context:
space:
mode:
authorStephen Boyd <sboyd@kernel.org>2019-10-20 20:52:30 +0200
committerJunio C Hamano <gitster@pobox.com>2019-10-21 10:44:12 +0200
commit8da56a484800023a545d7a7c022473f5aa9e720f (patch)
treee4feb0d793512ff670339b210a12346fade094db /t/t4018/dts-root-comment
parentuserdiff: add a builtin pattern for dts files (diff)
downloadgit-8da56a484800023a545d7a7c022473f5aa9e720f.tar.xz
git-8da56a484800023a545d7a7c022473f5aa9e720f.zip
userdiff: fix some corner cases in dts regex
While reviewing some dts diffs recently I noticed that the hunk header logic was failing to find the containing node. This is because the regex doesn't consider properties that may span multiple lines, i.e. property = <something>, <something_else>; and it got hung up on comments inside nodes that look like the root node because they start with '/*'. Add tests for these cases and update the regex to find them. Maybe detecting the root node is too complicated but forcing it to be a backslash with any amount of whitespace up to an open bracket seemed OK. I tried to detect that a comment is in-between the two parts but I wasn't happy so I just dropped it. Cc: Rob Herring <robh+dt@kernel.org> Cc: Frank Rowand <frowand.list@gmail.com> Signed-off-by: Stephen Boyd <sboyd@kernel.org> Reviewed-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4018/dts-root-comment')
-rw-r--r--t/t4018/dts-root-comment8
1 files changed, 8 insertions, 0 deletions
diff --git a/t/t4018/dts-root-comment b/t/t4018/dts-root-comment
new file mode 100644
index 0000000000..333a625c70
--- /dev/null
+++ b/t/t4018/dts-root-comment
@@ -0,0 +1,8 @@
+/ { RIGHT /* Technically just supposed to be a slash and brace */
+ #size-cells = <1>;
+
+ /* This comment should be ignored */
+
+ some-property = <40+2>;
+ ChangeMe = <0xffeedd00>;
+};