diff options
| author | Jeff King <peff@peff.net> | 2013-09-08 10:38:22 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2013-09-09 20:07:07 +0200 |
| commit | 2f666581bbc1895cf66a7007fb222026b299deb9 (patch) | |
| tree | 7a5dd7bdbfc6f99a060ec263330a21184c26a34a /t/t4055-diff-context.sh | |
| parent | config: set errno in numeric git_parse_* functions (diff) | |
| download | git-2f666581bbc1895cf66a7007fb222026b299deb9.tar.xz git-2f666581bbc1895cf66a7007fb222026b299deb9.zip | |
config: make numeric parsing errors more clear
If we try to parse an integer config argument and get a
number outside of the representable range, we die with the
cryptic message: "bad config value for '%s'".
We can improve two things:
1. Show the value that produced the error (e.g., bad
config value '3g' for 'foo.bar').
2. Mention the reason the value was rejected (e.g.,
"invalid unit" versus "out of range").
A few tests need to be updated with the new output, but that
should not be representative of real-world breakage, as
scripts should not be depending on the exact text of our
stderr output, which is subject to i18n anyway.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to '')
| -rwxr-xr-x | t/t4055-diff-context.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t4055-diff-context.sh b/t/t4055-diff-context.sh index 97172b46b2..cd0454356a 100755 --- a/t/t4055-diff-context.sh +++ b/t/t4055-diff-context.sh @@ -73,7 +73,7 @@ test_expect_success 'plumbing not affected' ' test_expect_success 'non-integer config parsing' ' git config diff.context no && test_must_fail git diff 2>output && - test_i18ngrep "bad config value" output + test_i18ngrep "bad numeric config value" output ' test_expect_success 'negative integer config parsing' ' |