diff options
| author | Jeff King <peff@peff.net> | 2014-03-21 00:14:33 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-03-21 22:11:11 +0100 |
| commit | 221bf985063737240124fe15c328cd125e9d048e (patch) | |
| tree | dda8ea5eb3b7418e5903cfc58954e121f6e4d6aa /t/t9130-git-svn-authors-file.sh | |
| parent | t/test-lib: drop redundant unset of GIT_CONFIG (diff) | |
| download | git-221bf985063737240124fe15c328cd125e9d048e.tar.xz git-221bf985063737240124fe15c328cd125e9d048e.zip | |
t: drop useless sane_unset GIT_* calls
Several test scripts manually unset GIT_CONFIG and other
GIT_* variables. These are generally taken care of for us by
test-lib.sh already.
Unsetting these is not only useless, but can be confusing to
a reader, who may wonder why some tests in a script unset
them and others do not (t0001 is particularly guilty of this
inconsistency, probably because many of its tests predate
the test-lib.sh environment-cleansing).
Note that we cannot always get rid of such unsetting. For
example, t9130 can drop the GIT_CONFIG unset, but not the
GIT_DIR one, because lib-git-svn.sh sets the latter. And in
t1000, we unset GIT_TEMPLATE_DIR, which is explicitly
initialized by test-lib.sh.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t9130-git-svn-authors-file.sh')
| -rwxr-xr-x | t/t9130-git-svn-authors-file.sh | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/t/t9130-git-svn-authors-file.sh b/t/t9130-git-svn-authors-file.sh index c3443ceb25..a812783798 100755 --- a/t/t9130-git-svn-authors-file.sh +++ b/t/t9130-git-svn-authors-file.sh @@ -97,7 +97,6 @@ test_expect_success 'fresh clone with svn.authors-file in config' ' test x = x"$(git config svn.authorsfile)" && test_config="$HOME"/.gitconfig && sane_unset GIT_DIR && - sane_unset GIT_CONFIG && git config --global \ svn.authorsfile "$HOME"/svn-authors && test x"$HOME"/svn-authors = x"$(git config svn.authorsfile)" && |