diff options
| author | Eric Sunshine <sunshine@sunshineco.com> | 2021-12-09 06:11:10 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2021-12-13 19:29:48 +0100 |
| commit | 03949e33f58223dd2d8465f4dd8042e5e581fcef (patch) | |
| tree | b5d3ed0b3bc19d18309a7563e6045442bd2346fc /t/t9400-git-cvsserver-server.sh | |
| parent | tests: apply modern idiom for signaling test failure (diff) | |
| download | git-03949e33f58223dd2d8465f4dd8042e5e581fcef.tar.xz git-03949e33f58223dd2d8465f4dd8042e5e581fcef.zip | |
tests: apply modern idiom for exiting loop upon failure
Rather than maintaining a flag indicating a failure within a loop and
aborting the test when the loop ends if the flag is set, modern practice
is to signal the failure immediately by exiting the loop early via
`return 1` (or `exit 1` if inside a subshell). Simplify these loops by
following the modern idiom.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Reviewed-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t9400-git-cvsserver-server.sh')
| -rwxr-xr-x | t/t9400-git-cvsserver-server.sh | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/t/t9400-git-cvsserver-server.sh b/t/t9400-git-cvsserver-server.sh index 17f988edd2..ca50574895 100755 --- a/t/t9400-git-cvsserver-server.sh +++ b/t/t9400-git-cvsserver-server.sh @@ -350,10 +350,9 @@ test_expect_success 'cvs update (subdirectories)' \ test_cmp "$dir/$filename" "../$dir/$filename"; then : else - echo >failure + exit 1 fi - done) && - test ! -f failure' + done)' cd "$WORKDIR" test_expect_success 'cvs update (delete file)' \ |