diff options
| author | Stepan Kasal <kasal@ucw.cz> | 2014-06-04 17:57:52 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-06-04 20:14:25 +0200 |
| commit | b93e6e36637bed9d80f9ffa786ea78044fde6bac (patch) | |
| tree | 09d99c7e31d8f19cbba35c2682060f5f22f2b0b2 /t/test-lib-functions.sh | |
| parent | Git 2.0 (diff) | |
| download | git-b93e6e36637bed9d80f9ffa786ea78044fde6bac.tar.xz git-b93e6e36637bed9d80f9ffa786ea78044fde6bac.zip | |
t5000, t5003: do not use test_cmp to compare binary files
test_cmp() is primarily meant to compare text files (and display the
difference for debug purposes).
Raw "cmp" is better suited to compare binary files (tar, zip, etc.).
On MinGW, test_cmp is a shell function mingw_test_cmp that tries to
read both files into environment, stripping CR characters (introduced
in commit 4d715ac0).
This function usually speeds things up, as fork is extremly slow on
Windows. But no wonder that this function is extremely slow and
sometimes even crashes when comparing large tar or zip files.
Signed-off-by: Stepan Kasal <kasal@ucw.cz>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to '')
| -rw-r--r-- | t/test-lib-functions.sh | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh index 158e10a67e..cf7b41f66d 100644 --- a/t/test-lib-functions.sh +++ b/t/test-lib-functions.sh @@ -617,6 +617,12 @@ test_cmp() { $GIT_TEST_CMP "$@" } +# test_cmp_bin - helper to compare binary files + +test_cmp_bin() { + cmp "$@" +} + # Check if the file expected to be empty is indeed empty, and barfs # otherwise. |