diff options
| author | Jeff King <peff@peff.net> | 2012-11-12 22:34:28 +0100 |
|---|---|---|
| committer | Jeff King <peff@peff.net> | 2012-11-12 22:34:53 +0100 |
| commit | 0f0ecf68b31303de7cb428554e27d433fe62180e (patch) | |
| tree | d1f8f5902fb5ff6dd45ba21e6fce2a5d6e7f185d /t | |
| parent | Git 1.7.12.4 (diff) | |
| download | git-0f0ecf68b31303de7cb428554e27d433fe62180e.tar.xz git-0f0ecf68b31303de7cb428554e27d433fe62180e.zip | |
gitweb: escape html in rss title
The title of an RSS feed is generated from many components,
including the filename provided as a query parameter, but we
failed to quote it. Besides showing the wrong output, this
is a vector for XSS attacks.
Signed-off-by: Jeff King <peff@peff.net>
Diffstat (limited to 't')
| -rwxr-xr-x | t/t9502-gitweb-standalone-parse-output.sh | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/t/t9502-gitweb-standalone-parse-output.sh b/t/t9502-gitweb-standalone-parse-output.sh index 731e64c3ad..3a8e7d3f5a 100755 --- a/t/t9502-gitweb-standalone-parse-output.sh +++ b/t/t9502-gitweb-standalone-parse-output.sh @@ -185,5 +185,20 @@ test_expect_success 'forks: project_index lists all projects (incl. forks)' ' test_cmp expected actual ' +xss() { + echo >&2 "Checking $1..." && + gitweb_run "$1" && + if grep "$TAG" gitweb.body; then + echo >&2 "xss: $TAG should have been quoted in output" + return 1 + fi + return 0 +} + +test_expect_success 'xss checks' ' + TAG="<magic-xss-tag>" && + xss "a=rss&p=$TAG" && + xss "a=rss&p=foo.git&f=$TAG" +' test_done |