diff options
| author | Jeff Hostetler <jeffhost@microsoft.com> | 2019-08-08 16:19:01 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2019-08-08 19:39:44 +0200 |
| commit | 04f10d332f47aed7d93ff3ed5c2bb3a366e44693 (patch) | |
| tree | 779d19cff88e2ab2a2a3022c581f606a21c24048 /trace2/tr2_tgt_normal.c | |
| parent | trace2: trim whitespace in region messages in perf target format (diff) | |
| download | git-04f10d332f47aed7d93ff3ed5c2bb3a366e44693.tar.xz git-04f10d332f47aed7d93ff3ed5c2bb3a366e44693.zip | |
trace2: remove dead code in maybe_add_string_va()
Remove an unnecessary "if" block in maybe_add_string_va().
Commit "ad006fe419e trace2: NULL is not allowed for va_list"
changed "if (fmt && *fmt && ap)" to just "if (fmt && *fmt)"
because it isn't safe to treat 'ap' as a pointer. This made
the "if" block following it unnecessary.
Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'trace2/tr2_tgt_normal.c')
| -rw-r--r-- | trace2/tr2_tgt_normal.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/trace2/tr2_tgt_normal.c b/trace2/tr2_tgt_normal.c index 00b116d797..47a1882557 100644 --- a/trace2/tr2_tgt_normal.c +++ b/trace2/tr2_tgt_normal.c @@ -135,11 +135,6 @@ static void maybe_append_string_va(struct strbuf *buf, const char *fmt, va_end(copy_ap); return; } - - if (fmt && *fmt) { - strbuf_addstr(buf, fmt); - return; - } } static void fn_error_va_fl(const char *file, int line, const char *fmt, |