diff options
| author | René Scharfe <l.s.r@web.de> | 2020-08-11 19:15:03 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2020-08-11 23:01:18 +0200 |
| commit | e767963ab6a542649c91f79fb686c58574b1ee86 (patch) | |
| tree | 79cae31cfb2a3d691d9627ff3c07f3ce337a375b /upload-pack.c | |
| parent | Git 2.28 (diff) | |
| download | git-e767963ab6a542649c91f79fb686c58574b1ee86.tar.xz git-e767963ab6a542649c91f79fb686c58574b1ee86.zip | |
upload-pack: remove superfluous sigchain_pop() call
2997178ee6 (upload-pack: split check_unreachable() in two, prep for
get_reachable_list(), 2016-06-12) moved most code of has_unreachable()
into the new function do_reachable_revlist(). The latter takes care to
ignore SIGPIPE during its operations, and restores the original signal
handler before returning.
However, a sigchain_pop(SIGPIPE) call remained in the error handling
code of has_unreachable(), which does nothing because the stack is
empty after do_reachable_revlist() cleaned up after itself. Remove it.
Signed-off-by: René Scharfe <l.s.r@web.de>
Reviewed-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'upload-pack.c')
| -rw-r--r-- | upload-pack.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/upload-pack.c b/upload-pack.c index 951a2b23aa..2f3ebd88b7 100644 --- a/upload-pack.c +++ b/upload-pack.c @@ -731,7 +731,6 @@ static int has_unreachable(struct object_array *src, enum allow_uor allow_uor) return 0; error: - sigchain_pop(SIGPIPE); if (cmd.out >= 0) close(cmd.out); return 1; |