diff options
author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2021-04-13 11:08:19 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2021-04-13 23:56:28 +0200 |
commit | c00c7382ddc1e3f2d773b14366023abf53ecce2c (patch) | |
tree | fc6b9f6754b923bc4c47684e7f9a2c4fda990dd5 /usage.c | |
parent | The eighth batch (diff) | |
download | git-c00c7382ddc1e3f2d773b14366023abf53ecce2c.tar.xz git-c00c7382ddc1e3f2d773b14366023abf53ecce2c.zip |
usage.c: don't copy/paste the same comment three times
In ee4512ed481 (trace2: create new combined trace facility,
2019-02-22) we started with two copies of this comment,
0ee10fd1296 (usage: add trace2 entry upon warning(), 2020-11-23) added
a third. Let's instead add an earlier comment that applies to all
these mostly-the-same functions.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to '')
-rw-r--r-- | usage.c | 17 |
1 files changed, 5 insertions, 12 deletions
@@ -55,12 +55,13 @@ static NORETURN void usage_builtin(const char *err, va_list params) exit(129); } +/* + * We call trace2_cmd_error_va() in the below functions first and + * expect it to va_copy 'params' before using it (because an 'ap' can + * only be walked once). + */ static NORETURN void die_builtin(const char *err, va_list params) { - /* - * We call this trace2 function first and expect it to va_copy 'params' - * before using it (because an 'ap' can only be walked once). - */ trace2_cmd_error_va(err, params); vreportf("fatal: ", err, params); @@ -70,10 +71,6 @@ static NORETURN void die_builtin(const char *err, va_list params) static void error_builtin(const char *err, va_list params) { - /* - * We call this trace2 function first and expect it to va_copy 'params' - * before using it (because an 'ap' can only be walked once). - */ trace2_cmd_error_va(err, params); vreportf("error: ", err, params); @@ -81,10 +78,6 @@ static void error_builtin(const char *err, va_list params) static void warn_builtin(const char *warn, va_list params) { - /* - * We call this trace2 function first and expect it to va_copy 'params' - * before using it (because an 'ap' can only be walked once). - */ trace2_cmd_error_va(warn, params); vreportf("warning: ", warn, params); |