From 554544276a604c144df45efcb060c80aa322088c Mon Sep 17 00:00:00 2001 From: Denton Liu Date: Mon, 29 Apr 2019 04:28:14 -0400 Subject: *.[ch]: remove extern from function declarations using spatch There has been a push to remove extern from function declarations. Remove some instances of "extern" for function declarations which are caught by Coccinelle. Note that Coccinelle has some difficulty with processing functions with `__attribute__` or varargs so some `extern` declarations are left behind to be dealt with in a future patch. This was the Coccinelle patch used: @@ type T; identifier f; @@ - extern T f(...); and it was run with: $ git ls-files \*.{c,h} | grep -v ^compat/ | xargs spatch --sp-file contrib/coccinelle/noextern.cocci --in-place Files under `compat/` are intentionally excluded as some are directly copied from external sources and we should avoid churning them as much as possible. Signed-off-by: Denton Liu Signed-off-by: Junio C Hamano --- column.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'column.h') diff --git a/column.h b/column.h index 2567a5cf4d..72cf539667 100644 --- a/column.h +++ b/column.h @@ -27,20 +27,20 @@ struct column_options { }; struct option; -extern int parseopt_column_callback(const struct option *, const char *, int); -extern int git_column_config(const char *var, const char *value, +int parseopt_column_callback(const struct option *, const char *, int); +int git_column_config(const char *var, const char *value, const char *command, unsigned int *colopts); -extern int finalize_colopts(unsigned int *colopts, int stdout_is_tty); +int finalize_colopts(unsigned int *colopts, int stdout_is_tty); static inline int column_active(unsigned int colopts) { return (colopts & COL_ENABLE_MASK) == COL_ENABLED; } struct string_list; -extern void print_columns(const struct string_list *list, unsigned int colopts, +void print_columns(const struct string_list *list, unsigned int colopts, const struct column_options *opts); -extern int run_column_filter(int colopts, const struct column_options *); -extern int stop_column_filter(void); +int run_column_filter(int colopts, const struct column_options *); +int stop_column_filter(void); #endif -- cgit v1.2.3