From ae22e8415d5ec2b52a4c83e181297ac15aeaced0 Mon Sep 17 00:00:00 2001 From: Taylor Blau Date: Fri, 8 Oct 2021 17:46:38 -0400 Subject: midx.c: guard against commit_lock_file() failures When writing a MIDX, we atomically move the new MIDX into place via commit_lock_file(), but do not check to see if that call was successful. Make sure that we do check in order to prevent us from incorrectly reporting that we wrote a new MIDX if we actually encountered an error. Signed-off-by: Taylor Blau Signed-off-by: Junio C Hamano --- midx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'midx.c') diff --git a/midx.c b/midx.c index f2c976051d..8433086ac1 100644 --- a/midx.c +++ b/midx.c @@ -1423,7 +1423,8 @@ static int write_midx_internal(const char *object_dir, if (ctx.m) close_object_store(the_repository->objects); - commit_lock_file(&lk); + if (commit_lock_file(&lk) < 0) + die_errno(_("could not write multi-pack-index")); clear_midx_files_ext(object_dir, ".bitmap", midx_hash); clear_midx_files_ext(object_dir, ".rev", midx_hash); -- cgit v1.2.3