From 8c46bf904fe95105faaa1823332c91d2802182c2 Mon Sep 17 00:00:00 2001 From: Michael Haggerty Date: Sat, 25 May 2013 11:08:21 +0200 Subject: string_list_add_refs_by_glob(): add a comment about memory management Since string_list_add_one_ref() adds refname to the string list, but the lifetime of refname is limited, it is important that the string_list passed to string_list_add_one_ref() has strdup_strings set. Document this fact. All current callers do the right thing. Signed-off-by: Michael Haggerty Signed-off-by: Junio C Hamano --- notes.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'notes.c') diff --git a/notes.c b/notes.c index fa7cdf7dd2..b69c0b8257 100644 --- a/notes.c +++ b/notes.c @@ -927,8 +927,12 @@ static int string_list_add_one_ref(const char *refname, const unsigned char *sha return 0; } +/* + * The list argument must have strdup_strings set on it. + */ void string_list_add_refs_by_glob(struct string_list *list, const char *glob) { + assert(list->strdup_strings); if (has_glob_specials(glob)) { for_each_glob_ref(string_list_add_one_ref, glob, list); } else { -- cgit v1.2.3