From fb678e639cd130cc718cff735e351f019d0c9164 Mon Sep 17 00:00:00 2001 From: Thomas Markwalder Date: Fri, 10 Jan 2014 11:11:15 -0500 Subject: [3033] Addressed review comments. Removed configuration parameter allow-client-update. It was deemed to really just be the inverse of override-client-update. Renamed convenience method isDhcpDdns to ddnsEnabled. Made enum to string converion functions case insenstive. Updated copyright dates and other cosmetic changes. --- src/lib/dhcp_ddns/tests/ncr_unittests.cc | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/lib/dhcp_ddns/tests/ncr_unittests.cc') diff --git a/src/lib/dhcp_ddns/tests/ncr_unittests.cc b/src/lib/dhcp_ddns/tests/ncr_unittests.cc index e71ddda5fe..c66b8919cc 100644 --- a/src/lib/dhcp_ddns/tests/ncr_unittests.cc +++ b/src/lib/dhcp_ddns/tests/ncr_unittests.cc @@ -611,6 +611,7 @@ TEST(NameChangeRequestTest, ipAddresses) { /// @brief Tests conversion of NameChangeFormat between enum and strings. TEST(NameChangeFormatTest, formatEnumConversion){ ASSERT_EQ(stringToNcrFormat("JSON"), dhcp_ddns::FMT_JSON); + ASSERT_EQ(stringToNcrFormat("jSoN"), dhcp_ddns::FMT_JSON); ASSERT_THROW(stringToNcrFormat("bogus"), isc::BadValue); ASSERT_EQ(ncrFormatToString(dhcp_ddns::FMT_JSON), "JSON"); @@ -619,7 +620,9 @@ TEST(NameChangeFormatTest, formatEnumConversion){ /// @brief Tests conversion of NameChangeProtocol between enum and strings. TEST(NameChangeProtocolTest, protocolEnumConversion){ ASSERT_EQ(stringToNcrProtocol("UDP"), dhcp_ddns::NCR_UDP); + ASSERT_EQ(stringToNcrProtocol("udP"), dhcp_ddns::NCR_UDP); ASSERT_EQ(stringToNcrProtocol("TCP"), dhcp_ddns::NCR_TCP); + ASSERT_EQ(stringToNcrProtocol("Tcp"), dhcp_ddns::NCR_TCP); ASSERT_THROW(stringToNcrProtocol("bogus"), isc::BadValue); ASSERT_EQ(ncrProtocolToString(dhcp_ddns::NCR_UDP), "UDP"); -- cgit v1.2.3