diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-01-14 18:57:16 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-02-19 01:21:43 +0100 |
| commit | 60cb8a9073ba81490afe0e5b1e8e9394528de10b (patch) | |
| tree | bd83148db560136bef8db1d4a5297e783170c7a4 | |
| parent | tty: vcc: Drop unnecessary if block (diff) | |
| download | linux-60cb8a9073ba81490afe0e5b1e8e9394528de10b.tar.xz linux-60cb8a9073ba81490afe0e5b1e8e9394528de10b.zip | |
tty: hvcs: Drop unnecessary if block
If hvcs_probe() succeeded dev_set_drvdata() is called with a non-NULL
value, and if hvcs_probe() failed hvcs_remove() isn't called.
So there is no way dev_get_drvdata() can return NULL in hvcs_remove() and
the check can just go away.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Reviewed-by: Tyrel Datwyler <tyreld@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/tty/hvc/hvcs.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c index 55105ac38f89..c6d1e6589edf 100644 --- a/drivers/tty/hvc/hvcs.c +++ b/drivers/tty/hvc/hvcs.c @@ -825,9 +825,6 @@ static int hvcs_remove(struct vio_dev *dev) unsigned long flags; struct tty_struct *tty; - if (!hvcsd) - return -ENODEV; - /* By this time the vty-server won't be getting any more interrupts */ spin_lock_irqsave(&hvcsd->lock, flags); |