diff options
author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-01-14 18:57:17 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2021-02-19 01:21:10 +0100 |
commit | e1d830ab32808dcb63861b63d44d96768f9cf7d3 (patch) | |
tree | 672ab2b90f7098c7f9a28e45dec94be41ad270cd | |
parent | tty: vcc: Drop impossible to hit WARN_ON (diff) | |
download | linux-e1d830ab32808dcb63861b63d44d96768f9cf7d3.tar.xz linux-e1d830ab32808dcb63861b63d44d96768f9cf7d3.zip |
tty: vcc: Drop unnecessary if block
If vcc_probe() succeeded dev_set_drvdata() is called with a non-NULL
value, and if vcc_probe() failed vcc_remove() isn't called.
So there is no way dev_get_drvdata() can return NULL in vcc_remove() and
the check can just go away.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/tty/vcc.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/tty/vcc.c b/drivers/tty/vcc.c index a4388a8d6bc7..e2d6205f83ce 100644 --- a/drivers/tty/vcc.c +++ b/drivers/tty/vcc.c @@ -681,9 +681,6 @@ static int vcc_remove(struct vio_dev *vdev) { struct vcc_port *port = dev_get_drvdata(&vdev->dev); - if (!port) - return -ENODEV; - del_timer_sync(&port->rx_timer); del_timer_sync(&port->tx_timer); |