diff options
| author | Johan Hovold <johan@kernel.org> | 2020-07-16 10:50:55 +0200 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2020-07-21 09:25:52 +0200 |
| commit | de37458f8c2bfc465500a1dd0d15dbe96d2a698c (patch) | |
| tree | 68a506ad39d916a0131739f21031bc2839cdf84d /Kconfig | |
| parent | USB: serial: sierra: clean up special-interface handling (diff) | |
| download | linux-de37458f8c2bfc465500a1dd0d15dbe96d2a698c.tar.xz linux-de37458f8c2bfc465500a1dd0d15dbe96d2a698c.zip | |
USB: serial: iuu_phoenix: fix led-activity helpers
The set-led command is eight bytes long and starts with a command byte
followed by six bytes of RGB data and ends with a byte encoding a
frequency (see iuu_led() and iuu_rgbf_fill_buffer()).
The led activity helpers had a few long-standing bugs which corrupted
the command packets by inserting a second command byte and thereby
offsetting the RGB data and dropping the frequency in non-xmas mode.
In xmas mode, a related off-by-one error left the frequency field
uninitialised.
Fixes: 60a8fc017103 ("USB: add iuu_phoenix driver")
Reported-by: George Spelvin <lkml@sdf.org>
Link: https://lore.kernel.org/r/20200716085056.31471-1-johan@kernel.org
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Diffstat (limited to 'Kconfig')
0 files changed, 0 insertions, 0 deletions