diff options
| author | Dapeng Mi <dapeng1.mi@linux.intel.com> | 2024-04-30 02:52:38 +0200 |
|---|---|---|
| committer | Sean Christopherson <seanjc@google.com> | 2024-06-03 23:23:14 +0200 |
| commit | 0e102ce3d4133194a26060fe987315133736c37b (patch) | |
| tree | 34444cf113919e8e643a088c67a49e979add9013 /arch/x86/kvm/pmu.h | |
| parent | KVM: VMX: Switch to new Intel CPU model infrastructure (diff) | |
| download | linux-0e102ce3d4133194a26060fe987315133736c37b.tar.xz linux-0e102ce3d4133194a26060fe987315133736c37b.zip | |
KVM: x86/pmu: Change ambiguous _mask suffix to _rsvd in kvm_pmu
Several '_mask' suffixed variables such as, global_ctrl_mask, are
defined in kvm_pmu structure. However the _mask suffix is ambiguous and
misleading since it's not a real mask with positive logic. On the contrary
it represents the reserved bits of corresponding MSRs and these bits
should not be accessed.
Suggested-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Link: https://lore.kernel.org/r/20240430005239.13527-2-dapeng1.mi@linux.intel.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
Diffstat (limited to 'arch/x86/kvm/pmu.h')
| -rw-r--r-- | arch/x86/kvm/pmu.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kvm/pmu.h b/arch/x86/kvm/pmu.h index 4d52b0b539ba..2eab8ea610db 100644 --- a/arch/x86/kvm/pmu.h +++ b/arch/x86/kvm/pmu.h @@ -129,7 +129,7 @@ static inline bool pmc_is_fixed(struct kvm_pmc *pmc) static inline bool kvm_valid_perf_global_ctrl(struct kvm_pmu *pmu, u64 data) { - return !(pmu->global_ctrl_mask & data); + return !(pmu->global_ctrl_rsvd & data); } /* returns general purpose PMC with the specified MSR. Note that it can be |