diff options
author | Peter Hutterer <peter.hutterer@who-t.net> | 2020-06-09 08:03:19 +0200 |
---|---|---|
committer | Jiri Kosina <jkosina@suse.cz> | 2020-06-16 17:24:58 +0200 |
commit | 1ad273d6ff2d3af6ce3a4c8bd81a2ba10151ae0e (patch) | |
tree | fff95dc0dcf086f7818fbe311ebfe85fc9c60658 /crypto/chacha20poly1305.c | |
parent | HID: usbhid: remove redundant assignment to variable retval (diff) | |
download | linux-1ad273d6ff2d3af6ce3a4c8bd81a2ba10151ae0e.tar.xz linux-1ad273d6ff2d3af6ce3a4c8bd81a2ba10151ae0e.zip |
HID: input: do not run GET_REPORT unless there's a Resolution Multiplier
hid-multitouch currently runs GET_REPORT for Contact Max and again to
retrieve the Win8 blob. If both are within the same report, the
Resolution Multiplier code calls GET_FEATURE again and this time,
possibly due to timing, it causes the ILITEK-TP device interpret the
GET_FEATURE as an instruction to change the mode and effectively stop
the device from functioning as expected.
Notably: the device doesn't even have a Resolution Multiplier so it
shouldn't be affected by any of this at all.
Fix this by making sure we only execute GET_REPORT if there is
a Resolution Multiplier in the respective report. Where the
HID_QUIRK_NO_INIT_REPORTS field is set we just bail out immediately. This
shouldn't be triggered by any real device anyway.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Tested-by: Wen He <wen.he_1@nxp.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'crypto/chacha20poly1305.c')
0 files changed, 0 insertions, 0 deletions