diff options
| author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2023-04-12 14:47:34 +0200 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2023-04-14 06:56:06 +0200 |
| commit | a9afc3e41c61688e26ba526a1f6c574608ae42d5 (patch) | |
| tree | cccb85c9a268c8b5c4e50aed5291076c52ea8d1f /drivers/net/dsa/ocelot/felix.c | |
| parent | net: mscc: ocelot: remove blank line at the end of ocelot_stats.c (diff) | |
| download | linux-a9afc3e41c61688e26ba526a1f6c574608ae42d5.tar.xz linux-a9afc3e41c61688e26ba526a1f6c574608ae42d5.zip | |
net: dsa: felix: remove confusing/incorrect comment from felix_setup()
That comment was written prior to knowing that what I was actually
seeing was a manifestation of the bug fixed in commit b4024c9e5c57
("felix: Fix initialization of ioremap resources").
There isn't any particular reason now why the hardware initialization is
done in felix_setup(), so just delete that comment to avoid spreading
misinformation.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/dsa/ocelot/felix.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c index 6dcebcfd71e7..80861ac090ae 100644 --- a/drivers/net/dsa/ocelot/felix.c +++ b/drivers/net/dsa/ocelot/felix.c @@ -1550,11 +1550,6 @@ static int felix_connect_tag_protocol(struct dsa_switch *ds, } } -/* Hardware initialization done here so that we can allocate structures with - * devm without fear of dsa_register_switch returning -EPROBE_DEFER and causing - * us to allocate structures twice (leak memory) and map PCI memory twice - * (which will not work). - */ static int felix_setup(struct dsa_switch *ds) { struct ocelot *ocelot = ds->priv; |