diff options
| author | Jose Ignacio Tornos Martinez <jtornosm@redhat.com> | 2024-04-05 10:24:31 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2024-04-08 12:47:59 +0200 |
| commit | 7c7be68346b9e30e343526bfac939efadc183e96 (patch) | |
| tree | 18a8caea566b5ded69f3c260a0fcdbef674892c8 /drivers/net/usb/ax88179_178a.c | |
| parent | pfcp: avoid copy warning by simplifing code (diff) | |
| download | linux-7c7be68346b9e30e343526bfac939efadc183e96.tar.xz linux-7c7be68346b9e30e343526bfac939efadc183e96.zip | |
net: usb: ax88179_178a: non necessary second random mac address
If the mac address can not be read from the device registers or the
devicetree, a random address is generated, but this was already done from
usbnet_probe, so it is not necessary to call eth_hw_addr_random from here
again to generate another random address.
Indeed, when reset was also executed from bind, generate another random mac
address invalidated the check from usbnet_probe to configure if the assigned
mac address for the interface was random or not, because it is comparing
with the initial generated random address. Now, with only a reset from open
operation, it is just a harmless simplification.
Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/usb/ax88179_178a.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index a9c418890a1c..69169842fa2f 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -1277,7 +1277,6 @@ static void ax88179_get_mac_addr(struct usbnet *dev) dev->net->addr_assign_type = NET_ADDR_PERM; } else { netdev_info(dev->net, "invalid MAC address, using random\n"); - eth_hw_addr_random(dev->net); } ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, ETH_ALEN, |