summaryrefslogtreecommitdiffstats
path: root/lib/locking-selftest-wlock-softirq.h
diff options
context:
space:
mode:
authorBoris Burkov <boris@bur.io>2022-10-14 00:52:10 +0200
committerDavid Sterba <dsterba@suse.com>2022-12-05 18:00:39 +0100
commit81531225e5bd50ce628816cc1445c8b52aa99db2 (patch)
tree63430ab65db6e18e8810f27a0774bb0758f6f718 /lib/locking-selftest-wlock-softirq.h
parentbtrfs: skip reclaim if block_group is empty (diff)
downloadlinux-81531225e5bd50ce628816cc1445c8b52aa99db2.tar.xz
linux-81531225e5bd50ce628816cc1445c8b52aa99db2.zip
btrfs: re-check reclaim condition in reclaim worker
I have observed the following case play out and lead to unnecessary relocations: 1. write a file across multiple block groups 2. delete the file 3. several block groups fall below the reclaim threshold 4. reclaim the first, moving extents into the others 5. reclaim the others which are now actually very full, leading to poor reclaim behavior with lots of writing, allocating new block groups, etc. I believe the risk of missing some reasonable reclaims is worth it when traded off against the savings of avoiding overfull reclaims. Going forward, it could be interesting to make the check more advanced (zoned aware, fragmentation aware, etc...) so that it can be a really strong signal both at extent delete and reclaim time. Reviewed-by: Filipe Manana <fdmanana@suse.com> Signed-off-by: Boris Burkov <boris@bur.io> Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'lib/locking-selftest-wlock-softirq.h')
0 files changed, 0 insertions, 0 deletions